diff mbox series

[v1] crypto/qat: skip SM3 HMAC on QAT when no SM3 slice exists

Message ID 20231113162245.327793-1-venkatx.sivaramakrishnan@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series [v1] crypto/qat: skip SM3 HMAC on QAT when no SM3 slice exists |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/github-robot: build success github build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional fail Functional issues
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS

Commit Message

Sivaramakrishnan Venkat Nov. 13, 2023, 4:22 p.m. UTC 
  Add check to skip SM3 HMAC on QAT when no SM3 slice exists

Fixes: 171c655 ("crypto/qat: add SM3 HMAC to GEN4 devices")
Cc: arkadiuszx.kusztal@intel.com
Cc: stable@dpdk.org

Signed-off-by: Sivaramakrishnan Venkat <venkatx.sivaramakrishnan@intel.com>
---
 drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Power, Ciara Nov. 13, 2023, 5:39 p.m. UTC | #1 
> -----Original Message-----
> From: Sivaramakrishnan Venkat <venkatx.sivaramakrishnan@intel.com>
> Sent: Monday, November 13, 2023 4:23 PM
> To: Ji, Kai <kai.ji@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; gakhil@marvell.com; Sivaramakrishnan,
> VenkatX <venkatx.sivaramakrishnan@intel.com>; Kusztal, ArkadiuszX
> <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH v1] crypto/qat: skip SM3 HMAC on QAT when no SM3 slice
> exists
> 
> Add check to skip SM3 HMAC on QAT when no SM3 slice exists
> 
> Fixes: 171c655 ("crypto/qat: add SM3 HMAC to GEN4 devices")
> Cc: arkadiuszx.kusztal@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Sivaramakrishnan Venkat
> <venkatx.sivaramakrishnan@intel.com>

Acked-by: Ciara Power <ciara.power@intel.com>
Akhil Goyal Nov. 16, 2023, 5:55 p.m. UTC | #2 
> > Subject: [PATCH v1] crypto/qat: skip SM3 HMAC on QAT when no SM3 slice
> > exists
> >
> > Add check to skip SM3 HMAC on QAT when no SM3 slice exists
> >
> > Fixes: 171c655 ("crypto/qat: add SM3 HMAC to GEN4 devices")
> > Cc: arkadiuszx.kusztal@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Sivaramakrishnan Venkat
> > <venkatx.sivaramakrishnan@intel.com>
> 
> Acked-by: Ciara Power <ciara.power@intel.com>
Applied to dpdk-next-crypto
Thanks.
diff mbox series

Patch

diff --git a/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c b/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c
index 0a939161f9..93c64abc6e 100644
--- a/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c
+++ b/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c
@@ -243,7 +243,9 @@  qat_sym_crypto_cap_get_gen3(struct qat_cryptodev_private *internals,
 		}
 		if (slice_map & ICP_ACCEL_MASK_SM3_SLICE && (
 			check_auth_capa(&capabilities[iter],
-				RTE_CRYPTO_AUTH_SM3))) {
+				RTE_CRYPTO_AUTH_SM3) ||
+			check_auth_capa(&capabilities[iter],
+				RTE_CRYPTO_AUTH_SM3_HMAC))) {
 			continue;
 		}
 		memcpy(addr + curr_capa, capabilities + iter,