[5/5] doc/features: add dump device private information feature

Message ID 20231123135916.33315-6-lihuisong@huawei.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series doc/features: fix some features and add new features |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/github-robot: build fail github build: failed
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS

Commit Message

lihuisong (C) Nov. 23, 2023, 1:59 p.m. UTC
  Add dump device private information feature.

Fixes: edcf22c6d389 ("ethdev: introduce dump API")
Cc: stable@dpdk.org

Signed-off-by: Huisong Li <lihuisong@huawei.com>
---
 doc/guides/nics/features.rst | 12 ++++++++++++
 1 file changed, 12 insertions(+)
  

Comments

Thomas Monjalon Nov. 23, 2023, 2:18 p.m. UTC | #1
23/11/2023 14:59, Huisong Li:
> +.. _nic_features_device_private_info_dump:
> +
> +Device private information dump
> +--------------

Why underlining is too short?

> +
> +Supports retrieving device private information to a file. Provided data and
> +the order depends on PMD.
> +
> +* **[mplements] eth_dev_ops**: ``eth_dev_priv_dump``.

looks like a typo here

> +* **[related]    API**: ``rte_eth_dev_priv_dump()``.
  
lihuisong (C) Nov. 24, 2023, 2:03 a.m. UTC | #2
在 2023/11/23 22:18, Thomas Monjalon 写道:
> 23/11/2023 14:59, Huisong Li:
>> +.. _nic_features_device_private_info_dump:
>> +
>> +Device private information dump
>> +--------------
> Why underlining is too short?
You are right.
Then I got this warning email which is the same as you said.😁
will fix it in v2.
>
>> +
>> +Supports retrieving device private information to a file. Provided data and
>> +the order depends on PMD.
>> +
>> +* **[mplements] eth_dev_ops**: ``eth_dev_priv_dump``.
> looks like a typo here
Ack.
>
>> +* **[related]    API**: ``rte_eth_dev_priv_dump()``.
>
>
> .
  

Patch

diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index 69fbf737b8..bae1a1faab 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -820,6 +820,18 @@  registers and register size).
 * **[related]    API**: ``rte_eth_dev_get_reg_info()``.
 
 
+.. _nic_features_device_private_info_dump:
+
+Device private information dump
+--------------
+
+Supports retrieving device private information to a file. Provided data and
+the order depends on PMD.
+
+* **[mplements] eth_dev_ops**: ``eth_dev_priv_dump``.
+* **[related]    API**: ``rte_eth_dev_priv_dump()``.
+
+
 .. _nic_features_led:
 
 LED