| Message ID | 20231203112543.844014-10-michaelba@nvidia.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Raslan Darawsheh |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 062174365F; Sun, 3 Dec 2023 12:27:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E57B40A8A; Sun, 3 Dec 2023 12:26:36 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2043.outbound.protection.outlook.com [40.107.223.43]) by mails.dpdk.org (Postfix) with ESMTP id 6140240A81 for <dev@dpdk.org>; Sun, 3 Dec 2023 12:26:35 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ca2UbqLxSBcKtZhApZ0lhGEW2rG7Nz3gktCdJWLNa5ZHGSVOfQ5VMcpxPTGBvlyrmlo78Q7KxzqDvAtuP9G+a+o8VZaxlxFs/BP4K3tK1EcjjNH3zG5MTVkQUmaJiexXXnLBY4WoR2l8FCqysgEH7iLWrQjrcRLF1BusyJihj03SLQdpNoeQrZf5GRvgDiAGWtid5eVkMLTQvIvizSTSnbcJeDLe581gPDfPj8BERgxw43ELGGjKArGCRKsmkQRe9iseynmSs2BVWwSG88h+No08XLbWNvxutzmqQWRV3s0sXo6nMJf3uJuse3Cfy1V4UB2NB7CKcSo7S+Fdfv8QdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uX+fkL8/keGhk4GqKMFgqjDnErcGmpNOlh8Qv3Y1Qbk=; b=jIrEdBXVr6Y0G7XLYeMBjC0/sQdfTXXeGsWHJpVtR4na0o7ExN8GdBbNfy0cj1W0Pgk6jS4doTg6xEfKJ24lAJUocsLFq0Xxx149ogzSfLyPOI7j80tD1+JZOgJ0zE2i1BA58p5h3qcnsAynU+caCwNOJFPp6Kjk5QEU358q72H/T4Fu2iQMapsdhW/BflYqUYTQv5Kxe7AKPCmuYkSCg2ar9gzWiiaYGGs/UD8m1kRC2MjWSfqeH0KkMYhGDxA46hTW15ih9wByahIcxHdxUJU4fsDDYFd4FfGhXHQ17PyJKOvuAsGkKKt/SYafuY57ZFJto8wTaHNEmzbPoe++YA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uX+fkL8/keGhk4GqKMFgqjDnErcGmpNOlh8Qv3Y1Qbk=; b=qfFvxiC1/QZZ2lTrPG3W9tsC5SE26jDXuNde4U7Y9vL9PuaYFTzHK2/hQFZyR5FTknlcTFQ20lG9pVjlrDY3nRPa1hNXVALOl80DjlRzOf2SYFTFf/Lk+VJCK620j1lbRxJuMLwigMgT5WYu5tbC+Pxe0tjuEb2o4JV74e1P0NQR6xGmWHu30j6ZyDeswZ0+KlKru/VTgRGkbKffyJBQC95UKZdXre0Ypx+sl3l4/rVn2DkZCqLHK9ni7jCBrIDaekG9B6qrbbjWrJh+sxTmg34jyGvnWv6moTxerQpQh1Z6BOVass+Cyu6qA2Px1q/GY848uzoYLbMaNxKMlTJAuA== Received: from BYAPR03CA0025.namprd03.prod.outlook.com (2603:10b6:a02:a8::38) by CH2PR12MB4071.namprd12.prod.outlook.com (2603:10b6:610:7b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.32; Sun, 3 Dec 2023 11:26:30 +0000 Received: from CO1PEPF000042A9.namprd03.prod.outlook.com (2603:10b6:a02:a8:cafe::3) by BYAPR03CA0025.outlook.office365.com (2603:10b6:a02:a8::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.33 via Frontend Transport; Sun, 3 Dec 2023 11:26:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1PEPF000042A9.mail.protection.outlook.com (10.167.243.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.20 via Frontend Transport; Sun, 3 Dec 2023 11:26:29 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 3 Dec 2023 03:26:12 -0800 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 3 Dec 2023 03:26:11 -0800 Received: from nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41 via Frontend Transport; Sun, 3 Dec 2023 03:26:09 -0800 From: Michael Baum <michaelba@nvidia.com> To: <dev@dpdk.org> CC: Matan Azrad <matan@nvidia.com>, Raslan Darawsheh <rasland@nvidia.com>, Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Ori Kam <orika@nvidia.com>, Suanming Mou <suanmingm@nvidia.com> Subject: [PATCH v1 09/23] common/mlx5: add sample info query syndrome into error log Date: Sun, 3 Dec 2023 13:25:29 +0200 Message-ID: <20231203112543.844014-10-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231203112543.844014-1-michaelba@nvidia.com> References: <20231203112543.844014-1-michaelba@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042A9:EE_|CH2PR12MB4071:EE_ X-MS-Office365-Filtering-Correlation-Id: 9ff098fd-468a-4d59-30c7-08dbf3f2b222 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xYA0YvTF4N22acDOWCoVWwWFhWqqP8rGSgj/B3fGPQwznj+Zy+cyEmFkajnGfrmyKDHSZlWhUvU/bI7SyW0fxR1r6EvICvtT+KTpBNMhF53juyUX9koDs1eFASuTYt5OM+98Nyg5EGtcbcbEe+SQhLPVuQTECKxbZP5CH3uPrdyg8HtnICatstirjivDSx/y+Woq8O+zjqEpfnEHrh4nm3laVqk2vUP6DUM8WasSa/YChn9pJqi9Ea8S5sSd4DIaKI1c+u3hi06gXnF2ARgIiYHlt8DtwhmAasIpgvLokWgT2lchpchX9OU5FBJkNtoFVOKL1vYO+JpgvK0AMyj86gq25FEf6HrBfxKLh8jpXBXbyv+gnev/BwV5Dlrusby6YG1gR+sRC2WXi5gwBl2Ppk25jwDU04S/e0H1BG7MJ0f0LEF/mQyS/FQ1Qvjj4G3DcWTb5ZQEOpm8gC5cjOFWXJV/ZD79YieKaTQByVfOqQMJ4hov/zsSLymNNpfZwAMwKvBYZ22qKSiIHFUmmqlw+qY64Y2KNREIPBq+gwQCMpAmBoX5Y+yA1q6SL+Hfhpb2o8HtGIoiKehdyUJVj2ikfeeibtpqjkunhvmoKQ0qWOg2YIsyIufP075juMOHv6BX9HpKu4ZFe5u7ILWvlPnJFsjK16ttTGSmy+JgCm89xkEIUWS/bnvEYS+UT7CdIhbJQ3PPbvrLKtz2VsiuC9GgYDkVYW7IG44TjMdxD382DVgRlY7QJrA6tl6FBzbxEoAW X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(396003)(136003)(39860400002)(376002)(346002)(230922051799003)(186009)(451199024)(82310400011)(64100799003)(1800799012)(46966006)(36840700001)(40470700004)(40460700003)(6916009)(54906003)(316002)(86362001)(8936002)(8676002)(4326008)(70586007)(478600001)(70206006)(41300700001)(36756003)(5660300002)(2906002)(36860700001)(356005)(7636003)(47076005)(1076003)(2616005)(6286002)(26005)(107886003)(7696005)(6666004)(83380400001)(82740400003)(426003)(336012)(40480700001)(55016003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2023 11:26:29.7871 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9ff098fd-468a-4d59-30c7-08dbf3f2b222 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042A9.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4071 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
| Series |
net/mlx5: support Geneve and options for HWS
|
|
Checks
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
Commit Message
Michael Baum
Dec. 3, 2023, 11:25 a.m. UTC
Move "mlx5_devx_cmd_match_sample_info_query()" function to use
"DEVX_DRV_LOG" in case of "devx_general_cmd" failure.
This macro contains syndrome report and used by all other function
calling "devx_general_cmd".
Signed-off-by: Michael Baum <michaelba@nvidia.com>
---
drivers/common/mlx5/mlx5_devx_cmds.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c index 674130c11f..b30f54ab1c 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.c +++ b/drivers/common/mlx5/mlx5_devx_cmds.c @@ -641,11 +641,10 @@ mlx5_devx_cmd_match_sample_info_query(void *ctx, uint32_t sample_field_id, MLX5_SET(query_match_sample_info_in, in, sample_field_id, sample_field_id); rc = mlx5_glue->devx_general_cmd(ctx, in, sizeof(in), out, sizeof(out)); - if (rc) { - DRV_LOG(ERR, "Failed to query match sample info using DevX: %s", - strerror(rc)); - rte_errno = rc; - return -rc; + if (rc || MLX5_FW_STATUS(out)) { + DEVX_DRV_LOG(ERR, out, "query match sample info", + "sample_field_id", sample_field_id); + return MLX5_DEVX_ERR_RC(rc); } attr->modify_field_id = MLX5_GET(query_match_sample_info_out, out, modify_field_id);