From patchwork Sun Dec 3 11:25:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Baum X-Patchwork-Id: 134749 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AEE7D4365F; Sun, 3 Dec 2023 12:26:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7D36540608; Sun, 3 Dec 2023 12:26:20 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2060.outbound.protection.outlook.com [40.107.93.60]) by mails.dpdk.org (Postfix) with ESMTP id 2D767402F2 for ; Sun, 3 Dec 2023 12:26:19 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZcAHqyI+iLXL745IIeuMjOKfuSwfCbYa1wbOQqD//QW12I1rfbpbtlGDGjlCk4/t7Gee9LwHW5m5tVgXgyiUg4sVG3iHmh1dDjZZ1cyIlDTGQqdEsJna87XJ1wDNYl+O9Ide1utcwBNHBoAkBX/b65aU1l9DGUkPHP57Me0t6BZICcaQZlkZ4AaSa0zyHboXQ6r4NYmG/R0Ar2zt3Xe+samt85DDDExfiAkClsG+jTR5twZ6sk/GRfEUN8EI1j0qLcVln0SeSl25xtNWtHSwWZkum+IGK/rtefdn5tnQ6L6ZEwzgfQjQbj3PBSHHKdrw14f60WhUqGBIH/fCcE+yNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uh5NS1B7paKILNL6b+d6iAI9WwS4+U1lvlSVGDZ3KyA=; b=RgvnA98uQ3no+mxuUTWzU2pZMSnwowyMMHiLrD5Gc1xp15sjqn7wREtpMyW92jB3RqOQwKhMh8KwZ9yVWmXc+bdBDCuxYQzkBRPjTLRgtTMDwg5wAD6tvLC1/jRjZ9oWlCXMvehM7lKcz/OdJP+FiIlnD8wjnjAjzk4WXXgp0zXuRARbQNZ/Y5naF4WTJarU4tBCPvF1O/S6E9fOokaq372xlOkfCGXCNypZnGu7Al9k72ZHrluEDt4A3zVew+aMF5r6eGJM2H1YNvCuoK/Yg3mTJrQ56v/j+BMvNcRUbmgw6DOVFthdYVwXuK2Qne8LNKgLa5xpkXdfkZTMfh74jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uh5NS1B7paKILNL6b+d6iAI9WwS4+U1lvlSVGDZ3KyA=; b=NUihaGV8FfYopkE/2UFVlO0+sGxybl0wUKQOLgs2aQ4jHgS6MseSV24fzG5DzDnHfYstwWj3ka0LFeQi7V/A/yQY3sQ3wpSdJ0pdhl3iHDknHnN67ZnmiPWOWKh8O+z69mVkP9lxKSTgBeZsc3jJrD7qBeV2qn1ZtQT7fD7Q2P/dHt6rtkJg6j+DL8MConXUE/yJfQnhr7tzP2YsfTqdyESIZSsoqjpVHf4mCCnrokoxCEpeP+keGAUWpQYWoWpaNfdL2QcODZWVt4MMJTiz8fLitHLS7P/yD+b/hDH53KpeTyf2wzKdeh575/iGPfw0zfj7kiHbeOlq+PVpWJmpnA== Received: from SJ0PR05CA0156.namprd05.prod.outlook.com (2603:10b6:a03:339::11) by IA1PR12MB8555.namprd12.prod.outlook.com (2603:10b6:208:44f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.32; Sun, 3 Dec 2023 11:26:16 +0000 Received: from CO1PEPF000042AE.namprd03.prod.outlook.com (2603:10b6:a03:339:cafe::d9) by SJ0PR05CA0156.outlook.office365.com (2603:10b6:a03:339::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.21 via Frontend Transport; Sun, 3 Dec 2023 11:26:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1PEPF000042AE.mail.protection.outlook.com (10.167.243.43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.20 via Frontend Transport; Sun, 3 Dec 2023 11:26:16 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 3 Dec 2023 03:26:00 -0800 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 3 Dec 2023 03:26:00 -0800 Received: from nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41 via Frontend Transport; Sun, 3 Dec 2023 03:25:58 -0800 From: Michael Baum To: CC: Matan Azrad , Raslan Darawsheh , Viacheslav Ovsiienko , Ori Kam , Suanming Mou , Subject: [PATCH v1 04/23] net/mlx5: remove GENEVE options length limitation Date: Sun, 3 Dec 2023 13:25:24 +0200 Message-ID: <20231203112543.844014-5-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231203112543.844014-1-michaelba@nvidia.com> References: <20231203112543.844014-1-michaelba@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042AE:EE_|IA1PR12MB8555:EE_ X-MS-Office365-Filtering-Correlation-Id: 1cb40844-eaf1-40ed-cfb1-08dbf3f2aa05 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hc14i+XaHsWHNBhYLCsMOz3jiW3C1luwfF2iKUE6F7su9+Cqmn4UsbuwY33gsWg2BeAYK5uibcZndHIYofJcv3c+juVt3SkGmiuaUj5imYsG9E/CnL5akJKcJNLeLw3MdOz6QY25+68hDq/8vgTHyQdipWvd+TNXvVHGuD2NKOUj3maJg58MPg9D3bDrDZLjOtYVleIIyBLW5srttN26XZvuccaORGjloc1nZ/s4BwPVDAWuCX71Urv9QD4wX/wXBu5Y5ExchzuTxa16ELE3vJomrkGAudBdSxE5PG7EX40f2TNIsER9XYWE1gEms6HNIvhFYDDZZuMgr/gd15wYY/XlhHZd5AoUQLsRONAjBWHrz9dVphuscYmDAUlfK9TJWSYB40xEuS1+iWx6BVESmwZ5Ocw/Hax7IrjUoE5N7Hbm+APFWYexN15un0I3Loa0CSTFo3QG6QyQ4HSWJ5BBoEVVYO01RDcjwo4nFkxnjunv5R93uw8wqwr09eKAUKM9+6522lFAcg97nJ2NqsksPHvpuByXjVuO5eHKZRbOAP5jNHS3EQLEzkziVYGUN3rFRZLe2K0/LjUfCQ4rmIIzOjoHtSxp2Nr89Vq+rK5uHhWnfyT7FvRY3YNVAfnpfVPIWFyIch9bIF2RFwRhECtk5+NidtpPxb3kqn/zIWQu1vnKYwvygb2uBGio9lAu3qSISnIARK2LVOwGr67OcQeNQKYBdrm+L5/ueS/NCVK5Wg1sg934VOBTM9emt2+PfHj0 X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(346002)(376002)(136003)(396003)(39860400002)(230922051799003)(451199024)(82310400011)(64100799003)(186009)(1800799012)(46966006)(40470700004)(36840700001)(107886003)(1076003)(2616005)(8936002)(8676002)(4326008)(7696005)(47076005)(40480700001)(55016003)(7636003)(356005)(83380400001)(36860700001)(426003)(336012)(82740400003)(6286002)(26005)(478600001)(40460700003)(6666004)(54906003)(70206006)(70586007)(316002)(6916009)(2906002)(41300700001)(36756003)(86362001)(5660300002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2023 11:26:16.1793 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1cb40844-eaf1-40ed-cfb1-08dbf3f2aa05 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042AE.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8555 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org GENEVE header has field named "opt_len" describing the total length of all GENEVE options in 4-byte granularity. In SW sreering implementation, only single option with single DW data is supported. When matching on GENEVE option data is requested, matching on "opt_len" field is added according to given option length. This behaveior assumes that only packets with single option can be matched, but it is wrong, packet with a few option can be matched but only one of them can match its value. This patch removes the "opt_len" matching unless user ask it explicitly. Fixes: e440d6cf589e ("net/mlx5: add GENEVE TLV option flow translation") Cc: shirik@nvidia.com Signed-off-by: Michael Baum --- drivers/net/mlx5/mlx5_flow_dv.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 115d730317..62ca742654 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -9986,7 +9986,6 @@ flow_dv_translate_item_geneve_opt(struct rte_eth_dev *dev, void *key, const struct rte_flow_item_geneve_opt *geneve_opt_m; const struct rte_flow_item_geneve_opt *geneve_opt_v; const struct rte_flow_item_geneve_opt *geneve_opt_vv = item->spec; - void *misc_v = MLX5_ADDR_OF(fte_match_param, key, misc_parameters); void *misc3_v = MLX5_ADDR_OF(fte_match_param, key, misc_parameters_3); rte_be32_t opt_data_key = 0, opt_data_mask = 0; uint32_t *data; @@ -10005,21 +10004,6 @@ flow_dv_translate_item_geneve_opt(struct rte_eth_dev *dev, void *key, return ret; } } - /* - * Set the option length in GENEVE header if not requested. - * The GENEVE TLV option length is expressed by the option length field - * in the GENEVE header. - * If the option length was not requested but the GENEVE TLV option item - * is present we set the option length field implicitly. - */ - if (!MLX5_GET16(fte_match_set_misc, misc_v, geneve_opt_len)) { - if (key_type & MLX5_SET_MATCHER_M) - MLX5_SET(fte_match_set_misc, misc_v, geneve_opt_len, - MLX5_GENEVE_OPTLEN_MASK); - else - MLX5_SET(fte_match_set_misc, misc_v, geneve_opt_len, - geneve_opt_v->option_len + 1); - } /* Set the data. */ if (key_type == MLX5_SET_MATCHER_SW_V) data = geneve_opt_vv->data;