diff mbox series

[RFC,v2,02/14] regexdev: fix logtype register

Message ID 20231208145950.2184940-3-david.marchand@redhat.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series Detect superfluous newline in logs |

Commit Message

David Marchand Dec. 8, 2023, 2:59 p.m. UTC 
  This library logtype was not initialized so its logs would end up under
the 0 logtype, iow, RTE_LOGTYPE_EAL.

Fixes: b25246beaefc ("regexdev: add core functions")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 lib/regexdev/rte_regexdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephen Hemminger Dec. 8, 2023, 4:58 p.m. UTC | #1 
On Fri,  8 Dec 2023 15:59:36 +0100
David Marchand <david.marchand@redhat.com> wrote:

> This library logtype was not initialized so its logs would end up under
> the 0 logtype, iow, RTE_LOGTYPE_EAL.
> 
> Fixes: b25246beaefc ("regexdev: add core functions")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>


Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
Tyler Retzlaff Dec. 8, 2023, 8:46 p.m. UTC | #2 
On Fri, Dec 08, 2023 at 03:59:36PM +0100, David Marchand wrote:
> This library logtype was not initialized so its logs would end up under
> the 0 logtype, iow, RTE_LOGTYPE_EAL.
> 
> Fixes: b25246beaefc ("regexdev: add core functions")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---

Reviewed-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Ori Kam Dec. 14, 2023, 10:11 a.m. UTC | #3 
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Friday, December 8, 2023 5:00 PM
> 
> This library logtype was not initialized so its logs would end up under
> the 0 logtype, iow, RTE_LOGTYPE_EAL.
> 
> Fixes: b25246beaefc ("regexdev: add core functions")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  lib/regexdev/rte_regexdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/regexdev/rte_regexdev.c b/lib/regexdev/rte_regexdev.c
> index caec069182..d38a85eb0b 100644
> --- a/lib/regexdev/rte_regexdev.c
> +++ b/lib/regexdev/rte_regexdev.c
> @@ -19,7 +19,7 @@ static struct {
>  	struct rte_regexdev_data data[RTE_MAX_REGEXDEV_DEVS];
>  } *rte_regexdev_shared_data;
> 
> -int rte_regexdev_logtype;
> +RTE_LOG_REGISTER_DEFAULT(rte_regexdev_logtype, INFO);
> 
>  static uint16_t
>  regexdev_find_free_dev(void)
> --
> 2.43.0

Acked-by: Ori Kam <orika@nvidia.com>
Best,
Or
diff mbox series

Patch

diff --git a/lib/regexdev/rte_regexdev.c b/lib/regexdev/rte_regexdev.c
index caec069182..d38a85eb0b 100644
--- a/lib/regexdev/rte_regexdev.c
+++ b/lib/regexdev/rte_regexdev.c
@@ -19,7 +19,7 @@  static struct {
 	struct rte_regexdev_data data[RTE_MAX_REGEXDEV_DEVS];
 } *rte_regexdev_shared_data;
 
-int rte_regexdev_logtype;
+RTE_LOG_REGISTER_DEFAULT(rte_regexdev_logtype, INFO);
 
 static uint16_t
 regexdev_find_free_dev(void)