diff mbox series

[RFC,v2,06/14] eal/linux: remove log paraphrasing the doc

Message ID 20231208145950.2184940-7-david.marchand@redhat.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series Detect superfluous newline in logs |

Commit Message

David Marchand Dec. 8, 2023, 2:59 p.m. UTC 
  An error log message does not need to paraphrase the DPDK documentation.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 lib/eal/linux/eal_timer.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

Stephen Hemminger Dec. 8, 2023, 5:03 p.m. UTC | #1 
On Fri,  8 Dec 2023 15:59:40 +0100
David Marchand <david.marchand@redhat.com> wrote:

> An error log message does not need to paraphrase the DPDK documentation.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Agree.

Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Tyler Retzlaff Dec. 8, 2023, 8:54 p.m. UTC | #2 
On Fri, Dec 08, 2023 at 03:59:40PM +0100, David Marchand wrote:
> An error log message does not need to paraphrase the DPDK documentation.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---

Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
diff mbox series

Patch

diff --git a/lib/eal/linux/eal_timer.c b/lib/eal/linux/eal_timer.c
index 3a30284e3a..df9ad61ae9 100644
--- a/lib/eal/linux/eal_timer.c
+++ b/lib/eal/linux/eal_timer.c
@@ -152,11 +152,7 @@  rte_eal_hpet_init(int make_default)
 	}
 	eal_hpet = mmap(NULL, 1024, PROT_READ, MAP_SHARED, fd, 0);
 	if (eal_hpet == MAP_FAILED) {
-		RTE_LOG(ERR, EAL, "ERROR: Cannot mmap "DEV_HPET"!\n"
-				"Please enable CONFIG_HPET_MMAP in your kernel configuration "
-				"to allow HPET support.\n"
-				"To run without using HPET, unset RTE_LIBEAL_USE_HPET "
-				"in your build configuration or use '--no-hpet' EAL flag.\n");
+		RTE_LOG(ERR, EAL, "ERROR: Cannot mmap "DEV_HPET"!\n");
 		close(fd);
 		internal_conf->no_hpet = 1;
 		return -1;