diff mbox series

[05/26] net/bnxt: replace RTE_LOG_DP with rte_log_dp

Message ID	20231213014408.612051-6-stephen@networkplumber.org (mailing list archive)
State	Superseded, archived
Delegated to:	Thomas Monjalon
Headers	From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org>, Ajit Khaparde <ajit.khaparde@broadcom.com>, Somnath Kotur <somnath.kotur@broadcom.com>, Ruifeng Wang <ruifeng.wang@arm.com>, Bruce Richardson <bruce.richardson@intel.com>, Konstantin Ananyev <konstantin.v.ananyev@yandex.ru> Subject: [PATCH 05/26] net/bnxt: replace RTE_LOG_DP with rte_log_dp Date: Tue, 12 Dec 2023 17:42:21 -0800 Message-ID: <20231213014408.612051-6-stephen@networkplumber.org> In-Reply-To: <20231213014408.612051-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	Replace uses of RTE_LOGTYPE_PMD \| [00/26] Replace uses of RTE_LOGTYPE_PMD [01/26] log: fix doc comment for RTE_LOG_DP() [02/26] log: add rte_log_dp() [03/26] net/atlantic: replace RTE_LOG_DP with rte_log_dp [04/26] net/avp: replace RTE_LOG_DP with rte_log_dp [05/26] net/bnxt: replace RTE_LOG_DP with rte_log_dp [06/26] net/dpaa: replace RTE_LOG_DP with rte_log_dp [07/26] net/dpaa2: replace RTE_LOG_DP with rte_log_dp [08/26] net/enetc: replace RTE_LOG_DP with rte_log_dp [09/26] net/enetfec: replace RTE_LOG_DP with rte_log_dp [10/26] net/igc: replace RTE_LOG_DP with rte_log_dp [11/26] net/mana: replace RTE_LOG_DP with rte_log_dp [12/26] net/mvpp2: do not use PMD logtype [13/26] net/octeon_ep: replace RTE_LOG_DP with rte_log_dp [14/26] net/pfe: replace RTE_LOG_DP with rte_log_dp [15/26] net/qede: replace RTE_LOG_DP with rte_log_dp [16/26] net/virtio: replace RTE_LOG_DP with rte_log_dp [17/26] net/vmxnet3: do not use PMD logtype [18/26] common/cnxk: replace RTE_LOG_DP with rte_log_dp [19/26] common/cpt: replace RTE_LOG_DP with rte_log_dp [20/26] common/sfc_efx: remove use of PMD logtype [21/26] common/dpaax: do not use PMD logtype [22/26] basband/la12xx: replace RTE_LOG_DP with rte_log_dp [23/26] bus/cdx: replace RTE_LOG_DP with rte_log_dp [24/26] bus/fslmc: replace RTE_LOG_DP with rte_log_dp [25/26] dma/dpaa, dma/dpaa2: replace RTE_LOG_DP with rte_log_dp [26/26] mempool/dpaa, mempool/dpaa2: do not use logtype PMD

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Stephen Hemminger Dec. 13, 2023, 1:42 a.m. UTC

  Want datapath logs to use own logtype.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/bnxt/bnxt.h               | 5 +++++
 drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 3 +--
 drivers/net/bnxt/bnxt_rxtx_vec_sse.c  | 3 +--
 drivers/net/bnxt/bnxt_txr.c           | 4 +---
 4 files changed, 8 insertions(+), 7 deletions(-)

Comments

Somnath Kotur Dec. 13, 2023, 3:07 a.m. UTC | #1

On Wed, Dec 13, 2023 at 7:14 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> Want datapath logs to use own logtype.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  drivers/net/bnxt/bnxt.h               | 5 +++++
>  drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 3 +--
>  drivers/net/bnxt/bnxt_rxtx_vec_sse.c  | 3 +--
>  drivers/net/bnxt/bnxt_txr.c           | 4 +---
>  4 files changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h
> index 0e01b1d4baea..3aa9213a12f9 100644
> --- a/drivers/net/bnxt/bnxt.h
> +++ b/drivers/net/bnxt/bnxt.h
> @@ -1058,6 +1058,11 @@ extern int bnxt_logtype_driver;
>  #define PMD_DRV_LOG(level, fmt, args...) \
>           PMD_DRV_LOG_RAW(level, fmt, ## args)
>
> +#define PMD_DRV_LOG_DP(level, fmt, args...)                    \
> +       rte_log_dp(RTE_LOG_ ## level, bnxt_logtype_driver,      \
> +                  fmt, ## args)
> +
> +
>  extern const struct rte_flow_ops bnxt_ulp_rte_flow_ops;
>  int32_t bnxt_ulp_port_init(struct bnxt *bp);
>  void bnxt_ulp_port_deinit(struct bnxt *bp);
> diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_neon.c b/drivers/net/bnxt/bnxt_rxtx_vec_neon.c
> index aa1b1ab8bb7e..64c1dfac47d9 100644
> --- a/drivers/net/bnxt/bnxt_rxtx_vec_neon.c
> +++ b/drivers/net/bnxt/bnxt_rxtx_vec_neon.c
> @@ -357,8 +357,7 @@ bnxt_handle_tx_cp_vec(struct bnxt_tx_queue *txq)
>                 if (likely(CMP_TYPE(txcmp) == TX_CMPL_TYPE_TX_L2))
>                         nb_tx_pkts += txcmp->opaque;
>                 else
> -                       RTE_LOG_DP(ERR, PMD,
> -                                  "Unhandled CMP type %02x\n",
> +                       PMD_DRV_LOG_DP(ERR, "Unhandled CMP type %02x\n",
>                                    CMP_TYPE(txcmp));
>                 raw_cons = NEXT_RAW_CMP(raw_cons);
>         } while (nb_tx_pkts < ring_mask);
> diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
> index e99a547f5857..572b21a00837 100644
> --- a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
> +++ b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
> @@ -326,8 +326,7 @@ bnxt_handle_tx_cp_vec(struct bnxt_tx_queue *txq)
>                 if (likely(CMP_TYPE(txcmp) == TX_CMPL_TYPE_TX_L2))
>                         nb_tx_pkts += txcmp->opaque;
>                 else
> -                       RTE_LOG_DP(ERR, PMD,
> -                                  "Unhandled CMP type %02x\n",
> +                       PMD_DRV_LOG_DP(ERR, "Unhandled CMP type %02x\n",
>                                    CMP_TYPE(txcmp));
>                 raw_cons = NEXT_RAW_CMP(raw_cons);
>         } while (nb_tx_pkts < ring_mask);
> diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c
> index 899986764f93..bd0a75653ab3 100644
> --- a/drivers/net/bnxt/bnxt_txr.c
> +++ b/drivers/net/bnxt/bnxt_txr.c
> @@ -542,9 +542,7 @@ static int bnxt_handle_tx_cp(struct bnxt_tx_queue *txq)
>                 if (CMP_TYPE(txcmp) == TX_CMPL_TYPE_TX_L2)
>                         nb_tx_pkts += opaque;
>                 else
> -                       RTE_LOG_DP(ERR, PMD,
> -                                       "Unhandled CMP type %02x\n",
> -                                       CMP_TYPE(txcmp));
> +                       PMD_DRV_LOG_DP(ERR, "Unhandled CMP type %02x\n", CMP_TYPE(txcmp));
>                 raw_cons = NEXT_RAW_CMP(raw_cons);
>         } while (nb_tx_pkts < ring_mask);
>
> --
> 2.42.0
>
Acked-by: Somnath Kotur <somnath.kotur@broadcom.com>

diff mbox series

Patch

diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h
index 0e01b1d4baea..3aa9213a12f9 100644
--- a/drivers/net/bnxt/bnxt.h
+++ b/drivers/net/bnxt/bnxt.h
@@ -1058,6 +1058,11 @@  extern int bnxt_logtype_driver;
 #define PMD_DRV_LOG(level, fmt, args...) \
 	  PMD_DRV_LOG_RAW(level, fmt, ## args)
 
+#define PMD_DRV_LOG_DP(level, fmt, args...)			\
+	rte_log_dp(RTE_LOG_ ## level, bnxt_logtype_driver,	\
+		   fmt, ## args)
+
+
 extern const struct rte_flow_ops bnxt_ulp_rte_flow_ops;
 int32_t bnxt_ulp_port_init(struct bnxt *bp);
 void bnxt_ulp_port_deinit(struct bnxt *bp);
diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_neon.c b/drivers/net/bnxt/bnxt_rxtx_vec_neon.c
index aa1b1ab8bb7e..64c1dfac47d9 100644
--- a/drivers/net/bnxt/bnxt_rxtx_vec_neon.c
+++ b/drivers/net/bnxt/bnxt_rxtx_vec_neon.c
@@ -357,8 +357,7 @@  bnxt_handle_tx_cp_vec(struct bnxt_tx_queue *txq)
 		if (likely(CMP_TYPE(txcmp) == TX_CMPL_TYPE_TX_L2))
 			nb_tx_pkts += txcmp->opaque;
 		else
-			RTE_LOG_DP(ERR, PMD,
-				   "Unhandled CMP type %02x\n",
+			PMD_DRV_LOG_DP(ERR, "Unhandled CMP type %02x\n",
 				   CMP_TYPE(txcmp));
 		raw_cons = NEXT_RAW_CMP(raw_cons);
 	} while (nb_tx_pkts < ring_mask);
diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
index e99a547f5857..572b21a00837 100644
--- a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
+++ b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
@@ -326,8 +326,7 @@  bnxt_handle_tx_cp_vec(struct bnxt_tx_queue *txq)
 		if (likely(CMP_TYPE(txcmp) == TX_CMPL_TYPE_TX_L2))
 			nb_tx_pkts += txcmp->opaque;
 		else
-			RTE_LOG_DP(ERR, PMD,
-				   "Unhandled CMP type %02x\n",
+			PMD_DRV_LOG_DP(ERR, "Unhandled CMP type %02x\n",
 				   CMP_TYPE(txcmp));
 		raw_cons = NEXT_RAW_CMP(raw_cons);
 	} while (nb_tx_pkts < ring_mask);
diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c
index 899986764f93..bd0a75653ab3 100644
--- a/drivers/net/bnxt/bnxt_txr.c
+++ b/drivers/net/bnxt/bnxt_txr.c
@@ -542,9 +542,7 @@  static int bnxt_handle_tx_cp(struct bnxt_tx_queue *txq)
 		if (CMP_TYPE(txcmp) == TX_CMPL_TYPE_TX_L2)
 			nb_tx_pkts += opaque;
 		else
-			RTE_LOG_DP(ERR, PMD,
-					"Unhandled CMP type %02x\n",
-					CMP_TYPE(txcmp));
+			PMD_DRV_LOG_DP(ERR, "Unhandled CMP type %02x\n", CMP_TYPE(txcmp));
 		raw_cons = NEXT_RAW_CMP(raw_cons);
 	} while (nb_tx_pkts < ring_mask);