From patchwork Thu Dec 14 15:12:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Baum X-Patchwork-Id: 135207 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80729436F1; Thu, 14 Dec 2023 16:13:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D149A432F0; Thu, 14 Dec 2023 16:13:28 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2081.outbound.protection.outlook.com [40.107.93.81]) by mails.dpdk.org (Postfix) with ESMTP id E5561432EC for ; Thu, 14 Dec 2023 16:13:26 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YgMi6XKBOAov87faRt5FEtgj7I5MltfW677i2ZJkJKvTWCbmFG73XaOxLw4hzPRz2VXwV1S/0BZfmzeVBKdlHx/6UngLbrQBSlpzCuPhVaQYbIzAHMm8iYEO+AMtQ36exHMhjJFINmFJnTiD0VPpCHntOTUlOKHNa1Jl05TMrp8nAhb+sQ3/1j/AzlY64KD7a4wA6l+6D01SZkNJor7rR95qfmnE22Qtu9enQjWGjIzBGGvB2jG7ptFJXawbZh0PW9hw0YeYj4HtFWVWYNJILtWCfWCNOtvOdONGdCf1JXlDqz9+9RvQca8/DvpVgdcZCgTaqekgbXLz/5dOegnrww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GqsV6cz8wX46TZkFBXz4T60qxs3aOXhFeCoCOr+R4WA=; b=SMqo7t1XDCkvLDGljssIUJDG2wFmgdtqeTLS6Raa/x39kHeDKRYehrlVKlZiqYLhUSrLXYjxXbFmJL/I1HBzHBgcKv/Uw0ebSPVduk3c/2vI5QRGxTbaNIuhJJrB8hAPFmUH+89O1UIA4QHAWSRUaagpaYlmJHOCWngBBzBK9iBPnu56SM5/6HP64MEBGTq3DIxJd+LnxZGqxL0AB2ysYpk8abo/mdEeh7mXbGNV5JT/IZLLI3gNLN1yajg2nL/wdiC5BhL7HWcjz35NmB7pYaYrI7ctb6daGkWA0PF94kUjb/gXgPq+37VoC/+LJW3SxqDle0EVlBdJnHVAPcilpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GqsV6cz8wX46TZkFBXz4T60qxs3aOXhFeCoCOr+R4WA=; b=RXC8SocXOcQhoDAqNySx0+JvT/nbb/Sy6DDAyX7UqNrUM6++zys0OJeq4fxswnfOHOhqO4cvc6p2LOoA+fKXPjBAKozDlmngvIMiYBw6Noe0cUndRAgz1tNK9HPSMnnVrTf2RvfT1Tn/Upj94tDeeMWMQGyH7NUcs0RXg4Xp7hZUmhJ6uH89ms8QTC62wBndeVrKJaF6jpR7WU4a/MFMrXA7R9LXEqEVz7jViILb6CGhWtDQYZaID7QFRYJks2HXKtQO6rJnv1XkqQmJR62hrPCZygxk6pT1xKH+1SqLF3w01dfI8XIsFQ9M9l1evEpLgknb/K7mCWmMfF8P3gNTxA== Received: from BLAPR03CA0149.namprd03.prod.outlook.com (2603:10b6:208:32e::34) by PH7PR12MB5734.namprd12.prod.outlook.com (2603:10b6:510:1e1::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.28; Thu, 14 Dec 2023 15:13:21 +0000 Received: from BL6PEPF0001AB4B.namprd04.prod.outlook.com (2603:10b6:208:32e:cafe::1b) by BLAPR03CA0149.outlook.office365.com (2603:10b6:208:32e::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.28 via Frontend Transport; Thu, 14 Dec 2023 15:13:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL6PEPF0001AB4B.mail.protection.outlook.com (10.167.242.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.26 via Frontend Transport; Thu, 14 Dec 2023 15:13:21 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 14 Dec 2023 07:13:05 -0800 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 14 Dec 2023 07:13:04 -0800 Received: from nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41 via Frontend Transport; Thu, 14 Dec 2023 07:13:02 -0800 From: Michael Baum To: CC: Matan Azrad , Dariusz Sosnowski , Raslan Darawsheh , Viacheslav Ovsiienko , Ori Kam , Suanming Mou Subject: [PATCH v3 2/2] net/mlx5: add random item support Date: Thu, 14 Dec 2023 17:12:48 +0200 Message-ID: <20231214151248.1654878-3-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231214151248.1654878-1-michaelba@nvidia.com> References: <20231130164001.666702-1-michaelba@nvidia.com> <20231214151248.1654878-1-michaelba@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB4B:EE_|PH7PR12MB5734:EE_ X-MS-Office365-Filtering-Correlation-Id: 8f7d7de6-63aa-494b-c33c-08dbfcb735e8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Hp4yWG2hi9xQTvYGZMweI7fxEKP9MWPLfUIycQsVsRckRorMQPXdEZKj/Ylfv4Br5Lnxa9OULoU/VAkOqgX11pUXZqKvNPrNDztDPL37AI5mXITLeG5cPE355jqErF+6vJBTy3AGLelMuTb32UHNZocMIJM74prn2NweZNza7FiJip2Ado1LeljO3VN1Rcw9Xx95f8KKYZed4uSFnpUjrvXl1nUTT1YKjA/dsUt2OR38SOZfWk+FnevizTKbRleF8fQvYrth3Gm4VeEboMJSLAhto28ic0nsXMqjQUmwwtU0oEJnUcAQXo4LENzfAdv6moduUJTtnf/OzS4p2RFbxice3LXI996HyamDODlm6MA7SAn3rNsI63x5ZoC+MwJVLHQA2blKNI9zKRhIwjYRSfi4Vdcwly4yTA+GxvvfLx9jMV5hxDYe0+U++8S1L0GQ55X436B82Vm4WPT7eGFmI3H3qPvCMJtMMhJlRtRIF7va787PD8NutERSbO7Guf1S0seX76i3KkpQb3aD1SBbIcVfIdFzD57ZnM8EvzamtHCa0ryPKdDiLt+Ub0S+HkLWhCP6lTwcBItwBagiIz6mqUVa4fB5aE2DH71s0apkZwLKYpMV+fSmIKBXAM39VOz1pE2C4ycnAZbtkGjulQoLvO1MGsrqyc8wdPShOv6bNYdFWmQUKi2h3M78Olv/uo0FMZzwVlOh/vnJSBL8DsDjmZBdTc7wrC+J/s2TcWLJ5kMZH4dFUsZJ9hxQcbvPRBqW X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(376002)(346002)(136003)(39860400002)(396003)(230922051799003)(186009)(1800799012)(451199024)(64100799003)(82310400011)(36840700001)(40470700004)(46966006)(4326008)(8936002)(2906002)(316002)(83380400001)(36756003)(7636003)(40460700003)(82740400003)(8676002)(5660300002)(47076005)(36860700001)(7696005)(26005)(6286002)(336012)(41300700001)(2616005)(107886003)(478600001)(1076003)(6666004)(55016003)(54906003)(6916009)(356005)(70206006)(70586007)(86362001)(40480700001)(426003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2023 15:13:21.4687 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8f7d7de6-63aa-494b-c33c-08dbfcb735e8 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB4B.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5734 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add support for random item in HWS mode. Signed-off-by: Michael Baum Acked-by: Dariusz Sosnowski --- doc/guides/nics/features/mlx5.ini | 1 + doc/guides/nics/mlx5.rst | 9 +++++++++ doc/guides/rel_notes/release_24_03.rst | 3 +++ drivers/net/mlx5/mlx5_flow_dv.c | 5 +++++ drivers/net/mlx5/mlx5_flow_hw.c | 5 +++++ 5 files changed, 23 insertions(+) diff --git a/doc/guides/nics/features/mlx5.ini b/doc/guides/nics/features/mlx5.ini index 0739fe9d63..6261b7d657 100644 --- a/doc/guides/nics/features/mlx5.ini +++ b/doc/guides/nics/features/mlx5.ini @@ -88,6 +88,7 @@ port_id = Y port_representor = Y ptype = Y quota = Y +random = Y tag = Y tcp = Y udp = Y diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 6b52fb93c5..971c229850 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc/guides/nics/mlx5.rst @@ -167,6 +167,7 @@ Features - Sub-Function. - Matching on represented port. - Matching on aggregated affinity. +- Matching on random value. Limitations @@ -564,6 +565,7 @@ Limitations - Modification of the MPLS header is supported only in HWS and only to copy from, the encapsulation level is always 0. - Modification of the 802.1Q Tag, VXLAN Network or GENEVE Network ID's is not supported. + - Modify field action using ``RTE_FLOW_FIELD_RANDOM`` is not supported. - Encapsulation levels are not supported, can modify outermost header fields only. - Offsets cannot skip past the boundary of a field. - If the field type is ``RTE_FLOW_FIELD_MAC_TYPE`` @@ -770,6 +772,13 @@ Limitations - In HW steering (``dv_flow_en`` = 2): - not supported on guest port. +- Match on random value: + + - Supported only with HW Steering enabled (``dv_flow_en`` = 2). + - Supported only in table with ``nb_flows=1``. + - NIC ingress/egress flow in group 0 is not supported. + - Supports matching only 16 bits (LSB). + - During live migration to a new process set its flow engine as standby mode, the user should only program flow rules in group 0 (``fdb_def_rule_en=0``). Live migration is only supported under SWS (``dv_flow_en=1``). diff --git a/doc/guides/rel_notes/release_24_03.rst b/doc/guides/rel_notes/release_24_03.rst index 819cef7f20..93e58b55ca 100644 --- a/doc/guides/rel_notes/release_24_03.rst +++ b/doc/guides/rel_notes/release_24_03.rst @@ -60,6 +60,9 @@ New Features * Added ``RTE_FLOW_ITEM_TYPE_RANDOM`` to match random value. * Added ``RTE_FLOW_FIELD_RANDOM`` to represent it in field API. +* **Updated NVIDIA mlx5 net driver.** + + * Added support for ``RTE_FLOW_ITEM_TYPE_RANDOM`` flow item. Removed Items ------------- diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 115d730317..67a44095d7 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -5396,6 +5396,11 @@ flow_dv_validate_action_modify_field(struct rte_eth_dev *dev, RTE_FLOW_ERROR_TYPE_ACTION, action, "modifications of the MPLS header " "is not supported"); + if (dst_data->field == RTE_FLOW_FIELD_RANDOM || + src_data->field == RTE_FLOW_FIELD_RANDOM) + return rte_flow_error_set(error, ENOTSUP, + RTE_FLOW_ERROR_TYPE_ACTION, action, + "modifications of random value is not supported"); if (dst_data->field == RTE_FLOW_FIELD_MARK || src_data->field == RTE_FLOW_FIELD_MARK) if (config->dv_xmeta_en == MLX5_XMETA_MODE_LEGACY || diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index da873ae2e2..af4e9abd89 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -5047,6 +5047,10 @@ flow_hw_validate_action_modify_field(struct rte_eth_dev *dev, return rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, action, "modifying vlan_type is not supported"); + if (flow_hw_modify_field_is_used(action_conf, RTE_FLOW_FIELD_RANDOM)) + return rte_flow_error_set(error, EINVAL, + RTE_FLOW_ERROR_TYPE_ACTION, action, + "modifying random value is not supported"); if (flow_hw_modify_field_is_used(action_conf, RTE_FLOW_FIELD_GENEVE_VNI)) return rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, action, @@ -6807,6 +6811,7 @@ flow_hw_pattern_validate(struct rte_eth_dev *dev, case RTE_FLOW_ITEM_TYPE_FLEX: case RTE_FLOW_ITEM_TYPE_IB_BTH: case RTE_FLOW_ITEM_TYPE_PTYPE: + case RTE_FLOW_ITEM_TYPE_RANDOM: break; case RTE_FLOW_ITEM_TYPE_INTEGRITY: /*