The skeleton is supposed to match current best practices.
Change it to use dynamic logtype.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/event/skeleton/skeleton_eventdev.c | 3 ++-
drivers/event/skeleton/skeleton_eventdev.h | 8 ++++++--
2 files changed, 8 insertions(+), 3 deletions(-)
On Mon, Dec 18, 2023 at 8:28 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> The skeleton is supposed to match current best practices.
> Change it to use dynamic logtype.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/event/skeleton/skeleton_eventdev.c | 3 ++-
> drivers/event/skeleton/skeleton_eventdev.h | 8 ++++++--
> 2 files changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/event/skeleton/skeleton_eventdev.c b/drivers/event/skeleton/skeleton_eventdev.c
> index 7df032b7daa1..df50d2e4e4ff 100644
> --- a/drivers/event/skeleton/skeleton_eventdev.c
> +++ b/drivers/event/skeleton/skeleton_eventdev.c
> @@ -457,7 +457,7 @@ skeleton_eventdev_probe(struct rte_vdev_device *vdev)
> const char *name;
>
> name = rte_vdev_device_name(vdev);
> - RTE_LOG(INFO, PMD, "Initializing %s on NUMA node %d\n", name,
> + PMD_DRV_LOG(INFO, "Initializing %s on NUMA node %d\n", name,
> rte_socket_id());
> return skeleton_eventdev_create(name, rte_socket_id(), vdev);
> }
No \n please.
@@ -457,7 +457,7 @@ skeleton_eventdev_probe(struct rte_vdev_device *vdev)
const char *name;
name = rte_vdev_device_name(vdev);
- RTE_LOG(INFO, PMD, "Initializing %s on NUMA node %d\n", name,
+ PMD_DRV_LOG(INFO, "Initializing %s on NUMA node %d\n", name,
rte_socket_id());
return skeleton_eventdev_create(name, rte_socket_id(), vdev);
}
@@ -479,3 +479,4 @@ static struct rte_vdev_driver vdev_eventdev_skeleton_pmd = {
};
RTE_PMD_REGISTER_VDEV(EVENTDEV_NAME_SKELETON_PMD, vdev_eventdev_skeleton_pmd);
+RTE_LOG_REGISTER_DEFAULT(skeleton_eventdev_logtype, INFO);
@@ -8,9 +8,12 @@
#include <eventdev_pmd_pci.h>
#include <eventdev_pmd_vdev.h>
+extern int skeleton_eventdev_logtype;
+
#ifdef RTE_LIBRTE_PMD_SKELETON_EVENTDEV_DEBUG
#define PMD_DRV_LOG(level, fmt, args...) \
- RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args)
+ rte_log(RTE_LOG_ ## level, skeleton_eventdev_logtype, \
+ "%s(): " fmt "\n", __func__, ## args)
#define PMD_DRV_FUNC_TRACE() PMD_DRV_LOG(DEBUG, ">>")
#else
#define PMD_DRV_LOG(level, fmt, args...) do { } while (0)
@@ -18,7 +21,8 @@
#endif
#define PMD_DRV_ERR(fmt, args...) \
- RTE_LOG(ERR, PMD, "%s(): " fmt "\n", __func__, ## args)
+ rte_log(RTE_LOG_ERR, skeleton_eventdev_logtype, \
+ "%s(): " fmt "\n", __func__, ## args)
struct skeleton_eventdev {
uintptr_t reg_base;