From patchwork Wed Dec 20 15:36:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 135408 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B8C143728; Wed, 20 Dec 2023 16:38:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 997D742EA8; Wed, 20 Dec 2023 16:38:20 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1EAD842E83 for ; Wed, 20 Dec 2023 16:38:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703086697; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q+IvhZatbKG+EdR6WiMTSVx7VtCQdqID2k86eZ4iPtY=; b=K5rh7wqCLPI0RrHS2YIHBwkHNAiPG7GvfoVAJ93FygF94mLdIqAguQN/m9i3/dq3Ng2Sg2 9X6VGcTnpOlrq7WZmAxfiTJtProoI3XlVwL69C3ZyaTPLnx1xxUPLr6oKRSFy92xsCXblr IDXtdX0e7i3GlfVI3X4IbLm/G1uOv6U= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-504-9Xy_Yv9NN0-aj9UBAYJ1Ug-1; Wed, 20 Dec 2023 10:38:14 -0500 X-MC-Unique: 9Xy_Yv9NN0-aj9UBAYJ1Ug-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DF38A3C000A1; Wed, 20 Dec 2023 15:38:13 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.224.218]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5557B492BC6; Wed, 20 Dec 2023 15:38:12 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: thomas@monjalon.net, ferruh.yigit@amd.com, bruce.richardson@intel.com, stephen@networkplumber.org, mb@smartsharesystems.com, Tyler Retzlaff , Konstantin Ananyev Subject: [PATCH v5 07/13] bpf: remove log level in internal helper Date: Wed, 20 Dec 2023 16:36:00 +0100 Message-ID: <20231220153607.718606-8-david.marchand@redhat.com> In-Reply-To: <20231220153607.718606-1-david.marchand@redhat.com> References: <20231117131824.1977792-1-david.marchand@redhat.com> <20231220153607.718606-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org There is no other log level than debug, simplify this helper. Signed-off-by: David Marchand Acked-by: Stephen Hemminger Acked-by: Tyler Retzlaff --- lib/bpf/bpf_validate.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/bpf/bpf_validate.c b/lib/bpf/bpf_validate.c index 95b9ef99ef..f246b3c5eb 100644 --- a/lib/bpf/bpf_validate.c +++ b/lib/bpf/bpf_validate.c @@ -2178,18 +2178,18 @@ restore_eval_state(struct bpf_verifier *bvf, struct inst_node *node) } static void -log_eval_state(const struct bpf_verifier *bvf, const struct ebpf_insn *ins, - uint32_t pc, int32_t loglvl) +log_dbg_eval_state(const struct bpf_verifier *bvf, const struct ebpf_insn *ins, + uint32_t pc) { const struct bpf_eval_state *st; const struct bpf_reg_val *rv; - rte_log(loglvl, rte_bpf_logtype, "%s(pc=%u):\n", __func__, pc); + RTE_BPF_LOG(DEBUG, "%s(pc=%u):\n", __func__, pc); st = bvf->evst; rv = st->rv + ins->dst_reg; - rte_log(loglvl, rte_bpf_logtype, + RTE_BPF_LOG(DEBUG, "r%u={\n" "\tv={type=%u, size=%zu},\n" "\tmask=0x%" PRIx64 ",\n" @@ -2269,7 +2269,7 @@ evaluate(struct bpf_verifier *bvf) } } - log_eval_state(bvf, ins + idx, idx, RTE_LOG_DEBUG); + log_dbg_eval_state(bvf, ins + idx, idx); bvf->evin = NULL; }