From patchwork Thu Dec 21 18:05:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 135483 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B65DD43752; Thu, 21 Dec 2023 19:06:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6F3B042ECB; Thu, 21 Dec 2023 19:05:49 +0100 (CET) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id A25A342E9E for ; Thu, 21 Dec 2023 19:05:46 +0100 (CET) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1d409bcb0e7so4598655ad.1 for ; Thu, 21 Dec 2023 10:05:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1703181945; x=1703786745; darn=dpdk.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=qItoPv3IWmf7wFu+W1FLlIxt5Q9pJT+D2dikIRTJv3A=; b=TuieJ0jwKuB3dgW3p9U7QDY0s2uEWi6zg56PfhikqirwfoAK5xRyafrV+QsRVUz8y6 orKypoSGADHCk/S0EuGyexjQcmJFGlNeQFlxxtAPVL3iI4Jmy6KlXjKKwtPgegjBZxi8 dbXP5L0jdVhbhtwhG7/yFq765D2Pp8uAH1/Ik= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703181945; x=1703786745; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qItoPv3IWmf7wFu+W1FLlIxt5Q9pJT+D2dikIRTJv3A=; b=tOwHZ6dvEFdaWqpfe3OKriYwcUAFlu2lShwrLlntarlkIm9r3JEbs2mEr9/oybpsrE tyxCn+wsBBNEl1zftnAdA6dqSax+MYlW/liw8XJrv99fVhqvBQf9ARXO8HOlHuxmfxfI Ckj8vAXrR8KLnKftlXAWTSPVajlo3rHMzLY7mWE3vscxRsD/CYmhgFbPWiC+updWFkSO qi3/sc3vUVCXRrcGhNVMt2vWLlwuRGXjPnkXoxFfIUBBAYUCqnfCLx17McPLvmO8q/DF ZIcdypyAS5tgj3WBwtcZ5sidGkczBz4s3iRuD56EI4TPgvhpBeHjb8pudkvPs+Di49FP ugGg== X-Gm-Message-State: AOJu0YwEQ44gWL6o0NH7Zkcgp6MQOHmD+5NNv/Fq5euGjgSeBN0pnrsY mjumUl+FGh86ELy4wqrMCB6h1hK/tZ+aJUMn3LN9NkD0ApoIShGn67jU4V0layLXIOTlCWI4VaE AkyLS/Yq+qosH+y7nbP8+Y6rvJ7ejllojBpyHG4M52TthyKhaDikzOJfGUW9iqxH8FL3YRRygi8 8= X-Google-Smtp-Source: AGHT+IE/FuISNvYwruVJpBmZGr9ypZOQf7A5kqXMtW7GG6t3yNN2tay0gywaSD3Anwp0mjDVNv+bbQ== X-Received: by 2002:a17:903:52:b0:1d3:3e65:21e4 with SMTP id l18-20020a170903005200b001d33e6521e4mr19257pla.11.1703181945471; Thu, 21 Dec 2023 10:05:45 -0800 (PST) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id j17-20020a170902da9100b001d3b3ac2d7bsm1916379plx.245.2023.12.21.10.05.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 10:05:44 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: Damodharam Ammepalli Subject: [PATCH 08/18] net/bnxt: refactor Rx doorbell during Rx flush Date: Thu, 21 Dec 2023 10:05:19 -0800 Message-Id: <20231221180529.18687-9-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20231221180529.18687-1-ajit.khaparde@broadcom.com> References: <20231221180529.18687-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Ring the Rx doorbell during the Rx ring flush processing only if there is a valid completion. Signed-off-by: Ajit Khaparde Reviewed-by: Damodharam Ammepalli --- drivers/net/bnxt/bnxt_rxr.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c index c5c9f9e6e6..d0706874a6 100644 --- a/drivers/net/bnxt/bnxt_rxr.c +++ b/drivers/net/bnxt/bnxt_rxr.c @@ -1713,10 +1713,11 @@ int bnxt_flush_rx_cmp(struct bnxt_cp_ring_info *cpr) nb_rx++; } while (nb_rx < ring_mask); - cpr->cp_raw_cons = raw_cons; - - /* Ring the completion queue doorbell. */ - bnxt_db_cq(cpr); + if (nb_rx) { + cpr->cp_raw_cons = raw_cons; + /* Ring the completion queue doorbell. */ + bnxt_db_cq(cpr); + } return 0; }