From patchwork Fri Dec 22 21:56:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 135536 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68D8843762; Fri, 22 Dec 2023 22:57:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 96EED42E5A; Fri, 22 Dec 2023 22:57:17 +0100 (CET) Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) by mails.dpdk.org (Postfix) with ESMTP id 043BF406FF for ; Fri, 22 Dec 2023 22:57:14 +0100 (CET) Received: by mail-io1-f48.google.com with SMTP id ca18e2360f4ac-7b7fdde8b56so116032739f.1 for ; Fri, 22 Dec 2023 13:57:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1703282233; x=1703887033; darn=dpdk.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=FWL2IieDcBbX9Dbv+RtgbBV009gODqZ5EKXPIcG6w+w=; b=cwzDDfhJLbQNEdVk6Z5AykUctnV0budvkaDlwB6KW9IYqhSUkrbh1FwBdGUFsM3HdB uSorbrCpBAqHm0YVRPx4+FpILaSgQxL5bLsipkpHgHE5/5cOZwH5OWyyclcHo2ulNa/1 eQsIUD05nWd978eymAGcHfc9G3aQPPJDd0W9Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703282233; x=1703887033; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FWL2IieDcBbX9Dbv+RtgbBV009gODqZ5EKXPIcG6w+w=; b=NYDaQoaw15HiSwM0WSuvnCuzpflIZ76sjIs4ftxQoHDTw6yTMTvemmPq5nPp8NpRgC SGV4pw0F/rHiPCan8p/wBlRr/i7bF/NBVh0cfR6cYL++YTUqpaK1oqlwk+1ZIID8DOXm 335jM5G28f0KfQ6ySNPfttk6GLYVTprDL/K4Sgsw73Tzpizrj6c3wOVYKV2qi2Ku2740 B366RDFidedJDgsx2sEh+zyUCSfmaAzyMSH9jQilLh/vx1Mnyk1cmCqjPZR3Yrmrkswq wsztqjH1oNJ9YJdtwArXysYRWRtkHUqBYl8BWN0GW2CParhF0Az9nTHo2KjHXdyKjNgr RrRg== X-Gm-Message-State: AOJu0YxMe724gLBbdnIlH8/DCXE8NUEqvebV17uAQXp+L3tGJ/IzNdYO tFMjsZ1wNoGNaOwri6Sv5HAh9p7N+SNibEdOfDFy8Ah4uOn7DoLVIZ7cWGB11UAzQ6J+4zXjHcv QZUHyVHA+1M5rSgurUzA1+u8AAN1ff/9CpQG70nXz2tz0hx57pbWRD11IZVQPe2E7ZQfr6TDScj I= X-Google-Smtp-Source: AGHT+IFIX3OnoZW2CM6n8cTwGkQW1pEoTCcCGeUD5kZV5h7+NURtWM9cni2NCzhpIEdebRBZjoGXwA== X-Received: by 2002:a05:6e02:3306:b0:35f:cdbc:46e9 with SMTP id bm6-20020a056e02330600b0035fcdbc46e9mr3117558ilb.40.1703282232970; Fri, 22 Dec 2023 13:57:12 -0800 (PST) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id sr5-20020a17090b4e8500b0028afd8b1e0bsm3540700pjb.57.2023.12.22.13.57.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Dec 2023 13:57:12 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: Kalesh AP , stable@dpdk.org Subject: [PATCH v2 06/18] net/bnxt: support backward compatibility Date: Fri, 22 Dec 2023 13:56:47 -0800 Message-Id: <20231222215659.64993-7-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20231222215659.64993-1-ajit.khaparde@broadcom.com> References: <20231222215659.64993-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Kalesh AP On older firmware versions, HWRM_FUNC_QCAPS response is not returning the maximum number of multicast filters that can be supported by the function. As a result, memory allocation with size 0 fails. Bugzilla ID: 1309 Cc: stable@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h | 1 + drivers/net/bnxt/bnxt_hwrm.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h index cfdbfd3f54..cd85a944e8 100644 --- a/drivers/net/bnxt/bnxt.h +++ b/drivers/net/bnxt/bnxt.h @@ -974,6 +974,7 @@ struct bnxt { struct rte_ether_addr *mcast_addr_list; rte_iova_t mc_list_dma_addr; uint32_t nb_mc_addr; +#define BNXT_DFLT_MAX_MC_ADDR 16 /* for compatibility with older firmware */ uint32_t max_mcast_addr; /* maximum number of mcast filters supported */ struct rte_eth_rss_conf rss_conf; /* RSS configuration. */ diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index a1f3a8251f..d649f217ec 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -901,6 +901,8 @@ static int __bnxt_hwrm_func_qcaps(struct bnxt *bp) bp->max_l2_ctx, bp->max_vnics); bp->max_stat_ctx = rte_le_to_cpu_16(resp->max_stat_ctx); bp->max_mcast_addr = rte_le_to_cpu_32(resp->max_mcast_filters); + if (!bp->max_mcast_addr) + bp->max_mcast_addr = BNXT_DFLT_MAX_MC_ADDR; memcpy(bp->dsn, resp->device_serial_number, sizeof(bp->dsn)); if (BNXT_PF(bp))