From patchwork Fri Dec 22 21:56:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 135538 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B8D343762; Fri, 22 Dec 2023 22:58:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 57C3F42E7C; Fri, 22 Dec 2023 22:57:20 +0100 (CET) Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by mails.dpdk.org (Postfix) with ESMTP id CC927410DD for ; Fri, 22 Dec 2023 22:57:16 +0100 (CET) Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-6d774533e73so2211862b3a.1 for ; Fri, 22 Dec 2023 13:57:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1703282236; x=1703887036; darn=dpdk.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=6KSdbLQ2MfXJ3i/rHVSXMozHZ6Hq4mZ1ttDi1RfbRPA=; b=GgPbDv1t0C+iD90gw/zZEga4pRdqz69k0ozA5ov6EKhAyn7w4zcZI0apxWaxIniQ9X wRSotTC+659thid5ji8TLyysV2RhPa1lWlcfvIlWP0/9TOBWLC4086WmWBASubZD6R6C X44nMn3kQYbtPvh4aSVADdon633QkZcgsp6jc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703282236; x=1703887036; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6KSdbLQ2MfXJ3i/rHVSXMozHZ6Hq4mZ1ttDi1RfbRPA=; b=rHkO1w4ehYrVI3rFvboOUjYutzqD+1YVEvnLIRjky9P2/6VP9iNijsbufxa2K+IPC7 DHKXSn1tZ5T/b+i58lKtBh0yxf8JBDd+SUKKgjhVY+IeYPJukoZekJR3QF8zjaxAqMXN z+C9WNuzMquhboQ0W2oFbGrXFURzswFU63KuYoBBnIaP0jq3P1ZYkLBzVNi4u/dfNT9b cunSXGwYcnsSA6CcwM8ryUCDIIEGgrPSf59JISdW2t0sP28PgkZBYEoVDNeqQUwNoV/Q ne6a+CjohbJDNR5zL1DUWJN3DbzMMF9G2eqRmbuVOXlBF931mx8cKREj7n5GDZaGNNHI Hsug== X-Gm-Message-State: AOJu0YyUGGXgFAe22arHfPv5/QyuQERRN/cqxsaTWbRQASiVL1JrWy/K hdO2oyYibuct5FhUPQ+YhCcGnP9aZTIyiqq7hmctljYP9LseZqaPwncY1s0HlhpPOsOy/JPjkz/ CexeWxSOYKHi3aAH3nS2/+X2JOdFeQ/bLpw/pRj917Xl10I22OYw3n5Epp9Tjt+viQ+Oa8yFevo M= X-Google-Smtp-Source: AGHT+IHj5kUHYN2Mi3yAmQD+2bQr4r4WqM8V8+Wq7vtIKiaNVig4qkfEhrL3bGfjxiDoD/wdpn78mA== X-Received: by 2002:a05:6a20:e109:b0:195:5156:9ea7 with SMTP id kr9-20020a056a20e10900b0019551569ea7mr1030290pzb.18.1703282235713; Fri, 22 Dec 2023 13:57:15 -0800 (PST) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id sr5-20020a17090b4e8500b0028afd8b1e0bsm3540700pjb.57.2023.12.22.13.57.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Dec 2023 13:57:14 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: Damodharam Ammepalli Subject: [PATCH v2 08/18] net/bnxt: refactor Rx doorbell during Rx flush Date: Fri, 22 Dec 2023 13:56:49 -0800 Message-Id: <20231222215659.64993-9-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20231222215659.64993-1-ajit.khaparde@broadcom.com> References: <20231222215659.64993-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Ring the Rx doorbell during the Rx ring flush processing only if there is a valid completion. Signed-off-by: Ajit Khaparde Reviewed-by: Damodharam Ammepalli --- drivers/net/bnxt/bnxt_rxr.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c index c5c9f9e6e6..d0706874a6 100644 --- a/drivers/net/bnxt/bnxt_rxr.c +++ b/drivers/net/bnxt/bnxt_rxr.c @@ -1713,10 +1713,11 @@ int bnxt_flush_rx_cmp(struct bnxt_cp_ring_info *cpr) nb_rx++; } while (nb_rx < ring_mask); - cpr->cp_raw_cons = raw_cons; - - /* Ring the completion queue doorbell. */ - bnxt_db_cq(cpr); + if (nb_rx) { + cpr->cp_raw_cons = raw_cons; + /* Ring the completion queue doorbell. */ + bnxt_db_cq(cpr); + } return 0; }