From patchwork Wed Dec 27 04:21:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 135596 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6067437A1; Wed, 27 Dec 2023 05:22:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 14AD64067A; Wed, 27 Dec 2023 05:21:43 +0100 (CET) Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by mails.dpdk.org (Postfix) with ESMTP id 6EEC04068A for ; Wed, 27 Dec 2023 05:21:37 +0100 (CET) Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-427cff62e19so22648041cf.2 for ; Tue, 26 Dec 2023 20:21:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1703650896; x=1704255696; darn=dpdk.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=TrBkhvd7MSGpB2ErSqB86YPgkxyK1I1Mjy3SIkQOJSk=; b=b7+dnXAQ5c5EDcEkKvPxCph4VqfQp2lyjsN0qWeme9rKuxGp4cgvyJn50nns5UdCNy tV3K37/9kzn1SUAEpDg5izLJdZgBl+/Or6OSspOIiAAfmFSouA23+IUTJ1JpzPYWYoyk DDCPfs3nj5DNrlRT+tzATKwNlKIzHWpQvkunA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703650896; x=1704255696; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TrBkhvd7MSGpB2ErSqB86YPgkxyK1I1Mjy3SIkQOJSk=; b=vOpIFF9xdGKYNYtPwjKcUptGtigJF4RHYHjSlA1PXIze8N6W3R070pRj9m/vRkHuwF EIUB7wZdxqJA6k5iXxNGV1NCuH315Yna0KfVvZ7jRIJZvX5Y3LucA0KIEMVM3jx+otbD 07bz4t0H476x8tQqBm4X6fjO2J7juYLWWiMGD+D+LJbFDja7DA7Skz8Co77L4jpVuSR5 bWbN7jRv8Sp6gQhQEgjz3jqt/kdgWZIXuWakxShd9MwIeICLna2om4DmxrKZwB8lcdwK wFVfmIvOv5QziRFv1xaXHMoHp8vhVoPVzu9ooZQAJfxK4EuZlsppHDUs9KayXzebDLGy Qotg== X-Gm-Message-State: AOJu0Yy4Y58bc9W8yBgGaIvnKz7XSDiLqSQN7tnpSzhdZ/TmIDcrQ3Sq 9zVVrnwSSBLsvw3/FO9VUSCJTYfwXhUS5/HqwQftruaxukQ6+6da8WAClbOJW8+fEw0mJwMV+nc eDdyOv3YpYNTpn2cKevqnQUqFE1RPDwXY6LMnl9Rb3WzLIkAY4f2BDzWkSJtd2NSNrcDEBnKRLt 8= X-Google-Smtp-Source: AGHT+IE4+qurfQsGpE/x4bAWc0eHVLL4mYGpayT1rjN08xOg7v9uob+IKKxtjmWIYCwFfJaytWBYtQ== X-Received: by 2002:ac8:5956:0:b0:427:a2d0:cf52 with SMTP id 22-20020ac85956000000b00427a2d0cf52mr15015654qtz.88.1703650896346; Tue, 26 Dec 2023 20:21:36 -0800 (PST) Received: from localhost.localdomain ([2605:a601:a780:1400:c066:75e3:74c8:50e6]) by smtp.gmail.com with ESMTPSA id bt7-20020ac86907000000b00427e120889bsm1415488qtb.91.2023.12.26.20.21.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Dec 2023 20:21:35 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: Damodharam Ammepalli Subject: [PATCH v3 08/18] net/bnxt: refactor Rx doorbell during Rx flush Date: Tue, 26 Dec 2023 20:21:09 -0800 Message-Id: <20231227042119.72469-9-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20231227042119.72469-1-ajit.khaparde@broadcom.com> References: <20231227042119.72469-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Ring the Rx doorbell during the Rx ring flush processing only if there is a valid completion. Signed-off-by: Ajit Khaparde Reviewed-by: Damodharam Ammepalli --- drivers/net/bnxt/bnxt_rxr.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c index c5c9f9e6e6..d0706874a6 100644 --- a/drivers/net/bnxt/bnxt_rxr.c +++ b/drivers/net/bnxt/bnxt_rxr.c @@ -1713,10 +1713,11 @@ int bnxt_flush_rx_cmp(struct bnxt_cp_ring_info *cpr) nb_rx++; } while (nb_rx < ring_mask); - cpr->cp_raw_cons = raw_cons; - - /* Ring the completion queue doorbell. */ - bnxt_db_cq(cpr); + if (nb_rx) { + cpr->cp_raw_cons = raw_cons; + /* Ring the completion queue doorbell. */ + bnxt_db_cq(cpr); + } return 0; }