From patchwork Tue Jan 2 19:42:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qi Zhang X-Patchwork-Id: 135680 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7EBD6437FC; Tue, 2 Jan 2024 12:21:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5FCBD4067B; Tue, 2 Jan 2024 12:21:34 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mails.dpdk.org (Postfix) with ESMTP id 70CAC402CE for ; Tue, 2 Jan 2024 12:21:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704194492; x=1735730492; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mcI0opuWOtcYtonIBT4oiCJ61hj46G6G3aJbL8YjyB8=; b=K5ZtqvZQm5c8tATSlW13HLbY5G0ScADC6JYLLkNRGnl7L+2Ofbw1bw+Y OJOrW0sizbOcjLQQ+Kk+g8kLjFtudpuNJ7gxe9qJhnsLYMjvOPaFyKXm6 biF8ig0OXJtX2mFWorkXORHSl3gT1rsrvYWQ9c+mFYaOPe/AM2A5uAwt6 uf+7awJSKEcKPwsUimoJAZj/N93a45PoDbG/iCx02uf3JXuTmmHH823px kg+NXIFsooufbR3bYcDIOsn8tR3GH2yN+GoKRL21dclk3ipUK85WTtVum i+fmQu5S9ZeNOHQ59U80BuSaZWOcxEdY+5WrnFveAlsRrQfPZEjuCLN9A w==; X-IronPort-AV: E=McAfee;i="6600,9927,10940"; a="10256780" X-IronPort-AV: E=Sophos;i="6.04,324,1695711600"; d="scan'208";a="10256780" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2024 03:21:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10940"; a="952895234" X-IronPort-AV: E=Sophos;i="6.04,324,1695711600"; d="scan'208";a="952895234" Received: from dpdk-qzhan15-test02.sh.intel.com ([10.67.115.37]) by orsmga005.jf.intel.com with ESMTP; 02 Jan 2024 03:21:30 -0800 From: Qi Zhang To: qiming.yang@intel.com, wenjun1.wu@intel.com Cc: dev@dpdk.org, Qi Zhang Subject: [PATCH 1/6] net/ice: remove redundent code Date: Tue, 2 Jan 2024 14:42:27 -0500 Message-Id: <20240102194232.3614305-2-qi.z.zhang@intel.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20240102194232.3614305-1-qi.z.zhang@intel.com> References: <20240102194232.3614305-1-qi.z.zhang@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The committed flag for tx schedular configuration is not used in PF only mode, remove the redundent code. Signed-off-by: Qi Zhang --- drivers/net/ice/ice_tm.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_tm.c index f5ea47ae83..9e2f981fa3 100644 --- a/drivers/net/ice/ice_tm.c +++ b/drivers/net/ice/ice_tm.c @@ -390,13 +390,6 @@ ice_tm_node_add(struct rte_eth_dev *dev, uint32_t node_id, if (!params || !error) return -EINVAL; - /* if already committed */ - if (pf->tm_conf.committed) { - error->type = RTE_TM_ERROR_TYPE_UNSPECIFIED; - error->message = "already committed"; - return -EINVAL; - } - ret = ice_node_param_check(pf, node_id, priority, weight, params, error); if (ret) @@ -579,13 +572,6 @@ ice_tm_node_delete(struct rte_eth_dev *dev, uint32_t node_id, if (!error) return -EINVAL; - /* if already committed */ - if (pf->tm_conf.committed) { - error->type = RTE_TM_ERROR_TYPE_UNSPECIFIED; - error->message = "already committed"; - return -EINVAL; - } - if (node_id == RTE_TM_NODE_ID_NULL) { error->type = RTE_TM_ERROR_TYPE_NODE_ID; error->message = "invalid node id";