From patchwork Mon Jan 15 12:09:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Baum X-Patchwork-Id: 135877 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6D06438CE; Mon, 15 Jan 2024 13:10:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E5CFE40649; Mon, 15 Jan 2024 13:10:29 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2077.outbound.protection.outlook.com [40.107.93.77]) by mails.dpdk.org (Postfix) with ESMTP id 37994402C0; Mon, 15 Jan 2024 13:10:28 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MpvAqfOJx9StFimzsqmK05OnP7GTKXjjgYSXbZv85gySlGiqvMzgPSZdUQ6sZJbSnGJBKjkRt/UUxIzsG9VL9KRbFjm/oT0mSgdUNYm9xEmveZmE0ALR72i/SbnLIFy6pT6fqMX49utOKiHVRAJqA75DvmzGseMW6MZ+aO4ad83hk+PT1XwwY09/ox+nVG9NXX+GtGNTkq8ZaT/X30nF3fanTuDbg8mqZmwtwKA9MsXgf0iMpwIsnpxt/XOdvwc2zdNK8OpG4sI0xReRftmzWd018HkYLXvTt5FpSGh3VzEEfneKNmgzoFO3oD/rVwjODBJ/r9Hi6LzX4fsb/Wbm8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qobdyhUy0KBRE2ILt1/omJXgi0lQhtXCKkDBUeNbzec=; b=Ox5wYG89ke3J4V9RwjZhMl5f8OZQv1gIjcs/aiHd3fmmZ+1tIKtY0pJWlgOAvoGEjxTW6kfgBMCFekbnvZbVYk4E9SQblH08xVwuFSx8MPPuG0GFUDnhgwiCv62j8PriIcLjYPfyYbpVPr6Rq7GUweRQBV+MZiX84q08z940cHjAD8BMbav6VsTR18wnCtM4wUVuKibj/VH3+XL+3i/xZ5tOMp4SQfRzhD9SFLTnCqLXR9a2wfxCWpWtLkFdesll9XRQNlHUnN9YECL4hqAd2bo+8tXKaAdJ9yNVS40zTdpOmtDznS/KFoiuXgIcDFFG1udNj/5Ick3qrroUQU98gw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qobdyhUy0KBRE2ILt1/omJXgi0lQhtXCKkDBUeNbzec=; b=fuj6PpeP7hNXl4di5o+M+TLYCD39JuAV+SjNe+9bYvuurY45bdoQT2Og2I+bmUcPnBpH0Q/JT/56b3Znf6T5PnO/8nlWVlL03P9xCEvAx5lbaxZqRnS6dqvJadtqVqGmOnjISWcIIXrQUgfwkyb5JRg76g2ShPE70qRneBWH0A6VUmYiA0eP0v9p5AEx+ROtkVHaglx7yzw19b+z2NlFHIsGKNzlpSQ3twzi8d17xArN/ax8gU5KtvoLBUNGtE2RHXDYO5Wg4I0z+DgXNH8Nv42BBZefm9VUt/aZf8MlZhyzXMJ/4sj5bZk5RzQNaAx98mYHIeOjOao/o612MZt5/g== Received: from BLAPR03CA0108.namprd03.prod.outlook.com (2603:10b6:208:32a::23) by PH8PR12MB6721.namprd12.prod.outlook.com (2603:10b6:510:1cc::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23; Mon, 15 Jan 2024 12:10:25 +0000 Received: from BL6PEPF0001AB52.namprd02.prod.outlook.com (2603:10b6:208:32a:cafe::c) by BLAPR03CA0108.outlook.office365.com (2603:10b6:208:32a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.23 via Frontend Transport; Mon, 15 Jan 2024 12:10:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by BL6PEPF0001AB52.mail.protection.outlook.com (10.167.241.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.14 via Frontend Transport; Mon, 15 Jan 2024 12:10:25 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 15 Jan 2024 04:10:11 -0800 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 15 Jan 2024 04:10:11 -0800 Received: from nvidia.com (10.127.8.13) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41 via Frontend Transport; Mon, 15 Jan 2024 04:10:09 -0800 From: Michael Baum To: CC: Matan Azrad , Dariusz Sosnowski , Raslan Darawsheh , Viacheslav Ovsiienko , Ori Kam , Suanming Mou , , Subject: [PATCH] net/mlx5/hws: fix ESP matching validation Date: Mon, 15 Jan 2024 14:09:39 +0200 Message-ID: <20240115120938.3994588-1-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB52:EE_|PH8PR12MB6721:EE_ X-MS-Office365-Filtering-Correlation-Id: 945cdc64-abfe-49d6-469b-08dc15c2f4a4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zhU1D8k/4eSUOM9v0Dn8LbMoLsor/JjSY/8GJ1Dc/MVT5akbSIf0+OUxH/DqCfnTyGWwoCv2iXPfWFcCNgwNMZRM/m8hOKw2th9sJ3B6IC7JY2MHtnTpji6EVtuRoJ9PTBF5RWfYphgcMzsjSezVW4tqQQB3ErcBERCt7ZeT6Z5cq6EaOle7K/8eTu626TH1I4NnHRs46S2S5h9XJQSwhqkR6vpeDGLZoRDUZ1Lba7NhsvcbLr3zAEq3vB0L+lnWwiAfWu9s+DJmTrqMKrunNTsoh5+uwugTHN5dNUXp0547Q7gdAX8+L0i5EFX3OyfiPfKJJNCBHkllmaRd9/I9W3iQ3mzp92XNvSfFxgXO98omEmlhd8jvDQaIwvFoRxX99DjCDKrSgwvcfaDepy7cMI6W4Pe+eGP96tRrEKeIwRX8WMy+NrmIUm1NOhyOkXkAH6jvKagDgRfShaVruB6RgwlUvjvKjfutOsAmgFtZ7BtgeVmHYq8t97+NgNBZDquM+kMCcaN+dNlSL6NyoF6qHHwUuWFpuXV7FQWYZ7l8QC/Y3LBJ2xU6tluXkE725grPbufwefzB2JDQSu+vmQ7UuhUAXr85YZN7ZMCsEyuGTWaYkB0hTaRr6+p+sOVK9V/8ApmE8iZxeI7CCVURkYx8Qxcn2OUYrRos4LP/R+pzvsB9CBnM13xzQ3ikgGkv+QqUf/iWbLYDtNp4PASyvA1cPE4oKz3W+wa1xpo0Mh43jT804yqU5eULt0ajG37N902v X-Forefront-Antispam-Report: CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(346002)(39860400002)(376002)(396003)(136003)(230922051799003)(451199024)(1800799012)(186009)(82310400011)(64100799003)(46966006)(36840700001)(40470700004)(40480700001)(40460700003)(55016003)(83380400001)(6916009)(7636003)(70586007)(86362001)(70206006)(54906003)(356005)(36756003)(41300700001)(36860700001)(1076003)(336012)(2616005)(316002)(6666004)(5660300002)(26005)(2906002)(426003)(47076005)(478600001)(82740400003)(6286002)(4326008)(8676002)(450100002)(7696005)(8936002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2024 12:10:25.0294 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 945cdc64-abfe-49d6-469b-08dc15c2f4a4 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB52.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6721 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The "mlx5dr_definer_conv_item_esp()" function validates first whether "ipsec_offload" PRM flag is on, if the flag is off the function returns error. The "ipsec_offload" PRM flag indicates whether IPsec encrypt/decrypt is supported, IPsec matching may be supported even when this flag is off. This patch removes this validation. Fixes: 81cf20a25abf ("net/mlx5/hws: support match on ESP item") Cc: hamdani@nvidia.com Cc: stable@dpdk.org Signed-off-by: Michael Baum Acked-by: Hamdan Igbaria Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_definer.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c b/drivers/net/mlx5/hws/mlx5dr_definer.c index 0b60479406..7bd4ea560e 100644 --- a/drivers/net/mlx5/hws/mlx5dr_definer.c +++ b/drivers/net/mlx5/hws/mlx5dr_definer.c @@ -2240,11 +2240,6 @@ mlx5dr_definer_conv_item_esp(struct mlx5dr_definer_conv_data *cd, const struct rte_flow_item_esp *m = item->mask; struct mlx5dr_definer_fc *fc; - if (!cd->ctx->caps->ipsec_offload) { - rte_errno = ENOTSUP; - return rte_errno; - } - if (!m) return 0; if (m->hdr.spi) {