From patchwork Thu Jan 25 13:30:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Baum X-Patchwork-Id: 136152 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB9A7439C1; Thu, 25 Jan 2024 14:32:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5C52A42E4D; Thu, 25 Jan 2024 14:31:26 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2085.outbound.protection.outlook.com [40.107.94.85]) by mails.dpdk.org (Postfix) with ESMTP id 000E142E47 for ; Thu, 25 Jan 2024 14:31:24 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YSllBNxudHA8OY3XPiqZF6JXcMY5lB8grQ1FL0wLJF1bXLgCuTm3hQ06GHSPohNwamzGhCkF9udldQjn/tkH6uDWawzWkm5rBlJYtGLfs0sOzDuR+2rpN02+eWn4tBmc8MEQJ5HKLkSfOVrztxlYnSli8PRTmU0MR6qC3uZXu1pqCf2y6Z8r/9QHcSxa32XiVBeXsQcUDrJSTAQweCl93q/cFQXgo/PDvf6+EnpLfG/lYm1yQkluuh0ZOou96XhaW5Oyec+FdM6Rjfe4Tjsfvek/5kBReNSVnon8EkCcU9fbAQHbIKf626z0V4dGitFcwc20bnXgH1VGOGzjqFQQdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fSgkA4wEYGwCQscy51eOlOAyitmSS3OYNEdwNSW8Zz4=; b=bhRnjV4nMyyUcMv1H5sAEKPZhHF+WkB/+IRZ7oxg+35d6xNcvoHWoBAQvj6UuymVGjLJqqbzgjKYlNpjOIozqzhCdyVvNWBBe2+UqOwzf1qh7xy16y3j66spjzglrt3ya3ILHpWLmG1ZfHZ6RfC10D8z2XxvM3PiJFcqad8KuDJ0Z/BShJGzM+pQu2lCI+xzJRjrMuqy33FbxblHWjtNJZCY73pGccpjheh+LbSrgCMa/HG3lRxo+aBUAjMo+zzYG6CYgs9Zjw/b1C3/DgqX9tzggkZVKJ8manNHVpK0g1ENgWO5H08OgwSSpcYjHd1/ogNc4mCP9+BlZRzAdhwfrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fSgkA4wEYGwCQscy51eOlOAyitmSS3OYNEdwNSW8Zz4=; b=HzaC5r8lxqOgdNrXMNFk/PMzlWN6CJ+C1V7asQ06W/rzlcxUWmEi1sC9c2VvQBwI8CJww5ytsDkoxglfE3IZiPRVFGHk9lOahKlFSFaL49XS/ZMa+/N+gvVLoijavRpa0tlAx8Lnyj1SWbzFbxSVAfFBvsqBJNsida15J23sCFhdvMT0295Ko+Ofhv/NvFaC8iQEQD4M3BruX+MkKRPv+9kszLQ/aI7q36w6es9kmUnksBInn5D8oL7Z1vmM5vKb37j/maPPPQoTlNZYq13MQJVQdqE0iFk8m51FVDF70lUt1edxdejzKvbYyS6iWFYABv21TLIAPbIvbohcZ3Pu5w== Received: from DM5PR07CA0063.namprd07.prod.outlook.com (2603:10b6:4:ad::28) by MW4PR12MB6681.namprd12.prod.outlook.com (2603:10b6:303:1e1::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.26; Thu, 25 Jan 2024 13:31:22 +0000 Received: from CY4PEPF0000EDD2.namprd03.prod.outlook.com (2603:10b6:4:ad:cafe::7f) by DM5PR07CA0063.outlook.office365.com (2603:10b6:4:ad::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.26 via Frontend Transport; Thu, 25 Jan 2024 13:31:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by CY4PEPF0000EDD2.mail.protection.outlook.com (10.167.241.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.16 via Frontend Transport; Thu, 25 Jan 2024 13:31:22 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 25 Jan 2024 05:31:13 -0800 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 25 Jan 2024 05:31:12 -0800 Received: from nvidia.com (10.127.8.13) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41 via Frontend Transport; Thu, 25 Jan 2024 05:31:10 -0800 From: Michael Baum To: CC: Matan Azrad , Raslan Darawsheh , Dariusz Sosnowski , Viacheslav Ovsiienko , Ori Kam , Suanming Mou Subject: [PATCH v2 09/23] common/mlx5: add sample info query syndrome into error log Date: Thu, 25 Jan 2024 15:30:29 +0200 Message-ID: <20240125133043.575860-10-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240125133043.575860-1-michaelba@nvidia.com> References: <20231203112543.844014-1-michaelba@nvidia.com> <20240125133043.575860-1-michaelba@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EDD2:EE_|MW4PR12MB6681:EE_ X-MS-Office365-Filtering-Correlation-Id: 72608271-c398-4b69-985e-08dc1da9ebbd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7ycLU4AlXKm1YMT7D2YAgBm6MGiIdJSe+dIh9bt2Q4rt3xgVyM4j7LhG4YeFWj2B9wysHPpa1NynvxU/jOlnTpOCeZhmm9TA5zI5Hv67KdZw4XqgKQkMvDg0BK+zSDuRSUX634ldiTAngLYZhesTm+hU+1CiqVlZW11UudokLJCRN042syFyBVNUZWxKp50neHFH9IwJM7prmLHup8Ctnj8lMrcmQJNTABc415uLtnnT6kXZxcmGltqDascub0Ya2fM2V/6eTE6ZnTHGx8D0GcAPF654kes/hQaoPvHeacWm/k2zK0HUX6nhrcTMnQvTgZfCHLrx0IJ41zqHHjqj9V4VDn1ArQFZEvfMeIbqiyc3oWVK5L07HVU3Zs0QH72b+HNmqPWuMZNtnTeJVwongoLN+giaH8mZzNhr7ez1Ho/6R0jCBAhR0CM7PlZcE/MOs1345pnwNczZjMytWKQm6F0s7N0VIxKxqctE0uRTZjQbFB/TeGcVVizzFsgrb6YKvuostw4pPdweJv/VpENzuYo0AHZWudPSbzwhBw6cSzhj51fFCOqlTVY1Tqua8UyqzHnHt1bd+NBcRiFw98IxBdk1D+XEgTEyGRWgqWZJOoHUzNb5nyItWpRGcqSF0LJJw5d0ShlBWRVWbyqGwCGzCmooxzL5gcV3TxT7gdp6ZD4A1gPOg4uBKewUdkUspnScMc6jxC/WFB3vdIZEG28WbgfS9EyuUharefvd199uA/L0ASbpwSPI1HdhTKiu1tf3 X-Forefront-Antispam-Report: CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(136003)(376002)(346002)(396003)(39860400002)(230922051799003)(451199024)(82310400011)(64100799003)(1800799012)(186009)(36840700001)(46966006)(40470700004)(2906002)(5660300002)(82740400003)(36860700001)(356005)(86362001)(7636003)(478600001)(41300700001)(36756003)(426003)(336012)(7696005)(83380400001)(6666004)(2616005)(6286002)(1076003)(107886003)(26005)(47076005)(316002)(6916009)(8676002)(8936002)(4326008)(54906003)(70206006)(70586007)(55016003)(40460700003)(40480700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2024 13:31:22.0579 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 72608271-c398-4b69-985e-08dc1da9ebbd X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EDD2.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6681 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Move "mlx5_devx_cmd_match_sample_info_query()" function to use "DEVX_DRV_LOG" in case of "devx_general_cmd" failure. This macro contains syndrome report and used by all other function calling "devx_general_cmd". Signed-off-by: Michael Baum Acked-by: Suanming Mou --- drivers/common/mlx5/mlx5_devx_cmds.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c index 68137dc535..b8f4a840e7 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.c +++ b/drivers/common/mlx5/mlx5_devx_cmds.c @@ -641,11 +641,10 @@ mlx5_devx_cmd_match_sample_info_query(void *ctx, uint32_t sample_field_id, MLX5_SET(query_match_sample_info_in, in, sample_field_id, sample_field_id); rc = mlx5_glue->devx_general_cmd(ctx, in, sizeof(in), out, sizeof(out)); - if (rc) { - DRV_LOG(ERR, "Failed to query match sample info using DevX: %s", - strerror(rc)); - rte_errno = rc; - return -rc; + if (rc || MLX5_FW_STATUS(out)) { + DEVX_DRV_LOG(ERR, out, "query match sample info", + "sample_field_id", sample_field_id); + return MLX5_DEVX_ERR_RC(rc); } attr->modify_field_id = MLX5_GET(query_match_sample_info_out, out, modify_field_id);