From patchwork Thu Jan 25 13:30:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Baum X-Patchwork-Id: 136148 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 913FD439C1; Thu, 25 Jan 2024 14:31:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3C53C42E36; Thu, 25 Jan 2024 14:31:17 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2066.outbound.protection.outlook.com [40.107.220.66]) by mails.dpdk.org (Postfix) with ESMTP id 6A13642E25 for ; Thu, 25 Jan 2024 14:31:14 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V+f2Vp7zn58ZR+Z835UfeIUZoLPh53IGC+kMWEbzRsSuLYKafST2SjdqrfMF257s0f9DpfBo+U1f36rvn+ZLMjRKBQRXDqRsQOk+99hVEeuvgdu4A/Y+sPPyx6BR12pFcMqB0MYWovd5ziHK1Fkn9RgI/fLd2wUAARNo7+q0CNp2pgbokkXwpLtnI3Mwa6R2vSKKQhv30UbOZO6ASzgyxM4TzjhVJ3R4su1m7RixF9jg2o1bI2bEhxmvtyqilqZXSxfuSaXrAFPlp8xtULMXFntKxFEUCSk/b+z5s8qsfbMuI7LbyRtdyzj7o5CKupKTCd0bOERpFYvnXdmUVPAvYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y8pMj89ZgNpyYnNW6JTpyWkSR6xjyx+vhKDJm4bePAU=; b=k6TPtVRMJBfBbTMxoaRRjWVextfUnR088MTRq0nS+iW5dl8CdS4ZfdTTjGhigDPO/9CEKOGfIn34ygJhzS4dT6jBSpe8so7bxqjh6RpiwPJp9D+WFpYt0b/ZYNfnRVEY1GsgrIRKIRZPPsATNEO2kQCnW7rY/F9Z46E7WQ3m7gC+F/78PZ9SVXMWfaqVcgfSZh3tG3hp51LQQ0XixWuOnkf6aq05p1C9SJfe++2H9OReW7vpPSo4iFvvA1Hc1C8ztbkPyZxPNFJBV/60tWMBSId9t09ZJfIzc/n+nQb4qFG5gKQ1MYkGbOLgSQwNjpaZ7ieXq2N3CaKvClKy1KsCog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y8pMj89ZgNpyYnNW6JTpyWkSR6xjyx+vhKDJm4bePAU=; b=lj7UhDZ4MnFQhAVmA7jGISvNCoAzvhfRu+xsSaKARoiUBguXlazCDnpt1K9t8qRliRsbc1pfTAUInkDYPrQzarX174iCfHGGSCrIVLiRmxmvgjMmhKUVJn3yKZmBiVfi32Y25bz+uO5koyazwPjmrIDqMlwuCqegEIuyK8CXfnrwHifnbL4QCutHtfFW2VjvOZCxcS7A55+tFqrqEedMoeDCGBIa9pq5mFmwWlfSIe4hsjaeSP1gHS1ZUIVeiq+YhI+V3bQHFhXeBn9+jNfR8NyW0jnbdrdum98acfn/dGbqorq4wWCjDF0Dmcaj3eNydaHuRMyZ7hYCTN6w8dxRkA== Received: from DM6PR03CA0069.namprd03.prod.outlook.com (2603:10b6:5:100::46) by DM6PR12MB4332.namprd12.prod.outlook.com (2603:10b6:5:21e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.22; Thu, 25 Jan 2024 13:31:09 +0000 Received: from CY4PEPF0000EE3E.namprd03.prod.outlook.com (2603:10b6:5:100:cafe::1c) by DM6PR03CA0069.outlook.office365.com (2603:10b6:5:100::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.22 via Frontend Transport; Thu, 25 Jan 2024 13:31:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by CY4PEPF0000EE3E.mail.protection.outlook.com (10.167.242.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.16 via Frontend Transport; Thu, 25 Jan 2024 13:31:09 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 25 Jan 2024 05:31:01 -0800 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 25 Jan 2024 05:31:00 -0800 Received: from nvidia.com (10.127.8.13) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41 via Frontend Transport; Thu, 25 Jan 2024 05:30:59 -0800 From: Michael Baum To: CC: Matan Azrad , Raslan Darawsheh , Dariusz Sosnowski , Viacheslav Ovsiienko , Ori Kam , Suanming Mou , Subject: [PATCH v2 04/23] net/mlx5: remove GENEVE options length limitation Date: Thu, 25 Jan 2024 15:30:24 +0200 Message-ID: <20240125133043.575860-5-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240125133043.575860-1-michaelba@nvidia.com> References: <20231203112543.844014-1-michaelba@nvidia.com> <20240125133043.575860-1-michaelba@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE3E:EE_|DM6PR12MB4332:EE_ X-MS-Office365-Filtering-Correlation-Id: 4aeaab7f-f1ba-420a-37e8-08dc1da9e452 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 49Z9U0OrV6gmG0d5u6k4UwIELpjSOgtRwcZADioTTI6QQMoOXLKuKr5syVWCY0MqEwMkXPaCPGlqTDdn6oYjLkjoN0xFkG8X/x3R39DGrd8ov3MchoEEjOvMT/ddMqxoIhYU/37DSVlRldBUED1E2Waw65PGWl5QJ2twe9BhgojsLzX/cFw2cjwKxfNgZfxOP/LTo8cjnOBgkF+xt2ffpTh3LERpDuTw8RR9aEZfIUdlWYY4+DXsxYRGw1WgytC4Fyt2TYs64zHacxUQ4TmDcMab8EPufb0I0vsdd4CmDrh1lSIKQ5XZvIW/xEy6OrgLrtckNVyhT6J4o67RR0yXE5ol1DSzAcJh1iKkXrLfIRG4JhsB3RTNKVQmb3DO9yd6CvRyCBAvEw7Rys1WHO5GtR1XVHRB5l07vbVjZu++enOu0+6MtJVTyIMG4TS7oTnMbi8GzCVflphMt1kvkr9XNIx5Hhaqdpf1nDyEaI/OYyK6Gp3rDOuMezi5c1V53m8Tn+ppP4kcJi8FOQlXRf7b4cOw3DXWPrNMFJA6l3Px0c6DDw9ZakIAW0gEN15wbGlv6irpdHk6+DSn+vslNwd5bMY1j0SNEj+UKKhR/LobXXvgGUjambyrVw9r3/CDb61YRB5m/Hxa0jb+m32lc2YU17GqKmciSpNsCDELT8tmw6kVaCGYW/z4oKab4XgFsM+HRpOL4VRx9+jW0bIByq9e/IrhYDbM3JAw3HoR0vBz27XB/4RA1FbGKAKmARlidBEh X-Forefront-Antispam-Report: CIP:216.228.118.232; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(396003)(39860400002)(346002)(136003)(376002)(230922051799003)(64100799003)(1800799012)(186009)(82310400011)(451199024)(40470700004)(36840700001)(46966006)(6916009)(356005)(47076005)(54906003)(6666004)(316002)(55016003)(82740400003)(40480700001)(40460700003)(36860700001)(7636003)(36756003)(7696005)(336012)(83380400001)(2906002)(426003)(8676002)(8936002)(4326008)(41300700001)(70586007)(70206006)(478600001)(86362001)(5660300002)(26005)(6286002)(107886003)(2616005)(1076003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2024 13:31:09.5946 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4aeaab7f-f1ba-420a-37e8-08dc1da9e452 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.232]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE3E.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4332 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org GENEVE header has field named "opt_len" describing the total length of all GENEVE options in 4-byte granularity. In SW sreering implementation, only single option with single DW data is supported. When matching on GENEVE option data is requested, matching on "opt_len" field is added according to given option length. This behaveior assumes that only packets with single option can be matched, but it is wrong, packet with a few option can be matched but only one of them can match its value. This patch removes the "opt_len" matching unless user ask it explicitly. Fixes: e440d6cf589e ("net/mlx5: add GENEVE TLV option flow translation") Cc: shirik@nvidia.com Signed-off-by: Michael Baum Acked-by: Suanming Mou --- drivers/net/mlx5/mlx5_flow_dv.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 88b5c20758..b091eb9d11 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -10104,7 +10104,6 @@ flow_dv_translate_item_geneve_opt(struct rte_eth_dev *dev, void *key, const struct rte_flow_item_geneve_opt *geneve_opt_m; const struct rte_flow_item_geneve_opt *geneve_opt_v; const struct rte_flow_item_geneve_opt *geneve_opt_vv = item->spec; - void *misc_v = MLX5_ADDR_OF(fte_match_param, key, misc_parameters); void *misc3_v = MLX5_ADDR_OF(fte_match_param, key, misc_parameters_3); rte_be32_t opt_data_key = 0, opt_data_mask = 0; uint32_t *data; @@ -10123,21 +10122,6 @@ flow_dv_translate_item_geneve_opt(struct rte_eth_dev *dev, void *key, return ret; } } - /* - * Set the option length in GENEVE header if not requested. - * The GENEVE TLV option length is expressed by the option length field - * in the GENEVE header. - * If the option length was not requested but the GENEVE TLV option item - * is present we set the option length field implicitly. - */ - if (!MLX5_GET16(fte_match_set_misc, misc_v, geneve_opt_len)) { - if (key_type & MLX5_SET_MATCHER_M) - MLX5_SET(fte_match_set_misc, misc_v, geneve_opt_len, - MLX5_GENEVE_OPTLEN_MASK); - else - MLX5_SET(fte_match_set_misc, misc_v, geneve_opt_len, - geneve_opt_v->option_len + 1); - } /* Set the data. */ if (key_type == MLX5_SET_MATCHER_SW_V) data = geneve_opt_vv->data;