From patchwork Thu Jan 25 13:30:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Baum X-Patchwork-Id: 136150 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 20471439C1; Thu, 25 Jan 2024 14:32:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1016642E44; Thu, 25 Jan 2024 14:31:24 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2056.outbound.protection.outlook.com [40.107.92.56]) by mails.dpdk.org (Postfix) with ESMTP id 5B32642E24 for ; Thu, 25 Jan 2024 14:31:23 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gil6mrBCzi0ub+5dQgVmhBdh69ma2x+n1keUsguIfrbdyWz432prSWbK2DbSd6Hx2W/BbTBJiowzUOeV/juUmX/NDsMz0faUvoYvyeauOZyPSkiWHwQSirBmC1U/8CQAEYdctGblxFSR34F7Y7HtfjU5DaNdyc8TjqiE+PtuIFIf/d68u+YHLx+QZKLxuE478SevQ/IorIVKq0I/sayDKVTRll/CwW0P3m21T/P1dDYBNA/yAsMsNSC5zXRaJRAPxK9+YaD41TMnlgHAHcxepT0oggNAkoF+3YuYLkmrNICV6HFNJn2pFEbHWZaejkrdvfPPmqt+w0FbNNpRTicJag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z+1Zzu8wjbc6rnJY2/k/1bUwgqxmQc6gf80XmlmaU1E=; b=N+V2IUPF/w/0Gbh2jkzyztctwDfRbQqBtq3KLZTAELbUYTdVSdsFMarNM74GaHMvsmTnT/KWhVawSDPlwxuHMyPtd3/e4bdJte24jYCiuA2bFgovTq0jeaxxB6oLjpvSd8MTHJF+EkGvI3Vj2Omxc4yfysMZItlPuQeOwvanKAZWn9CflUO2yRvAu5rIiVyE4EvUIkqlX/NGTV0gNnrJHFGW66V1KVSmnatUEejwCEN5cqDmAkOpJ+8XchhH6zuHPDJPLewpPG3GxJ5hr6/QRf3iqIHQ3ZKkQqik5ikTf0DhGcK01/5DywVMOUvHEp7l+zE6YOmrqUM19qz3/MO6Zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z+1Zzu8wjbc6rnJY2/k/1bUwgqxmQc6gf80XmlmaU1E=; b=U28m7N6gutt48R8fCtsSH/gkttjvUXAVJQTcL7dn59pUyvOjDsqBGJpL8opeHLeAX0wvzsXMS7RP29YII6Y1inF/KkpBC2pnLedEYzS2eTb0RPbrEZlixNofSbr0Y4rCe8J8H+jNUxugn7cWId4rn/eHWbOyF0OVPIRLdWlhDOEHBycu93exe4Z516g1BZlG1rxg6c0dk81Pbm3tji9OwsUHc6La0Qr/JCRqAc9AEr4TcELqWXiIGxB4ltWbzIByCXneSLN+OLD8h48LeHOfajMYAbxauk3GPo+iNR/labFgz8tSZQEaMSocEEmjMlrAKZ/p4SvUC422mAHRNgl0Xg== Received: from CY8PR19CA0025.namprd19.prod.outlook.com (2603:10b6:930:6::22) by CY8PR12MB7100.namprd12.prod.outlook.com (2603:10b6:930:60::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.24; Thu, 25 Jan 2024 13:31:19 +0000 Received: from CY4PEPF0000EE3A.namprd03.prod.outlook.com (2603:10b6:930:6:cafe::6b) by CY8PR19CA0025.outlook.office365.com (2603:10b6:930:6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.25 via Frontend Transport; Thu, 25 Jan 2024 13:31:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by CY4PEPF0000EE3A.mail.protection.outlook.com (10.167.242.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.14 via Frontend Transport; Thu, 25 Jan 2024 13:31:18 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 25 Jan 2024 05:31:08 -0800 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 25 Jan 2024 05:31:07 -0800 Received: from nvidia.com (10.127.8.13) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41 via Frontend Transport; Thu, 25 Jan 2024 05:31:06 -0800 From: Michael Baum To: CC: Matan Azrad , Raslan Darawsheh , Dariusz Sosnowski , Viacheslav Ovsiienko , Ori Kam , Suanming Mou Subject: [PATCH v2 07/23] common/mlx5: add GENEVE TLV option attribute structure Date: Thu, 25 Jan 2024 15:30:27 +0200 Message-ID: <20240125133043.575860-8-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240125133043.575860-1-michaelba@nvidia.com> References: <20231203112543.844014-1-michaelba@nvidia.com> <20240125133043.575860-1-michaelba@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE3A:EE_|CY8PR12MB7100:EE_ X-MS-Office365-Filtering-Correlation-Id: 31ade6f7-96f1-4686-ed27-08dc1da9e9e7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +0ePj3aMvm1dJIUjeWeSvvveTqZYkaY7tS1uyBPR6LJ2f90t0qCoCdqFHWC6tLNAX5mZR2EWGqss97T1n3LdsaZL7iDKYCLjyh1shlExCP/wjK3gDRVF/VcbttufsZbBG6ts5+mas6tcsJ8XZKm6XJSTG2QzhLUVvfdtRGQ/UuNYukpKTQyVaJB3fciYgT2jAdxcqiUvOXLQJKo3WuaJO6cEetdgot3S+urKNrn1TQt0AastCGgPU9pMbP+VFsc94bSCGg8ifTwyPAAEYA9bTV/JkLyGtOq3qAfy7BPzHjhilDPVzLy0qfTMiJJbcnRnJ5Nr6pKkpmHhWYwzqiO8ZbZP8Mx3xaVvOqMPGJIUj3in4KEHIuQJcByiF1G+bTV0r973MTloPrAQctAl9m6mFNYORYsf7+B5d58plTYAv/q63XBAi5FABSRukmUb/oWqfOyULffvsaTQ6MMc4G7XEDXxy65Al3sWZmff+RCPSK1sCIufSnVooziEYUQ/hEG+gp0QpzG90BgFa1rt9N+l/QYglFTCG8/rVbe90NInkvEO75ge9iboYVqKrZtYomHqOJCYsmPAJnfhKjhvG4D+ru/a1n3fts6aU21LmsKYRHhusbieovE5EGkXyGt7WNMjCQn2aMVzwNrMUAxvryeU+7N2R1JRh0789AbgOZG+UXB7JbAT8b42IrWQBq6iEuctYRQYFwF6X7FOTnKGQ5byY9GQ2rgYPkQj4G6OcrhEtn9C5+8o5z4L15hXl2jkEZjd X-Forefront-Antispam-Report: CIP:216.228.118.232; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(376002)(39860400002)(346002)(136003)(396003)(230922051799003)(451199024)(186009)(1800799012)(64100799003)(82310400011)(40470700004)(36840700001)(46966006)(55016003)(6666004)(41300700001)(478600001)(40480700001)(356005)(82740400003)(36860700001)(47076005)(7636003)(40460700003)(336012)(6286002)(426003)(26005)(2616005)(83380400001)(7696005)(54906003)(6916009)(316002)(2906002)(4326008)(8936002)(8676002)(36756003)(70586007)(70206006)(86362001)(5660300002)(107886003)(1076003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2024 13:31:18.9799 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 31ade6f7-96f1-4686-ed27-08dc1da9e9e7 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.232]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE3A.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7100 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add a new structure "mlx5_devx_geneve_tlv_option_attr" to use in GENEVE TLV option creation. Later this structure will be used by GENEVE TLV option query operation as well. Signed-off-by: Michael Baum Acked-by: Suanming Mou --- drivers/common/mlx5/mlx5_devx_cmds.c | 28 +++++++++++++--------------- drivers/common/mlx5/mlx5_devx_cmds.h | 11 ++++++++++- drivers/net/mlx5/mlx5_flow_dv.c | 10 +++++++--- 3 files changed, 30 insertions(+), 19 deletions(-) diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c index d3ecdfece7..c783fc0e10 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.c +++ b/drivers/common/mlx5/mlx5_devx_cmds.c @@ -2858,19 +2858,15 @@ mlx5_devx_cmd_create_conn_track_offload_obj(void *ctx, uint32_t pd, * * @param[in] ctx * Context returned from mlx5 open_device() glue function. - * @param [in] class - * TLV option variable value of class - * @param [in] type - * TLV option variable value of type - * @param [in] len - * TLV option variable value of len + * @param[in] attr + * Pointer to GENEVE TLV option attributes structure. * * @return * The DevX object created, NULL otherwise and rte_errno is set. */ struct mlx5_devx_obj * mlx5_devx_cmd_create_geneve_tlv_option(void *ctx, - uint16_t class, uint8_t type, uint8_t len) + struct mlx5_devx_geneve_tlv_option_attr *attr) { uint32_t in[MLX5_ST_SZ_DW(create_geneve_tlv_option_in)] = {0}; uint32_t out[MLX5_ST_SZ_DW(general_obj_out_cmd_hdr)] = {0}; @@ -2879,25 +2875,27 @@ mlx5_devx_cmd_create_geneve_tlv_option(void *ctx, 0, SOCKET_ID_ANY); if (!geneve_tlv_opt_obj) { - DRV_LOG(ERR, "Failed to allocate geneve tlv option object."); + DRV_LOG(ERR, "Failed to allocate GENEVE TLV option object."); rte_errno = ENOMEM; return NULL; } void *hdr = MLX5_ADDR_OF(create_geneve_tlv_option_in, in, hdr); void *opt = MLX5_ADDR_OF(create_geneve_tlv_option_in, in, - geneve_tlv_opt); + geneve_tlv_opt); MLX5_SET(general_obj_in_cmd_hdr, hdr, opcode, - MLX5_CMD_OP_CREATE_GENERAL_OBJECT); + MLX5_CMD_OP_CREATE_GENERAL_OBJECT); MLX5_SET(general_obj_in_cmd_hdr, hdr, obj_type, MLX5_GENERAL_OBJ_TYPE_GENEVE_TLV_OPT); MLX5_SET(geneve_tlv_option, opt, option_class, - rte_be_to_cpu_16(class)); - MLX5_SET(geneve_tlv_option, opt, option_type, type); - MLX5_SET(geneve_tlv_option, opt, option_data_length, len); + rte_be_to_cpu_16(attr->option_class)); + MLX5_SET(geneve_tlv_option, opt, option_type, attr->option_type); + MLX5_SET(geneve_tlv_option, opt, option_data_length, + attr->option_data_len); geneve_tlv_opt_obj->obj = mlx5_glue->devx_obj_create(ctx, in, - sizeof(in), out, sizeof(out)); + sizeof(in), out, + sizeof(out)); if (!geneve_tlv_opt_obj->obj) { - DEVX_DRV_LOG(ERR, out, "create GENEVE TLV", NULL, 0); + DEVX_DRV_LOG(ERR, out, "create GENEVE TLV option", NULL, 0); mlx5_free(geneve_tlv_opt_obj); return NULL; } diff --git a/drivers/common/mlx5/mlx5_devx_cmds.h b/drivers/common/mlx5/mlx5_devx_cmds.h index dfb1148b84..d11f1d650f 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.h +++ b/drivers/common/mlx5/mlx5_devx_cmds.h @@ -668,6 +668,15 @@ struct mlx5_devx_crypto_login_attr { uint8_t credential[MLX5_CRYPTO_CREDENTIAL_SIZE]; }; +/* + * GENEVE TLV option attributes structure, used by GENEVE TLV option create. + */ +struct mlx5_devx_geneve_tlv_option_attr { + uint32_t option_class:16; + uint32_t option_type:8; + uint32_t option_data_len:5; +}; + /* mlx5_devx_cmds.c */ __rte_internal @@ -778,7 +787,7 @@ int mlx5_devx_cmd_register_write(void *ctx, uint16_t reg_id, __rte_internal struct mlx5_devx_obj * mlx5_devx_cmd_create_geneve_tlv_option(void *ctx, - uint16_t class, uint8_t type, uint8_t len); + struct mlx5_devx_geneve_tlv_option_attr *attr); /** * Create virtio queue counters object DevX API. diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index cc5549f9ce..ae10981165 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -10046,11 +10046,15 @@ flow_dev_geneve_tlv_option_resource_register(struct rte_eth_dev *dev, goto exit; } } else { + struct mlx5_devx_geneve_tlv_option_attr attr = { + .option_class = geneve_opt_v->option_class, + .option_type = geneve_opt_v->option_type, + .option_data_len = geneve_opt_v->option_len, + }; + /* Create a GENEVE TLV object and resource. */ obj = mlx5_devx_cmd_create_geneve_tlv_option(sh->cdev->ctx, - geneve_opt_v->option_class, - geneve_opt_v->option_type, - geneve_opt_v->option_len); + &attr); if (!obj) { ret = rte_flow_error_set(error, ENODATA, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,