diff mbox series

[2/2] app/graph: fix build reason

Message ID 20240131174552.2601531-2-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series [1/2] build: fix reasons conflict |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/github-robot: build success github build: passed
ci/iol-abi-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-compile-arm64-testing success Testing PASS

Commit Message

David Marchand Jan. 31, 2024, 5:45 p.m. UTC 
  When a component is disabled, the reason meson variable must be set to
provide an explanation why.

Since epoll is a Linux thing, report that the graph application is only
supported on Linux.

Fixes: 5b21ffb23308 ("app/graph: add CLI framework")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 app/graph/meson.build | 1 +
 1 file changed, 1 insertion(+)

Comments

Tyler Retzlaff Jan. 31, 2024, 8:38 p.m. UTC | #1 
On Wed, Jan 31, 2024 at 06:45:52PM +0100, David Marchand wrote:
> When a component is disabled, the reason meson variable must be set to
> provide an explanation why.
> 
> Since epoll is a Linux thing, report that the graph application is only
> supported on Linux.
> 
> Fixes: 5b21ffb23308 ("app/graph: add CLI framework")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---

Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
fengchengwen Feb. 1, 2024, 2:31 a.m. UTC | #2 
Acked-by: Chengwen Feng <fengchengwen@huawei.com>

On 2024/2/1 1:45, David Marchand wrote:
> When a component is disabled, the reason meson variable must be set to
> provide an explanation why.
> 
> Since epoll is a Linux thing, report that the graph application is only
> supported on Linux.
> 
> Fixes: 5b21ffb23308 ("app/graph: add CLI framework")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  app/graph/meson.build | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/app/graph/meson.build b/app/graph/meson.build
> index 5b0f966d99..8aefdf505c 100644
> --- a/app/graph/meson.build
> +++ b/app/graph/meson.build
> @@ -5,6 +5,7 @@
>  name = 'graph'
>  build = cc.has_header('sys/epoll.h')
>  if not build
> +    reason = 'only supported on Linux'
>      subdir_done()
>  endif
>  
>
David Marchand Feb. 1, 2024, 9:24 a.m. UTC | #3 
On Wed, Jan 31, 2024 at 6:46 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> When a component is disabled, the reason meson variable must be set to
> provide an explanation why.
>
> Since epoll is a Linux thing, report that the graph application is only
> supported on Linux.
>
> Fixes: 5b21ffb23308 ("app/graph: add CLI framework")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  app/graph/meson.build | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/app/graph/meson.build b/app/graph/meson.build
> index 5b0f966d99..8aefdf505c 100644
> --- a/app/graph/meson.build
> +++ b/app/graph/meson.build
> @@ -5,6 +5,7 @@
>  name = 'graph'
>  build = cc.has_header('sys/epoll.h')
>  if not build
> +    reason = 'only supported on Linux'
>      subdir_done()
>  endif
>

Series applied, thanks.
diff mbox series

Patch

diff --git a/app/graph/meson.build b/app/graph/meson.build
index 5b0f966d99..8aefdf505c 100644
--- a/app/graph/meson.build
+++ b/app/graph/meson.build
@@ -5,6 +5,7 @@ 
 name = 'graph'
 build = cc.has_header('sys/epoll.h')
 if not build
+    reason = 'only supported on Linux'
     subdir_done()
 endif