From patchwork Mon Feb 5 17:43:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 136404 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C738B43A3D; Mon, 5 Feb 2024 19:05:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8EC84427E6; Mon, 5 Feb 2024 19:04:00 +0100 (CET) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id BC7984111C for ; Mon, 5 Feb 2024 19:03:54 +0100 (CET) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1d91397bd22so35994295ad.0 for ; Mon, 05 Feb 2024 10:03:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1707156234; x=1707761034; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=P2oFxkSJHPebrZfcV+POmP1qNUsGTBu4dYoB/rm+LX8=; b=XgvUzA3Kr1lViU19ZBkGv5damDxO8V4iEHAAGZFf3q5Kmql90/uyFs7CH8iu8ZwIaP OiFwIt4vUOg79MngqfLVBw053fB0vdW9WDwuLp5isPB957yVlaIhB6o1Y7224CBlqUrg KkAjSDFrmRNz6ufzqx/LI5q+u538kjjb+p8X9MlZ47VgboycRnjTwxQk7A7oXcmqeXuk FoPw2INKLQsWGvNA38rduOhaygDFjXWC3NJ+7F3+HRwRujoRL5yQo2PieiSmXJi6My2L S2+oP1XIaSAO06fExI5TP4WhU+RXHf5S6dO0T4Wtt0p9kmzDui3+wA1emY0DG4+MflTf NEDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707156234; x=1707761034; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P2oFxkSJHPebrZfcV+POmP1qNUsGTBu4dYoB/rm+LX8=; b=VdxlK/tW4y1jYBi2Es6QMiD8KlJ+4hb5S+EwBlI3FRxyFLKKc0LGOm2OujhnmHO1wa IyYXM06Y47eIkYtn71mpGOCHa2LaXXBHLv6C9fTx3Qc8mxN2mmpenXSeyw6LURkJa7Yf kNo+Q5FS4ldCQvnGcIr+i5lpsXfL/6wE5sZaUKCrXs2RplnrfjRdqwdkeTcugdq6qiDB mdJmK4zndwDrA8Or1VO7QyQPV6//HlsnXHLbG26SelFkZhDNLy/m4qZ0OuDa0Q46mGtD Zr1RiBQV6GJvBsuoZuxCgqq8eJB66pwy9zigmMHDuJKc7nYEN0MlUtslp8aSj23ng0bS IcTA== X-Gm-Message-State: AOJu0YxGrRncI17zJzUJ7uBL0iH1PetgxUlx+IGsLLcSC4AQxgxxc+wZ w/Sg1nMKd2zUkYTp338UkQuoiyKl7tyHZym7WweZ4AUsMEhOzKd7gzXUGR/UnEwrPS40QZPtqt7 LrOY= X-Google-Smtp-Source: AGHT+IHBQbage7hXnRTqBNfUhY9Zq/amnEfAAGEoy6hqzOChS/DFPIU9vSZNBWa41CecpUb6Oe8JuA== X-Received: by 2002:a17:902:7584:b0:1d9:a589:aa6f with SMTP id j4-20020a170902758400b001d9a589aa6fmr252730pll.67.1707156233994; Mon, 05 Feb 2024 10:03:53 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUySJkk9o3cbnfChBAC5i0yCp11gtguKBihsQ6yxQTuUgkXDVwjIfruq+V00XFj0W6BkZvPZql2e8yDsULKRNutOIvgPQ== Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id x8-20020a170902b40800b001d9b0a15bbfsm144867plr.262.2024.02.05.10.03.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 10:03:53 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Julien Aube Subject: [PATCH v9 17/23] net/bnx2x: remove reference to sanity Date: Mon, 5 Feb 2024 09:43:45 -0800 Message-ID: <20240205180328.131019-18-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240205180328.131019-1-stephen@networkplumber.org> References: <0230331200824.195294-1-stephen@networkplumber.org> <20240205180328.131019-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace "sanity check" Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x.c | 2 +- drivers/net/bnx2x/bnx2x_stats.c | 8 ++++---- drivers/net/bnx2x/ecore_sp.c | 2 +- drivers/net/bnx2x/elink.c | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index c3283c94f38f..e345f293f25c 100644 --- a/drivers/net/bnx2x/bnx2x.c +++ b/drivers/net/bnx2x/bnx2x.c @@ -7820,7 +7820,7 @@ static int bnx2x_check_valid_mf_cfg(struct bnx2x_softc *sc) uint32_t ovlan2; uint8_t i, j; - /* various MF mode sanity checks... */ + /* various MF mode checks... */ if (mf_info->mf_config[SC_VN(sc)] & FUNC_MF_CFG_FUNC_HIDE) { PMD_DRV_LOG(NOTICE, sc, diff --git a/drivers/net/bnx2x/bnx2x_stats.c b/drivers/net/bnx2x/bnx2x_stats.c index c07b01510a06..86d90679ac0a 100644 --- a/drivers/net/bnx2x/bnx2x_stats.c +++ b/drivers/net/bnx2x/bnx2x_stats.c @@ -187,7 +187,7 @@ bnx2x_stats_pmf_update(struct bnx2x_softc *sc) */ return; } - /* sanity */ + /* input valid? */ if (!sc->port.pmf || !sc->port.port_stx) { PMD_DRV_LOG(ERR, sc, "BUG!"); return; @@ -237,7 +237,7 @@ bnx2x_port_stats_init(struct bnx2x_softc *sc) uint32_t mac_addr; uint32_t *stats_comp = BNX2X_SP(sc, stats_comp); - /* sanity */ + /* input valid? */ if (!sc->link_vars.link_up || !sc->port.pmf) { PMD_DRV_LOG(ERR, sc, "BUG!"); return; @@ -461,7 +461,7 @@ bnx2x_func_stats_init(struct bnx2x_softc *sc) struct dmae_command *dmae = &sc->stats_dmae; uint32_t *stats_comp = BNX2X_SP(sc, stats_comp); - /* sanity */ + /* input valid? */ if (!sc->func_stx) { PMD_DRV_LOG(ERR, sc, "BUG!"); return; @@ -1301,7 +1301,7 @@ bnx2x_port_stats_base_init(struct bnx2x_softc *sc) struct dmae_command *dmae; uint32_t *stats_comp = BNX2X_SP(sc, stats_comp); - /* sanity */ + /* input valid? */ if (!sc->port.pmf || !sc->port.port_stx) { PMD_DRV_LOG(ERR, sc, "BUG!"); return; diff --git a/drivers/net/bnx2x/ecore_sp.c b/drivers/net/bnx2x/ecore_sp.c index c6c3857778f7..158205266f62 100644 --- a/drivers/net/bnx2x/ecore_sp.c +++ b/drivers/net/bnx2x/ecore_sp.c @@ -207,7 +207,7 @@ static int ecore_exe_queue_step(struct bnx2x_softc *sc, break; } - /* Sanity check */ + /* Argument check */ if (!cur_len) return ECORE_SUCCESS; diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c index 2c81f85b9605..6ebd47d927f8 100644 --- a/drivers/net/bnx2x/elink.c +++ b/drivers/net/bnx2x/elink.c @@ -1088,7 +1088,7 @@ static void elink_get_epio(struct bnx2x_softc *sc, uint32_t epio_pin, { uint32_t epio_mask, gp_oenable; *en = 0; - /* Sanity check */ + /* Input check */ if (epio_pin > 31) { ELINK_DEBUG_P1(sc, "Invalid EPIO pin %d to get", epio_pin); return; @@ -1105,7 +1105,7 @@ static void elink_set_epio(struct bnx2x_softc *sc, uint32_t epio_pin, uint32_t e { uint32_t epio_mask, gp_output, gp_oenable; - /* Sanity check */ + /* Input check */ if (epio_pin > 31) { ELINK_DEBUG_P1(sc, "Invalid EPIO pin %d to set", epio_pin); return;