[13/13] common/cnxk: use SQ enable and disable API

Message ID 20240208085956.1741174-13-ndabilpuram@marvell.com (mailing list archive)
State Changes Requested, archived
Delegated to: Jerin Jacob
Headers
Series [01/13] common/cnxk: remove cn9k Inline IPsec FP opcode defines |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/Intel-compilation warning apply issues
ci/loongarch-unit-testing success Unit Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-compile-arm64-testing success Testing PASS

Commit Message

Nithin Dabilpuram Feb. 8, 2024, 8:59 a.m. UTC
  Use SQ enable and disable API in TM setup to affect
the state change.

Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
---
 drivers/common/cnxk/roc_nix_tm_ops.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Jerin Jacob Feb. 9, 2024, 9:28 a.m. UTC | #1
On Thu, Feb 8, 2024 at 2:32 PM Nithin Dabilpuram
<ndabilpuram@marvell.com> wrote:
>
> Use SQ enable and disable API in TM setup to affect
> the state change.
>
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>

Please fix

Wrong headline prefix:
        common/cnxk: remove cn9k Inline IPsec FP opcode defines
        common/cnxk: skip setting Tx MTU separately
Is it candidate for Cc: stable@dpdk.org backport?
        common/cnxk: remove cn9k Inline IPsec FP opcode defines
        net/cnxk: fix issue with buff size compute
        net/cnxk: fix max MTU limit
        net/cnxk: fix indirect mbuf handling in Tx path
        net/cnxk: fix check cookies for multi-seg offload
        common/cnxk: add IO attribute to mbox structs

Invalid patch(es) found - checked 14 patches
check-git-log failed

### [PATCH] net/cnxk: fix indirect mbuf handling in Tx path

Warning in drivers/net/cnxk/cn10k_tx.h:
Using __atomic_xxx/__ATOMIC_XXX built-ins, prefer
rte_atomic_xxx/rte_memory_order_xxx
  

Patch

diff --git a/drivers/common/cnxk/roc_nix_tm_ops.c b/drivers/common/cnxk/roc_nix_tm_ops.c
index 900b182c76..9f3870a311 100644
--- a/drivers/common/cnxk/roc_nix_tm_ops.c
+++ b/drivers/common/cnxk/roc_nix_tm_ops.c
@@ -495,7 +495,7 @@  roc_nix_tm_hierarchy_disable(struct roc_nix *roc_nix)
 		if (!sq)
 			continue;
 
-		rc = roc_nix_tm_sq_aura_fc(sq, false);
+		rc = roc_nix_sq_ena_dis(sq, false);
 		if (rc) {
 			plt_err("Failed to disable sqb aura fc, rc=%d", rc);
 			goto cleanup;
@@ -607,7 +607,7 @@  roc_nix_tm_hierarchy_xmit_enable(struct roc_nix *roc_nix, enum roc_nix_tm_tree t
 		sq_id = node->id;
 		sq = nix->sqs[sq_id];
 
-		rc = roc_nix_tm_sq_aura_fc(sq, true);
+		rc = roc_nix_sq_ena_dis(sq, true);
 		if (rc) {
 			plt_err("TM sw xon failed on SQ %u, rc=%d", node->id,
 				rc);