From patchwork Thu Feb 8 17:13:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 136543 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC42243AE1; Thu, 8 Feb 2024 18:13:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E295042E3C; Thu, 8 Feb 2024 18:13:38 +0100 (CET) Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by mails.dpdk.org (Postfix) with ESMTP id 574E742E3B for ; Thu, 8 Feb 2024 18:13:38 +0100 (CET) Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-5dbf7b74402so1328427a12.0 for ; Thu, 08 Feb 2024 09:13:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1707412417; x=1708017217; darn=dpdk.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=Rh+gkdV/ZdUgPI0ljkxJX26ZA1C5cSHlMrPvCi1PsfE=; b=JcICiqYXYkBkF2yEn5s4XM9mr5fE3OHGcewnjHPDQc3PBQi57hdNOJlncjWq/rD4QH 3ugKpSIh0JDKQbzO2gIzzbJxdk8aca/7clOjqyEQRHsBbuTIvNsOpiQcoifWwoUG+/tj hOb+T1iPiyRwck6MMZujV+3yB5Ci2MREKWywQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707412417; x=1708017217; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Rh+gkdV/ZdUgPI0ljkxJX26ZA1C5cSHlMrPvCi1PsfE=; b=SnYCadJnRw0XGhJnEp7k//+ZdCy7n4ppJ8f2NOZeV+KUai7/spW8DMco/RnOtvEHof gkFhDOdVX9q4hibd/2jwgEIa8FVVCL2NBGFVWuXS8iLj4fPnH9kPi+EFZGLK2lxM6OXc 6jmDV/OZfrIryuu8wWRYjULcHFiiX0IH5LD2LfOo7w7bMCZ0dzmEqM3ZPD9WqVAchxYa GOJiXeaztLc0b3xz8q+S72KEhQ549rxXDAXo1VPyXTUwbyPDGdiQHG81zxGOHH5LWA4Y a0EuNBfOuij+Nb8xudKohwfNXvl4QGrIBVuAGKv93MedVP9Xoix2bVmvj0pMcilSyvNT KaKg== X-Gm-Message-State: AOJu0Yykp2zaNtuKiuFUzYXGsNVD+5YT8fynKeJdmTUCS3sdtatpYc0w viWcKli6fDedFFbD1MMOrB73GwcP3stUmzy5NAyR4lXDEVN5FCWPZ08xTkgbMCppZMTzrXwDeak kc+nFjyH9mv0QOXikkuJ2k0s8hBOBy2Q+R9dSFZ06drkkM2tpDQXFTOpeYQRQcxP/TarXb4YM51 142ISOxWLCT5obbUOuKql2P6tOP2ZB X-Google-Smtp-Source: AGHT+IF0iVyMdiadC+f2SUuVDk5da9sLYzYCqepXe/BduinZb8ABRVBYRVxcptu45mC3S+OWP4f+5A== X-Received: by 2002:a05:6a20:2585:b0:19e:a574:9b10 with SMTP id k5-20020a056a20258500b0019ea5749b10mr252880pzd.33.1707412416946; Thu, 08 Feb 2024 09:13:36 -0800 (PST) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id p15-20020aa79e8f000000b006e0527ffe88sm3966204pfq.213.2024.02.08.09.13.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 09:13:35 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: Kishore Padmanabha Subject: [PATCH 1/7] net/bnxt: avoid seg fault in Tx queue release Date: Thu, 8 Feb 2024 09:13:24 -0800 Message-Id: <20240208171330.31139-2-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20240208171330.31139-1-ajit.khaparde@broadcom.com> References: <20240208171330.31139-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Kishore Padmanabha The tx queue mutex should be freed before the tx queue structure and similarly the completion ring stats should be reset before ring free. Signed-off-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_txq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_txq.c b/drivers/net/bnxt/bnxt_txq.c index f99ad211db..7d91e88c9d 100644 --- a/drivers/net/bnxt/bnxt_txq.c +++ b/drivers/net/bnxt/bnxt_txq.c @@ -104,12 +104,12 @@ void bnxt_tx_queue_release_op(struct rte_eth_dev *dev, uint16_t queue_idx) /* Free TX completion ring hardware descriptors */ if (txq->cp_ring) { + bnxt_free_txq_stats(txq); bnxt_free_ring(txq->cp_ring->cp_ring_struct); rte_free(txq->cp_ring->cp_ring_struct); rte_free(txq->cp_ring); } - bnxt_free_txq_stats(txq); rte_memzone_free(txq->mz); txq->mz = NULL;