From patchwork Fri Feb 16 17:07:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Boyer X-Patchwork-Id: 136854 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A34543B31; Fri, 16 Feb 2024 18:07:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C5135406B6; Fri, 16 Feb 2024 18:07:52 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2066.outbound.protection.outlook.com [40.107.220.66]) by mails.dpdk.org (Postfix) with ESMTP id 84E75406B6 for ; Fri, 16 Feb 2024 18:07:51 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X/QeCJXID3L2Y+AY4KkdIJiAOEu/xR/qGSSqT5mzIhztfUbB5JyHkq22u1XRMtPIbzLEZSHzVPHmcPETE7kNGr3Qmr4puGyi94/UhcmdI1cjGzJbNaIctDNuMwdtCeSrkprdexTB7RjB+spj5EQglOMwdns0XGmI9rZPUuwa+8oC33jMrY8yUpCZnxpgcL+VmwqqLuLvmGrxcXRfUAbm05nDsf7D63HfhgV9QzYS2A5eW/dp7NkJT/ztfcqipCa2WxkUIXk08Vfsf+OqgIPVpmV/nMgERVVYighba1Xige4MIEPKgiAR/fkqtI6SQ0GhWz+dAWF96s6cPCCmQD5rOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6g9GZ2x3w2Lw+ONBuh26YIywhch60weTTQayx+Tr5CM=; b=lb4wxBq2xdUQu2dL5Pr/6P6RqB3BC5eN7+hsaU+Ydmir5XIEhFgTLDAIcs25x/p4ueTMWh21DwHjN0AHm7i2g96Wd2OTdEpk/7K1i2UdEEGpqPRX2rc/vc7A5vdWl2VoP34Ri8wAaM0SeKvIK99j19LB//P0/1QxqeG3VYX/yJkMN2CfbsncKSvbD/jQVOyL8Qp3v5Bz4qj50JnpbwTZ+s80o2QpnHR6xmE3TG/YRTRGDXVpFNPqV5WEcfnj9qgV/Fw6VcfTYxc7lWMSxDxOUE3WCdgQzLkx/4KL5Evb0enXFuWuYC/mY6dfsxz7BMby17tFw7XLc9Wn+4CzapaK5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6g9GZ2x3w2Lw+ONBuh26YIywhch60weTTQayx+Tr5CM=; b=UBGhvDPYyG+c8JvDcO9t92YMuGBlPsVvVaABajO+TWXBQ7PhGCbeSKBQ9RB+PQ3GZqOsnJtUxRjCJdni64vB3jhPGBb8Z53rYtHpU75WFSfqWCvmF132EpUj97GAofGXc1tO4fNOxQJKyFYpo60LWpCl1oQMFzz55bbyUowFjzo= Received: from MW4PR03CA0133.namprd03.prod.outlook.com (2603:10b6:303:8c::18) by PH7PR12MB6980.namprd12.prod.outlook.com (2603:10b6:510:1ba::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.27; Fri, 16 Feb 2024 17:07:46 +0000 Received: from MWH0EPF000989E8.namprd02.prod.outlook.com (2603:10b6:303:8c:cafe::77) by MW4PR03CA0133.outlook.office365.com (2603:10b6:303:8c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.40 via Frontend Transport; Fri, 16 Feb 2024 17:07:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by MWH0EPF000989E8.mail.protection.outlook.com (10.167.241.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7292.25 via Frontend Transport; Fri, 16 Feb 2024 17:07:46 +0000 Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 16 Feb 2024 11:07:45 -0600 From: Andrew Boyer To: CC: Andrew Boyer , Neel Patel Subject: [PATCH 2/3] net/ionic: remove duplicate barriers Date: Fri, 16 Feb 2024 09:07:03 -0800 Message-ID: <20240216170704.55523-3-andrew.boyer@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240216170704.55523-1-andrew.boyer@amd.com> References: <20240216170704.55523-1-andrew.boyer@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000989E8:EE_|PH7PR12MB6980:EE_ X-MS-Office365-Filtering-Correlation-Id: 52cec93f-87dc-479c-5a26-08dc2f11cc21 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7+9cDM4+ZCcv00jiokXO0Yx6XzwE0688EcWQkuKQov8e+UtS3OPn7aR6WmQi8+sym/a6PtW3HnrvYL8oem1bfqad+dWE1ZjPfKO+Q4GTIDPODGy5srsJ9KvEynGiIstdRCimsKO3ofXMfgGD+Xn7UhDTyIyBVxgm8msbe3vitbPFoKrBgtZQ+aB41ACuz6toK8zmfTVWMA7e0aoDOBWari7QIqLQqXOMUNYRB/CkGWxq1a+bMs6AUHHLrnmwQCL7hseftU4Y1EANXBud4qZb1Ld03zwb7ho78eLD7AKfYo7VtoYf8fBeFCA5/fJgXsml+cTaG89gVrVcItq0k85hLskD/qoMu8d14G8i/Ogo9tzTv3tnxQw8O0AoVVdo1gfZ4JMABm7+Mln2qVLD5ao7FwFj34JNghWfxIG6bzMGyQn6nQoYGb89QOvMbaz/85Cu/0u2xuZUZHqCfuzsQwkt/nxY0MZbYNnX8a3GXf1M0OpLwupL/DU1/W0drJ96c5qoLyKZbPgSjnIIOv02+FkOkw/47CkLhMH/dG2DXYFkGNSRhaM206kp3V4HPtWp2PaYqI3vfVpq5GwBYTuh/TcQwi1tKE5tISsYV+SukgSx6VdfmfXZ6OSutB2Z/9OlQgQbK2Zkb3JZ1CpZMP8AW2dvBrLIH84K3/HIe4allzpBAcg= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(136003)(39860400002)(396003)(376002)(346002)(230922051799003)(1800799012)(82310400011)(186009)(451199024)(36860700004)(64100799003)(40470700004)(46966006)(2906002)(5660300002)(44832011)(8936002)(4326008)(8676002)(41300700001)(86362001)(82740400003)(83380400001)(81166007)(356005)(54906003)(36756003)(2616005)(6916009)(426003)(1076003)(6666004)(70206006)(16526019)(70586007)(478600001)(336012)(26005)(316002); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2024 17:07:46.4048 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 52cec93f-87dc-479c-5a26-08dc2f11cc21 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000989E8.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6980 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org These barriers are duplicated by the barriers inside rte_write64(). Remove them to improve performance. Signed-off-by: Neel Patel Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_main.c | 1 - drivers/net/ionic/ionic_rxtx_sg.c | 1 - drivers/net/ionic/ionic_rxtx_simple.c | 1 - 3 files changed, 3 deletions(-) diff --git a/drivers/net/ionic/ionic_main.c b/drivers/net/ionic/ionic_main.c index 1f24f64a33..814bb3b8f4 100644 --- a/drivers/net/ionic/ionic_main.c +++ b/drivers/net/ionic/ionic_main.c @@ -223,7 +223,6 @@ ionic_adminq_post(struct ionic_lif *lif, struct ionic_admin_ctx *ctx) q->head_idx = Q_NEXT_TO_POST(q, 1); /* Ring doorbell */ - rte_wmb(); ionic_q_flush(q); err_out: diff --git a/drivers/net/ionic/ionic_rxtx_sg.c b/drivers/net/ionic/ionic_rxtx_sg.c index e8dec99c04..3820fd850f 100644 --- a/drivers/net/ionic/ionic_rxtx_sg.c +++ b/drivers/net/ionic/ionic_rxtx_sg.c @@ -218,7 +218,6 @@ ionic_xmit_pkts_sg(void *tx_queue, struct rte_mbuf **tx_pkts, } if (nb_tx > 0) { - rte_wmb(); ionic_txq_flush(q); txq->last_wdog_cycles = rte_get_timer_cycles(); diff --git a/drivers/net/ionic/ionic_rxtx_simple.c b/drivers/net/ionic/ionic_rxtx_simple.c index 9674b4d1df..4c9b9415ad 100644 --- a/drivers/net/ionic/ionic_rxtx_simple.c +++ b/drivers/net/ionic/ionic_rxtx_simple.c @@ -191,7 +191,6 @@ ionic_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, } if (nb_tx > 0) { - rte_wmb(); ionic_txq_flush(q); txq->last_wdog_cycles = rte_get_timer_cycles();