From patchwork Tue Feb 20 20:42:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Boyer X-Patchwork-Id: 136938 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18A0443B58; Tue, 20 Feb 2024 21:43:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 90872406A2; Tue, 20 Feb 2024 21:43:00 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2065.outbound.protection.outlook.com [40.107.93.65]) by mails.dpdk.org (Postfix) with ESMTP id 1D2C24067A for ; Tue, 20 Feb 2024 21:42:58 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IMX3RtqAZjjMmBaW4hxCiLLspBFikcl/Tx4ovbSwhecANAAhLvJy/8IQeCcCYtErwbZlQ0l0i9tunWwH1s/CaVcM4nFeKmk4nGL1f0zhX2hldckjmkujYicv1QH/LF1Fmo4MA7OMExwiJi3KyMIflI0vNS+u5gr1wWTVGViNpWGirPjH5gEpTALWqpf1L2buhOEfrwN009nbt2sQrdMku2QpsxaQDHrLhSqxKKtwtZ6EKg5UJPocEw/5o/mz6pA3tJUGISkqRvLeOTy8v1XOLsg17qcY3RdPyGuRxDlCJoWCfT4xpGxVtdZiVdZZ5L9sj/DU7Q85eGLav/BXJtXEIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6g9GZ2x3w2Lw+ONBuh26YIywhch60weTTQayx+Tr5CM=; b=FAwSQVgAGRZ3D5vk2rTi+1EYina9HnUWCKUes+Tb1hU+gDPGgq/Nug3o79MKEq0XMRBKokk/eRYOmE66RGuu69r0+ZxXWNhfzalMouIpiFnI/GAyuVPiR/spJZKJxsloQRp/i/8dv/lLv29wo8t0wykTZjdRWB+2wSMXKP2jQE1s21Rw+PRoe96+8CfucKj4wU1aoDxDvXUzqbKerh/WAq84XKQgfV96DuNv3S3GFD4vmojLyOYJBNS9CBM9fhkKhH/eqsCiDDNLngBBusOurrXElK8XfTvHO0/QVe1h1UtwEHmiaiz/7MoW1TKF0jbBChBu9MMp+2eUF/4I8mW3Zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6g9GZ2x3w2Lw+ONBuh26YIywhch60weTTQayx+Tr5CM=; b=kpnZDN7kBmSX2JDWGHsEl5Evn/ay2TnfQdt5H6X45DMJa66gyx8jgw5cvUAMFo4MEtS6txHMFOsyCIZ/iI4Ms8UkSKqzqzYuZRvvK64Z6GdYwh+/VmcQpvh76NZZbXrvUHtx4PNe7N7z/H5sd+fsPUOXZdp5aF4RdFtQWsZRt28= Received: from MW4PR02CA0012.namprd02.prod.outlook.com (2603:10b6:303:16d::35) by BY5PR12MB4323.namprd12.prod.outlook.com (2603:10b6:a03:211::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.20; Tue, 20 Feb 2024 20:42:56 +0000 Received: from CO1PEPF000044EE.namprd05.prod.outlook.com (2603:10b6:303:16d:cafe::31) by MW4PR02CA0012.outlook.office365.com (2603:10b6:303:16d::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.39 via Frontend Transport; Tue, 20 Feb 2024 20:42:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF000044EE.mail.protection.outlook.com (10.167.241.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7292.25 via Frontend Transport; Tue, 20 Feb 2024 20:42:55 +0000 Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 20 Feb 2024 14:42:54 -0600 From: Andrew Boyer To: CC: Andrew Boyer , Neel Patel Subject: [PATCH v2 2/3] net/ionic: remove duplicate barriers Date: Tue, 20 Feb 2024 12:42:25 -0800 Message-ID: <20240220204226.27494-3-andrew.boyer@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240220204226.27494-1-andrew.boyer@amd.com> References: <20240216170704.55523-1-andrew.boyer@amd.com> <20240220204226.27494-1-andrew.boyer@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044EE:EE_|BY5PR12MB4323:EE_ X-MS-Office365-Filtering-Correlation-Id: 700bb59c-aa1e-405a-737d-08dc32548478 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dj0dYV/Xbl6OrXrTY9aSyN7WdwucAlRIa/sQutAbNJWcBMZChT5oB+37vEwGN4GeDQRYVaPd/PJnU3NieFR3fMsdJYPHYnDYXV+3jhgoaOTuLDxQlBjYRw6KvjMM425JDWnSsJq8HD3HOkTpD1KV8Lrl9lmsPQSb8dI1lgPt/FoB3tW7Fxt4Lbr+WFX1qKHolHln3Dm00WhndOUMR21bHFJql0iR3z9d1TT/oqusZ323wICanVpDmrh5YmXQz8QkUAh27O0l3nELDrNZR1pvCEQrHEj/O+6z4VBB7K/rBE5Ffsn9JEyRnd4kqPlvuvPLg4NugOKTQQGqnx5NDaLxcFfSscAHmjsy/qGLXVZmMwQVzA9TPRptJhq0+PBdUH0bShPry265H0k2QXjYA49zQ4KQ61VPAz1kncIebutEwAS4+EvQ9+D9nK9aQLwsZg4WQbJswoRbwrNTsTynIVY34jdB+VZBwA7+ZPNj0/Il/T9jgCYU3Uqn9KJiZuTGO1OsjqIP12xYNF12++/ra8stooEOkwBTYAj0uuPjiS/iRx6WPScpf9qYU98lYhsbr9F3ixp2ifhn6kk/d9UVr4S8kP2kmnerzPFiRLBXb8mbSzB28NZucjvdejirfUS9NEoZptR8we0PYvAwV4/LGEL7r7T+XXmg8nNmAMeekHsnw+c= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(36860700004)(46966006)(40470700004); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 20:42:55.9333 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 700bb59c-aa1e-405a-737d-08dc32548478 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044EE.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4323 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org These barriers are duplicated by the barriers inside rte_write64(). Remove them to improve performance. Signed-off-by: Neel Patel Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_main.c | 1 - drivers/net/ionic/ionic_rxtx_sg.c | 1 - drivers/net/ionic/ionic_rxtx_simple.c | 1 - 3 files changed, 3 deletions(-) diff --git a/drivers/net/ionic/ionic_main.c b/drivers/net/ionic/ionic_main.c index 1f24f64a33..814bb3b8f4 100644 --- a/drivers/net/ionic/ionic_main.c +++ b/drivers/net/ionic/ionic_main.c @@ -223,7 +223,6 @@ ionic_adminq_post(struct ionic_lif *lif, struct ionic_admin_ctx *ctx) q->head_idx = Q_NEXT_TO_POST(q, 1); /* Ring doorbell */ - rte_wmb(); ionic_q_flush(q); err_out: diff --git a/drivers/net/ionic/ionic_rxtx_sg.c b/drivers/net/ionic/ionic_rxtx_sg.c index e8dec99c04..3820fd850f 100644 --- a/drivers/net/ionic/ionic_rxtx_sg.c +++ b/drivers/net/ionic/ionic_rxtx_sg.c @@ -218,7 +218,6 @@ ionic_xmit_pkts_sg(void *tx_queue, struct rte_mbuf **tx_pkts, } if (nb_tx > 0) { - rte_wmb(); ionic_txq_flush(q); txq->last_wdog_cycles = rte_get_timer_cycles(); diff --git a/drivers/net/ionic/ionic_rxtx_simple.c b/drivers/net/ionic/ionic_rxtx_simple.c index 9674b4d1df..4c9b9415ad 100644 --- a/drivers/net/ionic/ionic_rxtx_simple.c +++ b/drivers/net/ionic/ionic_rxtx_simple.c @@ -191,7 +191,6 @@ ionic_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, } if (nb_tx > 0) { - rte_wmb(); ionic_txq_flush(q); txq->last_wdog_cycles = rte_get_timer_cycles();