From patchwork Wed Feb 21 10:01:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dariusz Sosnowski X-Patchwork-Id: 136949 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA39243B61; Wed, 21 Feb 2024 11:02:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A49C240695; Wed, 21 Feb 2024 11:02:27 +0100 (CET) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2046.outbound.protection.outlook.com [40.107.212.46]) by mails.dpdk.org (Postfix) with ESMTP id 40B1B40685; Wed, 21 Feb 2024 11:02:26 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P4MoPGtI2mjblxb3V3wmvvNdchkve02qnamcl2q/L/y2YKohuE/neXKnp0D/vuimlr9W4XZcipFAwQlhqQtFL9RCcseyGvFQen52iLoPmBrGXs8W2HKoY7x8rCkwJyfVDeKvei+ocZDyKmCoDoKLhoQkfG+PiIHCYli9wVPBjh/5W1TvwweBifPcqrwMIu8+iCIQ+YVNg6l3kPNyBOgkijhGOLB6ucR3EdPJmPLi84MGQyFYK6YTtwJCQZSfhblULNTOtpuYt1Sbou/K/8BO17/Lxs0Qfw9nOWo8rctY6spZwtPVCPGPErSA/aFdyhrywM3q9Xx8K7w96d7Sws413g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Al3rHRbwvhSYUpHP+VXQjseINJBg3/ojj3QPHOjGc4w=; b=gSMGR0ZjQS+zgNA9p+aLPOh5EFOf0yFWOSeoOlJHtZUjBvqZjU0Vr+YZrWovrwUK74Q1U4TD+R0ewn7lRrhE8diaHHkK3JoAn2Fu5NhTKvSqPpTs+EZeC0txn1JIWMPcNa5xTX9YiZX1PnCZe4AeVD7+ZKzs3ecglKiH2lbAjAfsfHVF6v3nKPCmPokesfNJwGrFXT9+3k9sjdwu30naS+eZHUQxzymLQx5sO/DiwTffhfryyuNHDLx8T0FmzbYczrLl8xaBg2wb8jfHPM4HBAnzoAVH5unYiy2r7mcCkQjenhbjStLKbUF5Sf/5HLRHdsHuPNz1BMvBR7rJcID1Ew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Al3rHRbwvhSYUpHP+VXQjseINJBg3/ojj3QPHOjGc4w=; b=Vz3MdFSlrDnDEVyBYeNgrlK0W7RocUr5VJKhRcP2UgQG/bu8mS4tw2Q/Ui7Nz8RraJvZct3LmfFYhPCQBhEK6hKJ1UsZHfNoL8XEYmCr0hCEyQFv4Kd1WNjq3H1ej7il2cbSGeDMKQXAAJ9GERPXlKhUsskPrP5BNXsU8M056moQxzcMVNe9RtNz0Y0sfEaz0KbPmJPz2CnN9uMRnItc+Gr6W8UDh2ZOOGJQSQwa2z8laO2BuaeiTwo8AyehspEmU23TLkVqJk3pBZ75Z0+K1KBQ8ljXgCByluG1fDFLzR/Vv+ccO4jPX2vNsKAILjYdLFmi+R8vYrLy5L1eiXtrAA== Received: from CYZPR20CA0018.namprd20.prod.outlook.com (2603:10b6:930:a2::6) by SA1PR12MB8948.namprd12.prod.outlook.com (2603:10b6:806:38e::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.20; Wed, 21 Feb 2024 10:02:23 +0000 Received: from CY4PEPF0000E9D2.namprd03.prod.outlook.com (2603:10b6:930:a2:cafe::93) by CYZPR20CA0018.outlook.office365.com (2603:10b6:930:a2::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.41 via Frontend Transport; Wed, 21 Feb 2024 10:02:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000E9D2.mail.protection.outlook.com (10.167.241.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.25 via Frontend Transport; Wed, 21 Feb 2024 10:02:22 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 21 Feb 2024 02:02:09 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Wed, 21 Feb 2024 02:02:06 -0800 From: Dariusz Sosnowski To: Viacheslav Ovsiienko , Ori Kam , Suanming Mou , Matan Azrad , Alexander Kozyrev CC: , Subject: [PATCH 1/4] net/mlx5: fix conntrack action handle representation Date: Wed, 21 Feb 2024 12:01:42 +0200 Message-ID: <20240221100145.8234-2-dsosnowski@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240221100145.8234-1-dsosnowski@nvidia.com> References: <20240221100145.8234-1-dsosnowski@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D2:EE_|SA1PR12MB8948:EE_ X-MS-Office365-Filtering-Correlation-Id: 283c1901-d22e-4c84-85eb-08dc32c432f0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GR4W6I4UUoweqyGccaOKqtGYNI+uTcCH67RTmPU10xzPUqQ9VWES4g4jAa2DF9xvm+/BqDhEDNwIzqHjCW0uy5/0w1ih1LTi8uJlkOHIV5iL0JiIxwiimyAa7XasuzVontOnmY6y62MVx9fgZVoVW3FzFFnwqKcZh3PP+niBSLgrvnclrqZVk0rLHbHX56GkK3SgTcio50tYjqfPCfbSHaJa4WwhCGiQwSU6+hiJccyxaaOieSA8O8dbTgF6x4W0TtzMf8RuGYdc9KivuOmx5mLICeBLHjhSBk/o1LxUNHQv5RsR2Ijq1WNKSn72+pPZGkrHHPtZdyF9SmUf28mRXT5FIXZr0bj702sCdhbOThz+JNw+ce+U/RX3von37+OADgYliYq6QnVa/IIfXdbIDKx/D3/JmlUzJ89/M+3KYE1TesQYhRHcPn4GSCV+zIwcAjbUCnK4cQrooPaIyUnT+KnM+vWo0Y4cJWbSvh0EvAgFU+3EVqsFYw+tqOmIjwsoatiVO4cd4kGbPQh2KKhx3H+B0TapsL+aSoft0r4DVNQ3YgsTBIIDK9Pt26SwPesH8u5dD0MiuFTFnP097/0jGHQ9q2AlG346iCXWgIB+WfsI4dLiaWiCmupEefvf1dlIZzdevmIAKX48l59x90PRs3qwRnPN+qKFzsI+SMUqrXg= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(36860700004)(46966006)(40470700004); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2024 10:02:22.7339 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 283c1901-d22e-4c84-85eb-08dc32c432f0 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D2.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8948 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In mlx5 PMD, handles to indirect connection tracking flow actions are encoded in 32-bit unsigned integers as follows: - Bits 31-29 - indirect action type. - Bits 28-25 - port on which connection tracking action was created. - Bits 24-0 - index of connection tracking object. Macro defining a bit shift for owner part in this representation was incorrectly defined as 22. This patch fixes that, as well as aligns documented limitations. Fixes: 463170a7c934 ("net/mlx5: support connection tracking with HWS") Fixes: 48fbb0e93d06 ("net/mlx5: support flow meter mark indirect action with HWS") Cc: stable@dpdk.org Signed-off-by: Dariusz Sosnowski Acked-by: Ori Kam --- doc/guides/nics/mlx5.rst | 4 ++-- drivers/net/mlx5/mlx5_flow.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) -- 2.25.1 diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index fa013b03bb..b78753696a 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc/guides/nics/mlx5.rst @@ -739,8 +739,8 @@ Limitations - Cannot co-exist with ASO meter, ASO age action in a single flow rule. - Flow rules insertion rate and memory consumption need more optimization. - - 256 ports maximum. - - 4M connections maximum with ``dv_flow_en`` 1 mode. 16M with ``dv_flow_en`` 2. + - 16 ports maximum. + - 32M connections maximum. - Multi-thread flow insertion: diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h index a4d0ff7b13..b4bf96cd64 100644 --- a/drivers/net/mlx5/mlx5_flow.h +++ b/drivers/net/mlx5/mlx5_flow.h @@ -77,7 +77,7 @@ enum mlx5_indirect_type { /* Now, the maximal ports will be supported is 16, action number is 32M. */ #define MLX5_INDIRECT_ACT_CT_MAX_PORT 0x10 -#define MLX5_INDIRECT_ACT_CT_OWNER_SHIFT 22 +#define MLX5_INDIRECT_ACT_CT_OWNER_SHIFT 25 #define MLX5_INDIRECT_ACT_CT_OWNER_MASK (MLX5_INDIRECT_ACT_CT_MAX_PORT - 1) /* 29-31: type, 25-28: owner port, 0-24: index */