doc: deprecate graph data structures
Checks
Commit Message
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
Deprecate rte_node, rte_node_register and rte_graph_cluster_node_stats
structures as will be extended to include node specific error counters
and error description.
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
doc/guides/rel_notes/deprecation.rst | 5 +++++
1 file changed, 5 insertions(+)
Comments
On Wed, Feb 21, 2024 at 9:43 PM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Deprecate rte_node, rte_node_register and rte_graph_cluster_node_stats
> structures as will be extended to include node specific error counters
> and error description.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Implementation patches for 24.11 at
https://patches.dpdk.org/project/dpdk/list/?series=31181.
The deprecation notice looks good to me.
Acked-by: Jerin Jacob <jerinj@marvell.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 10630ba255..b3dfd06ed6 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -142,3 +142,8 @@ Deprecation Notices
> will be deprecated and subsequently removed in DPDK 24.11 release.
> Before this, the new port library API (functions rte_swx_port_*)
> will gradually transition from experimental to stable status.
> +
> +* graph: The graph library data structures will be modified to
> + support node specific errors, the structures ``rte_node``,
> + ``rte_node_register`` and ``rte_graph_cluster_node_stats`` will be
> + extended to include node error counters and error description.
> --
> 2.25.1
>
Acked-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
On Wed, Feb 21, 2024 at 9:50 PM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Deprecate rte_node, rte_node_register and rte_graph_cluster_node_stats
> structures as will be extended to include node specific error counters
> and error description.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 10630ba255..b3dfd06ed6 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -142,3 +142,8 @@ Deprecation Notices
> will be deprecated and subsequently removed in DPDK 24.11 release.
> Before this, the new port library API (functions rte_swx_port_*)
> will gradually transition from experimental to stable status.
> +
> +* graph: The graph library data structures will be modified to
> + support node specific errors, the structures ``rte_node``,
> + ``rte_node_register`` and ``rte_graph_cluster_node_stats`` will be
> + extended to include node error counters and error description.
> --
> 2.25.1
>
On Tue, 19 Mar 2024 08:52:13 +0530
Jerin Jacob <jerinjacobk@gmail.com> wrote:
> On Wed, Feb 21, 2024 at 9:43 PM <pbhagavatula@marvell.com> wrote:
> >
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > Deprecate rte_node, rte_node_register and rte_graph_cluster_node_stats
> > structures as will be extended to include node specific error counters
> > and error description.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Implementation patches for 24.11 at
> https://patches.dpdk.org/project/dpdk/list/?series=31181.
> The deprecation notice looks good to me.
>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
Can more of the internals be private to the library to avoid future changes.
Acked-by: Zhirun Yan <zhirun.yan@intel.com>
> -----Original Message-----
> From: Nithin Dabilpuram <nithind1988@gmail.com>
> Sent: Tuesday, March 19, 2024 1:21 PM
> To: pbhagavatula@marvell.com
> Cc: jerinj@marvell.com; ndabilpuram@marvell.com; kirankumark@marvell.com;
> Yan, Zhirun <zhirun.yan@intel.com>; dev@dpdk.org
> Subject: Re: [PATCH] doc: deprecate graph data structures
>
> Acked-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
>
> On Wed, Feb 21, 2024 at 9:50 PM <pbhagavatula@marvell.com> wrote:
> >
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > Deprecate rte_node, rte_node_register and rte_graph_cluster_node_stats
> > structures as will be extended to include node specific error counters
> > and error description.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > ---
> > doc/guides/rel_notes/deprecation.rst | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> > b/doc/guides/rel_notes/deprecation.rst
> > index 10630ba255..b3dfd06ed6 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -142,3 +142,8 @@ Deprecation Notices
> > will be deprecated and subsequently removed in DPDK 24.11 release.
> > Before this, the new port library API (functions rte_swx_port_*)
> > will gradually transition from experimental to stable status.
> > +
> > +* graph: The graph library data structures will be modified to
> > + support node specific errors, the structures ``rte_node``,
> > + ``rte_node_register`` and ``rte_graph_cluster_node_stats`` will be
> > + extended to include node error counters and error description.
> > --
> > 2.25.1
> >
> On Tue, 19 Mar 2024 08:52:13 +0530
> Jerin Jacob <jerinjacobk@gmail.com> wrote:
>
> > On Wed, Feb 21, 2024 at 9:43 PM <pbhagavatula@marvell.com> wrote:
> > >
> > > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > >
> > > Deprecate rte_node, rte_node_register and rte_graph_cluster_node_stats
> > > structures as will be extended to include node specific error counters
> > > and error description.
> > >
> > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > Implementation patches for 24.11 at
> > https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__patches.dpdk.org_project_dpdk_list_-3Fseries-
> 3D31181&d=DwIFaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=E3SgYMjtKCMVsB-
> fmvgGV3o-g_fjLhk5Pupi9ijohpc&m=UWUO-
> vO43HDzAb_QlsOvuvJsc8rbmtFAcsB6Hgzhjaumo01L-
> tlXha8dw_qPzxMO&s=FKKIPKTNhxdMKJf9M4Gma8F4783JsEFR512A7hfeQp
> g&e= .
> > The deprecation notice looks good to me.
> >
> > Acked-by: Jerin Jacob <jerinj@marvell.com>
>
> Can more of the internals be private to the library to avoid future changes.
These structures are all used in fastpath i.e., inline functions so, unfortunately
cant be made private.
@@ -142,3 +142,8 @@ Deprecation Notices
will be deprecated and subsequently removed in DPDK 24.11 release.
Before this, the new port library API (functions rte_swx_port_*)
will gradually transition from experimental to stable status.
+
+* graph: The graph library data structures will be modified to
+ support node specific errors, the structures ``rte_node``,
+ ``rte_node_register`` and ``rte_graph_cluster_node_stats`` will be
+ extended to include node error counters and error description.