[v1] dts: fix smoke tests driver regex

Message ID 20240223083001.63167-1-juraj.linkes@pantheon.tech (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v1] dts: fix smoke tests driver regex |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/github-robot: build success github build: passed
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-sample-apps-testing success Testing PASS

Commit Message

Juraj Linkeš Feb. 23, 2024, 8:30 a.m. UTC
  Add hyphen to the regex, which is needed for drivers such as vfio-pci.

Fixes: 88489c0501af ("dts: add smoke tests")
Cc: jspewock@iol.unh.edu
Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
 dts/tests/TestSuite_smoke_tests.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Jeremy Spewock Feb. 26, 2024, 2:20 p.m. UTC | #1
Reviewed-by: Jeremy Spewock <jspewock@iol.unh.edu>
  
Nicholas Pratte Feb. 29, 2024, 6:13 p.m. UTC | #2
Tested-by: Nicholas Pratte <npratte@iol.unh.edu>

>
> Add hyphen to the regex, which is needed for drivers such as vfio-pci.
>
> Fixes: 88489c0501af ("dts: add smoke tests")
> Cc: jspewock@iol.unh.edu
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---
>  dts/tests/TestSuite_smoke_tests.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dts/tests/TestSuite_smoke_tests.py b/dts/tests/TestSuite_smoke_tests.py
> index 5e2bac14bd..1be5c3047e 100644
> --- a/dts/tests/TestSuite_smoke_tests.py
> +++ b/dts/tests/TestSuite_smoke_tests.py
> @@ -130,7 +130,7 @@ def test_device_bound_to_driver(self) -> None:
>              # with the address for the nic we are on in the loop and then captures the
>              # name of the driver in a group
>              devbind_info_for_nic = re.search(
> -                f"{nic.pci}[^\\n]*drv=([\\d\\w]*) [^\\n]*",
> +                f"{nic.pci}[^\\n]*drv=([\\d\\w-]*) [^\\n]*",
>                  all_nics_in_dpdk_devbind,
>              )
>              self.verify(
> --
> 2.34.1
>
>
>
  
Thomas Monjalon March 7, 2024, 9:47 a.m. UTC | #3
23/02/2024 09:30, Juraj Linkeš:
> Add hyphen to the regex, which is needed for drivers such as vfio-pci.
> 
> Fixes: 88489c0501af ("dts: add smoke tests")
> Cc: jspewock@iol.unh.edu
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
Reviewed-by: Jeremy Spewock <jspewock@iol.unh.edu>
Tested-by: Nicholas Pratte <npratte@iol.unh.edu>

Applied, thanks.
  

Patch

diff --git a/dts/tests/TestSuite_smoke_tests.py b/dts/tests/TestSuite_smoke_tests.py
index 5e2bac14bd..1be5c3047e 100644
--- a/dts/tests/TestSuite_smoke_tests.py
+++ b/dts/tests/TestSuite_smoke_tests.py
@@ -130,7 +130,7 @@  def test_device_bound_to_driver(self) -> None:
             # with the address for the nic we are on in the loop and then captures the
             # name of the driver in a group
             devbind_info_for_nic = re.search(
-                f"{nic.pci}[^\\n]*drv=([\\d\\w]*) [^\\n]*",
+                f"{nic.pci}[^\\n]*drv=([\\d\\w-]*) [^\\n]*",
                 all_nics_in_dpdk_devbind,
             )
             self.verify(