diff mbox series

dumpcap: correctly disable promiscuous mode at exit

Message ID 20240227092326.340229-1-iboukris@gmail.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series dumpcap: correctly disable promiscuous mode at exit |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS

Commit Message

Isaac Boukris Feb. 27, 2024, 9:23 a.m. UTC 
  Signed-off-by: Isaac Boukris <iboukris@gmail.com>
---
 app/dumpcap/main.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Stephen Hemminger Feb. 27, 2024, 6:07 p.m. UTC | #1 
On Tue, 27 Feb 2024 11:23:26 +0200
Isaac Boukris <iboukris@gmail.com> wrote:

> Signed-off-by: Isaac Boukris <iboukris@gmail.com>
> ---
>  app/dumpcap/main.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c
> index d57db0589a..88cec43086 100644
> --- a/app/dumpcap/main.c
> +++ b/app/dumpcap/main.c
> @@ -830,11 +830,12 @@ static void enable_pdump(struct rte_ring *r, struct rte_mempool *mp)
>  				intf->opts.promisc_mode = false;
>  			} else {
>  				ret = rte_eth_promiscuous_enable(intf->port);
> -				if (ret != 0)
> +				if (ret != 0) {
>  					fprintf(stderr,
>  						"port %u set promiscuous enable failed: %d\n",
>  						intf->port, ret);
> -				intf->opts.promisc_mode = false;
> +					intf->opts.promisc_mode = false;
> +				}
>  			}
>  		}
>  		++count;

Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
Thomas Monjalon March 6, 2024, 9:45 p.m. UTC | #2 
27/02/2024 19:07, Stephen Hemminger:
> On Tue, 27 Feb 2024 11:23:26 +0200
> Isaac Boukris <iboukris@gmail.com> wrote:
> 
> > Signed-off-by: Isaac Boukris <iboukris@gmail.com>
> 
> Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>

Please could you help providing a message for the commit log?
diff mbox series

Patch

diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c
index d57db0589a..88cec43086 100644
--- a/app/dumpcap/main.c
+++ b/app/dumpcap/main.c
@@ -830,11 +830,12 @@  static void enable_pdump(struct rte_ring *r, struct rte_mempool *mp)
 				intf->opts.promisc_mode = false;
 			} else {
 				ret = rte_eth_promiscuous_enable(intf->port);
-				if (ret != 0)
+				if (ret != 0) {
 					fprintf(stderr,
 						"port %u set promiscuous enable failed: %d\n",
 						intf->port, ret);
-				intf->opts.promisc_mode = false;
+					intf->opts.promisc_mode = false;
+				}
 			}
 		}
 		++count;