diff mbox series

[v5,3/3] common/qat: fix incorrectly placed legacy flag

Message ID 20240301155251.5101-3-arkadiuszx.kusztal@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series [v5,1/3] common/qat: isolate parser arguments configuration |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation warning apply issues

Commit Message

Arkadiusz Kusztal March 1, 2024, 3:52 p.m. UTC 
  This commit fixes a legacy flag, which was placed in a file
that may not be included in a building process.

Fixes: cffb726b7797 ("crypto/qat: enable insecure algorithms")

Signed-off-by: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>
---
 drivers/common/qat/qat_device.c | 1 +
 drivers/crypto/qat/qat_sym.c    | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

Comments

Brian Dooley March 1, 2024, 4:08 p.m. UTC | #1 
> -----Original Message-----
> From: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>
> Sent: Friday, March 1, 2024 3:53 PM
> To: dev@dpdk.org
> Cc: gakhil@marvell.com; Power, Ciara <ciara.power@intel.com>; Kusztal,
> ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH v5 3/3] common/qat: fix incorrectly placed legacy flag
> 
> This commit fixes a legacy flag, which was placed in a file that may not be
> included in a building process.
> 
> Fixes: cffb726b7797 ("crypto/qat: enable insecure algorithms")
> 
> Signed-off-by: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>
> ---
>  drivers/common/qat/qat_device.c | 1 +
>  drivers/crypto/qat/qat_sym.c    | 1 -
>  2 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/common/qat/qat_device.c
> b/drivers/common/qat/qat_device.c index a27252ea4d..500ca0f308 100644
> --- a/drivers/common/qat/qat_device.c
> +++ b/drivers/common/qat/qat_device.c
> @@ -31,6 +31,7 @@ struct qat_service qat_service[QAT_MAX_SERVICES];
>  /* per-process array of device data */
>  struct qat_device_info qat_pci_devs[RTE_PMD_QAT_MAX_PCI_DEVICES];
>  static int qat_nb_pci_devices;
> +int qat_legacy_capa;
> 
>  /*
>   * The set of PCI devices this driver supports diff --git
> a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c index
> efca8f3ba1..6c7b1724ef 100644
> --- a/drivers/crypto/qat/qat_sym.c
> +++ b/drivers/crypto/qat/qat_sym.c
> @@ -19,7 +19,6 @@
>  #include "qat_qp.h"
> 
>  uint8_t qat_sym_driver_id;
> -int qat_legacy_capa;
> 
>  #define SYM_ENQ_THRESHOLD_NAME "qat_sym_enq_threshold"
>  #define SYM_CIPHER_CRC_ENABLE_NAME "qat_sym_cipher_crc_enable"
> --
> 2.13.6

Acked-by: Brian Dooley <brian.dooley@intel.com>
Akhil Goyal March 4, 2024, 7:10 a.m. UTC | #2 
> > Subject: [PATCH v5 3/3] common/qat: fix incorrectly placed legacy flag
> >
> > This commit fixes a legacy flag, which was placed in a file that may not be
> > included in a building process.
> >
> > Fixes: cffb726b7797 ("crypto/qat: enable insecure algorithms")
> >
> > Signed-off-by: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>
Cc: stable@dpdk.org

Series Applied to dpdk-next-crypto
diff mbox series

Patch

diff --git a/drivers/common/qat/qat_device.c b/drivers/common/qat/qat_device.c
index a27252ea4d..500ca0f308 100644
--- a/drivers/common/qat/qat_device.c
+++ b/drivers/common/qat/qat_device.c
@@ -31,6 +31,7 @@  struct qat_service qat_service[QAT_MAX_SERVICES];
 /* per-process array of device data */
 struct qat_device_info qat_pci_devs[RTE_PMD_QAT_MAX_PCI_DEVICES];
 static int qat_nb_pci_devices;
+int qat_legacy_capa;
 
 /*
  * The set of PCI devices this driver supports
diff --git a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c
index efca8f3ba1..6c7b1724ef 100644
--- a/drivers/crypto/qat/qat_sym.c
+++ b/drivers/crypto/qat/qat_sym.c
@@ -19,7 +19,6 @@ 
 #include "qat_qp.h"
 
 uint8_t qat_sym_driver_id;
-int qat_legacy_capa;
 
 #define SYM_ENQ_THRESHOLD_NAME "qat_sym_enq_threshold"
 #define SYM_CIPHER_CRC_ENABLE_NAME "qat_sym_cipher_crc_enable"