diff mbox series

common/cnxk: fix loopback port dataflow issue

Message ID 20240304123335.1769854-1-rbhansali@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series common/cnxk: fix loopback port dataflow issue |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-sample-apps-testing success Testing PASS

Commit Message

Rahul Bhansali March 4, 2024, 12:33 p.m. UTC 
  With loopback interface and IPsec Inbound traffic, getting
NIX_CQERRINT_CPT_DROP interrupt and dataflow is stopped.
This is due to flow control configuration is skipped as
roc_nix_is_esw() returns true for loopback device also.

Fixes: 978dc3a13f7b ("common/cnxk: base support for eswitch VF")
Fixes: f812768a9e66 ("net/cnxk: support eswitch VF as ethernet device")

Signed-off-by: Rahul Bhansali <rbhansali@marvell.com>
---
 drivers/common/cnxk/roc_nix.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Jerin Jacob March 4, 2024, 4:35 p.m. UTC | #1 
On Mon, Mar 4, 2024 at 6:10 PM Rahul Bhansali <rbhansali@marvell.com> wrote:
>
> With loopback interface and IPsec Inbound traffic, getting
> NIX_CQERRINT_CPT_DROP interrupt and dataflow is stopped.
> This is due to flow control configuration is skipped as
> roc_nix_is_esw() returns true for loopback device also.
>
> Fixes: 978dc3a13f7b ("common/cnxk: base support for eswitch VF")
> Fixes: f812768a9e66 ("net/cnxk: support eswitch VF as ethernet device")
>
> Signed-off-by: Rahul Bhansali <rbhansali@marvell.com>

Applied to dpdk-next-net-mrvl/for-main. Thanks


> ---
>  drivers/common/cnxk/roc_nix.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/common/cnxk/roc_nix.c b/drivers/common/cnxk/roc_nix.c
> index 20202788b5..041621dfaa 100644
> --- a/drivers/common/cnxk/roc_nix.c
> +++ b/drivers/common/cnxk/roc_nix.c
> @@ -385,8 +385,9 @@ sdp_lbk_id_update(struct plt_pci_device *pci_dev, struct nix *nix)
>                 nix->sdp_link = true;
>                 break;
>         case PCI_DEVID_CNXK_RVU_AF_VF:
> -       case PCI_DEVID_CNXK_RVU_ESWITCH_VF:
>                 nix->lbk_link = true;
> +               break;
> +       case PCI_DEVID_CNXK_RVU_ESWITCH_VF:
>                 nix->esw_link = true;
>                 break;
>         default:
> --
> 2.25.1
>
diff mbox series

Patch

diff --git a/drivers/common/cnxk/roc_nix.c b/drivers/common/cnxk/roc_nix.c
index 20202788b5..041621dfaa 100644
--- a/drivers/common/cnxk/roc_nix.c
+++ b/drivers/common/cnxk/roc_nix.c
@@ -385,8 +385,9 @@  sdp_lbk_id_update(struct plt_pci_device *pci_dev, struct nix *nix)
 		nix->sdp_link = true;
 		break;
 	case PCI_DEVID_CNXK_RVU_AF_VF:
-	case PCI_DEVID_CNXK_RVU_ESWITCH_VF:
 		nix->lbk_link = true;
+		break;
+	case PCI_DEVID_CNXK_RVU_ESWITCH_VF:
 		nix->esw_link = true;
 		break;
 	default: