net/mlx5: prevent ioctl failure log from flood
Checks
Commit Message
From: Eli Britstein <elibr@nvidia.com>
The following log is printed in WARNING severity:
mlx5_net: port 1 ioctl(SIOCETHTOOL, ETHTOOL_GPAUSEPARAM) failed:
Operation not supported
Reduce the severity to DEBUG to prevent this log from flooding
when there are hundreds of ports probed without supporting this
flow ctrl query.
Fixes: 1256805dd54d ("net/mlx5: move Linux-specific functions")
Cc: ophirmu@nvidia.com
Cc: stable@dpdk.org
Signed-off-by: Eli Britstein <elibr@nvidia.com>
---
drivers/net/mlx5/linux/mlx5_ethdev_os.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
> -----Original Message-----
> From: Bing Zhao <bingz@nvidia.com>
> Sent: Thursday, March 7, 2024 8:14 AM
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; dev@dpdk.org; Raslan
> Darawsheh <rasland@nvidia.com>
> Cc: Ori Kam <orika@nvidia.com>; Dariusz Sosnowski
> <dsosnowski@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; Matan
> Azrad <matan@nvidia.com>; Eli Britstein <elibr@nvidia.com>; Ophir Munk
> <ophirmu@nvidia.com>; stable@dpdk.org
> Subject: [PATCH] net/mlx5: prevent ioctl failure log from flood
>
> From: Eli Britstein <elibr@nvidia.com>
>
> The following log is printed in WARNING severity:
>
> mlx5_net: port 1 ioctl(SIOCETHTOOL, ETHTOOL_GPAUSEPARAM) failed:
> Operation not supported
>
> Reduce the severity to DEBUG to prevent this log from flooding when there are
> hundreds of ports probed without supporting this flow ctrl query.
>
> Fixes: 1256805dd54d ("net/mlx5: move Linux-specific functions")
> Cc: ophirmu@nvidia.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Eli Britstein <elibr@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Hi,
> -----Original Message-----
> From: Bing Zhao <bingz@nvidia.com>
> Sent: Thursday, March 7, 2024 8:14 AM
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; dev@dpdk.org; Raslan
> Darawsheh <rasland@nvidia.com>
> Cc: Ori Kam <orika@nvidia.com>; Dariusz Sosnowski
> <dsosnowski@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>;
> Matan Azrad <matan@nvidia.com>; Eli Britstein <elibr@nvidia.com>; Ophir
> Munk <ophirmu@nvidia.com>; stable@dpdk.org
> Subject: [PATCH] net/mlx5: prevent ioctl failure log from flood
>
> From: Eli Britstein <elibr@nvidia.com>
>
> The following log is printed in WARNING severity:
>
> mlx5_net: port 1 ioctl(SIOCETHTOOL, ETHTOOL_GPAUSEPARAM) failed:
> Operation not supported
>
> Reduce the severity to DEBUG to prevent this log from flooding when there
> are hundreds of ports probed without supporting this flow ctrl query.
>
> Fixes: 1256805dd54d ("net/mlx5: move Linux-specific functions")
> Cc: ophirmu@nvidia.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Eli Britstein <elibr@nvidia.com>
Patch applied to next-net-mlx,
Kindest regards
Raslan Darawsheh
@@ -671,7 +671,7 @@ mlx5_dev_get_flow_ctrl(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
ifr.ifr_data = (void *)ðpause;
ret = mlx5_ifreq(dev, SIOCETHTOOL, &ifr);
if (ret) {
- DRV_LOG(WARNING,
+ DRV_LOG(DEBUG,
"port %u ioctl(SIOCETHTOOL, ETHTOOL_GPAUSEPARAM) failed:"
" %s",
dev->data->port_id, strerror(rte_errno));