From patchwork Fri Mar 8 14:48:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 138124 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86DE243B67; Fri, 8 Mar 2024 15:48:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 746D9432F2; Fri, 8 Mar 2024 15:48:53 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id AAAC740E2D for ; Fri, 8 Mar 2024 15:48:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709909332; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=izF5FguJz8IzkT3et00SaslKe+mwGw76N3u8PW1n6Q0=; b=X0T0xJzNgS8rXUDedERHKlNhyaP3s4F70yIbrIbrCjiLWrpdrkrH5TmzStI8us6GZZuHQB QUQY3WqQ/FdcM/FdXXMmjfXSiQQ7Y1jRLf7R9jqaGQF0VDfe34F3gnLS28eRUpKJ1Lhbwy X2iO5+E3v4WbFCeWOaWXbKdGykQEkjk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-38-EJH4SNO1OIO7RgVl_T3N9Q-1; Fri, 08 Mar 2024 09:48:49 -0500 X-MC-Unique: EJH4SNO1OIO7RgVl_T3N9Q-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A1D138007A3; Fri, 8 Mar 2024 14:48:48 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.225.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id 777BA2166B33; Fri, 8 Mar 2024 14:48:47 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: stable@dpdk.org, Aman Singh , Yuying Zhang , Pablo de Lara , Jingjing Wu Subject: [PATCH 1/4] app/testpmd: fix stats-period option check Date: Fri, 8 Mar 2024 15:48:38 +0100 Message-ID: <20240308144841.3615262-2-david.marchand@redhat.com> In-Reply-To: <20240308144841.3615262-1-david.marchand@redhat.com> References: <20240308144841.3615262-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Rather than silently ignore an invalid value, raise an error for stats-period user input. Fixes: cfea1f3048d1 ("app/testpmd: print statistics periodically") Cc: stable@dpdk.org Signed-off-by: David Marchand Acked-by: Ferruh Yigit --- app/test-pmd/parameters.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index 11b0cce577..d715750bb8 100644 --- a/app/test-pmd/parameters.c +++ b/app/test-pmd/parameters.c @@ -776,7 +776,7 @@ launch_args_parse(int argc, char** argv) n = strtoul(optarg, &end, 10); if ((optarg[0] == '\0') || (end == NULL) || (*end != '\0')) - break; + rte_exit(EXIT_FAILURE, "Invalid stats-period value\n"); stats_period = n; break;