From patchwork Fri Mar 8 14:48:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 138126 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E24143B67; Fri, 8 Mar 2024 15:49:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB39F4338E; Fri, 8 Mar 2024 15:49:00 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 86A5840E2D for ; Fri, 8 Mar 2024 15:48:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709909337; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JExYYlMdlUSzbfsxB6n1b0XdYiSoOiwUHkFynHKIl+Y=; b=FUIAwKI4rxN6L2MbAy+KrqELzMxDR9xr6v4npERZwVrJIvNfbRR8L4seYSAxu1i94aKG/A yZDgaNwoT9hindDBM6oqhwcunkXfz1CkbAr8lp9wzbgfwtJeSahq7hSgzmIc/PrBNiUi3M DLhHoeIMld1Z5ZAruWxo498dWIGJx3I= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-78-WpWJUJIwM0K7fr_maeXeIw-1; Fri, 08 Mar 2024 09:48:55 -0500 X-MC-Unique: WpWJUJIwM0K7fr_maeXeIw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4E450101CF85; Fri, 8 Mar 2024 14:48:55 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.225.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8EB7B40C6CBF; Fri, 8 Mar 2024 14:48:54 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: Aman Singh , Yuying Zhang Subject: [PATCH 3/4] app/testpmd: check queue count for related options Date: Fri, 8 Mar 2024 15:48:40 +0100 Message-ID: <20240308144841.3615262-4-david.marchand@redhat.com> In-Reply-To: <20240308144841.3615262-1-david.marchand@redhat.com> References: <20240308144841.3615262-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Checking the number of rxq/txq in the middle of option parsing is confusing. Move the check where nb_rxq / nb_txq are modified. Signed-off-by: David Marchand --- app/test-pmd/parameters.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index 8c21744009..271f0c995a 100644 --- a/app/test-pmd/parameters.c +++ b/app/test-pmd/parameters.c @@ -1063,6 +1063,8 @@ launch_args_parse(int argc, char** argv) rte_exit(EXIT_FAILURE, "rxq %d invalid - must be" " >= 0 && <= %u\n", n, get_allowed_max_nb_rxq(&pid)); + if (!nb_rxq && !nb_txq) + rte_exit(EXIT_FAILURE, "Either rx or tx queues should be non-zero\n"); } if (!strcmp(lgopts[opt_idx].name, "txq")) { n = atoi(optarg); @@ -1072,6 +1074,8 @@ launch_args_parse(int argc, char** argv) rte_exit(EXIT_FAILURE, "txq %d invalid - must be" " >= 0 && <= %u\n", n, get_allowed_max_nb_txq(&pid)); + if (!nb_rxq && !nb_txq) + rte_exit(EXIT_FAILURE, "Either rx or tx queues should be non-zero\n"); } if (!strcmp(lgopts[opt_idx].name, "hairpinq")) { n = atoi(optarg); @@ -1098,10 +1102,6 @@ launch_args_parse(int argc, char** argv) n + nb_rxq, get_allowed_max_nb_rxq(&pid)); } - if (!nb_rxq && !nb_txq) { - rte_exit(EXIT_FAILURE, "Either rx or tx queues should " - "be non-zero\n"); - } if (!strcmp(lgopts[opt_idx].name, "hairpin-mode")) { char *end = NULL; unsigned int n;