From patchwork Thu Mar 14 09:17:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 138368 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8AB0243CB2; Thu, 14 Mar 2024 10:17:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 33E4C42E75; Thu, 14 Mar 2024 10:17:33 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7F73942E5C for ; Thu, 14 Mar 2024 10:17:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710407851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2TdlOofA2p+MeWwk5ntnmBB256rQfEQw1vqMqu762mU=; b=ZH2/uDMiCQBnCzGe3xIN8KPXxyW64yky1cWwqXPtp5AVSQBKLJnq6VudRvV+RESF4dBMbh B5AqVIaDOQ3FyoVU4a+mPTMwdl5yNT+ZQ4Ng8xjOzxotmYpj7eu7DO+bgTNrBkzTT4GEbZ IqP/ROsQSGTNeoCsBird5MHS/keZYDQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-686-P7QU9OQ7N46WvylJPzkfQA-1; Thu, 14 Mar 2024 05:17:22 -0400 X-MC-Unique: P7QU9OQ7N46WvylJPzkfQA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 919A7851783; Thu, 14 Mar 2024 09:17:21 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.225.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id AE2342166B4F; Thu, 14 Mar 2024 09:17:19 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: stable@dpdk.org, Aman Singh , Yuying Zhang , Bernard Iremonger , Andrew Rybchenko , Ivan Ilchenko Subject: [PATCH v2 2/6] app/testpmd: fix burst option parsing Date: Thu, 14 Mar 2024 10:17:03 +0100 Message-ID: <20240314091708.1542769-3-david.marchand@redhat.com> In-Reply-To: <20240314091708.1542769-1-david.marchand@redhat.com> References: <20240308144841.3615262-1-david.marchand@redhat.com> <20240314091708.1542769-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org rte_eth_dev_info_get() is not supposed to fail for a valid port_id, but for the theoretical case when it would fail, raise an error rather than skip subsequent options. Fixes: 6f51deb903b2 ("app/testpmd: check status of getting ethdev info") Cc: stable@dpdk.org Signed-off-by: David Marchand Acked-by: Ferruh Yigit --- Changes since v1: - switched to a dedicated error message, --- app/test-pmd/parameters.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index d715750bb8..3414a0d38c 100644 --- a/app/test-pmd/parameters.c +++ b/app/test-pmd/parameters.c @@ -1128,7 +1128,9 @@ launch_args_parse(int argc, char** argv) 0, &dev_info); if (ret != 0) - return; + rte_exit(EXIT_FAILURE, "Failed to get driver " + "recommended burst size, please provide a " + "value between 1 and %d\n", MAX_PKT_BURST); rec_nb_pkts = dev_info .default_rxportconf.burst_size;