From patchwork Thu Mar 14 09:17:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 138367 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67A1443CB2; Thu, 14 Mar 2024 10:17:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C9E3442E6A; Thu, 14 Mar 2024 10:17:31 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 13BBF42E62 for ; Thu, 14 Mar 2024 10:17:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710407849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5osJIglxlv+2JBjL59M7DN3gmxYf0EIJUxx+Ps8jgXQ=; b=YNPK6eHZy1PL1BT/HqdJg+EgxteYWbH7gi6bCVFXj+Tt+fyb0VUDqUh1gWurifiCTTM1cX M5OxE0X7iHQu/E/WZjP9GkKMloAex5fXF7Hh85zcewxEV7Yp1T7BquZjSQdAhbuTVbbQeZ 8jk7SWC61HDOWNUFGw+OhPh66MOsO4Y= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-54-eYsierN9MzuueXcJ7B0C1Q-1; Thu, 14 Mar 2024 05:17:25 -0400 X-MC-Unique: eYsierN9MzuueXcJ7B0C1Q-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AF54838035AF; Thu, 14 Mar 2024 09:17:24 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.225.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id A6918492BD0; Thu, 14 Mar 2024 09:17:23 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: stable@dpdk.org, Aman Singh , Yuying Zhang , Ferruh Yigit Subject: [PATCH v2 3/6] app/testpmd: fix error message for invalid option Date: Thu, 14 Mar 2024 10:17:04 +0100 Message-ID: <20240314091708.1542769-4-david.marchand@redhat.com> In-Reply-To: <20240314091708.1542769-1-david.marchand@redhat.com> References: <20240308144841.3615262-1-david.marchand@redhat.com> <20240314091708.1542769-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org """ The variable optind is the index of the next element to be processed in argv. The system initializes this value to 1. The caller can reset it to 1 to restart scanning of the same argv, or when scanning a new argument vector. """ Hence, if an invalid option is passed through testpmd cmdline, getopt returns '?' and increments optind to the next index in argv for a subsequent call. The message should log the previous index. Fixes: 8fad2e5ab2c5 ("app/testpmd: report invalid command line parameter") Cc: stable@dpdk.org Signed-off-by: David Marchand Acked-by: Ferruh Yigit --- app/test-pmd/parameters.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index 3414a0d38c..a4c09e2a2b 100644 --- a/app/test-pmd/parameters.c +++ b/app/test-pmd/parameters.c @@ -1497,7 +1497,7 @@ launch_args_parse(int argc, char** argv) break; default: usage(argv[0]); - fprintf(stderr, "Invalid option: %s\n", argv[optind]); + fprintf(stderr, "Invalid option: %s\n", argv[optind - 1]); rte_exit(EXIT_FAILURE, "Command line is incomplete or incorrect\n"); break;