diff mbox series

[01/13] net/mlx5/hws: move warn into debug level when needed

Message ID 20240314114220.203241-1-igozlan@nvidia.com (mailing list archive)
State New
Delegated to: Raslan Darawsheh
Headers
Series [01/13] net/mlx5/hws: move warn into debug level when needed |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Itamar Gozlan March 14, 2024, 11:42 a.m. UTC 
  From: Erez Shitrit <erezsh@nvidia.com>

When the user tries to create a matcher and if failed  with specific
errno (E2BIG) the message will be in debug level and not in warning.
It is a part of a feature when the user re-try to insert a new matching
depends on that errno, no need the annoying message.

Fixes: c55c2bf3533 ("net/mlx5/hws: net/mlx5/hws: add definer layer")

Signed-off-by: Erez Shitrit <erezsh@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
 drivers/net/mlx5/hws/mlx5dr_definer.c | 6 +++---
 drivers/net/mlx5/hws/mlx5dr_matcher.c | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

Comments

Raslan Darawsheh March 18, 2024, 12:56 p.m. UTC | #1 
Hi,

> -----Original Message-----
> From: Itamar Gozlan <igozlan@nvidia.com>
> Sent: Thursday, March 14, 2024 1:42 PM
> To: Itamar Gozlan <igozlan@nvidia.com>; Erez Shitrit <erezsh@nvidia.com>;
> Hamdan Agbariya <hamdani@nvidia.com>; Yevgeny Kliteynik
> <kliteyn@nvidia.com>; Alex Vesker <valex@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; NBU-Contact-Thomas Monjalon (EXTERNAL)
> <thomas@monjalon.net>; Dariusz Sosnowski <dsosnowski@nvidia.com>; Ori
> Kam <orika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; Matan
> Azrad <matan@nvidia.com>; Mark Bloch <mbloch@nvidia.com>
> Cc: dev@dpdk.org; Maayan Kashani <mkashani@nvidia.com>
> Subject: [PATCH 01/13] net/mlx5/hws: move warn into debug level when
> needed
> 
> From: Erez Shitrit <erezsh@nvidia.com>
> 
> When the user tries to create a matcher and if failed  with specific errno
> (E2BIG) the message will be in debug level and not in warning.
> It is a part of a feature when the user re-try to insert a new matching depends
> on that errno, no need the annoying message.
> 
> Fixes: c55c2bf3533 ("net/mlx5/hws: net/mlx5/hws: add definer layer")
> 
> Signed-off-by: Erez Shitrit <erezsh@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
Fixed Cc stable on several patches on this series, and reworded the commits
Series applied to next-net-mlx,

Kindest regards
Raslan Darawsheh
Thomas Monjalon March 18, 2024, 2:48 p.m. UTC | #2 
18/03/2024 13:56, Raslan Darawsheh:
> From: Itamar Gozlan <igozlan@nvidia.com>
> > From: Erez Shitrit <erezsh@nvidia.com>
> > 
> > When the user tries to create a matcher and if failed  with specific errno
> > (E2BIG) the message will be in debug level and not in warning.
> > It is a part of a feature when the user re-try to insert a new matching depends
> > on that errno, no need the annoying message.
> > 
> > Fixes: c55c2bf3533 ("net/mlx5/hws: net/mlx5/hws: add definer layer")
> > 
> > Signed-off-by: Erez Shitrit <erezsh@nvidia.com>
> > Acked-by: Matan Azrad <matan@nvidia.com>
> Fixed Cc stable on several patches on this series, and reworded the commits
> Series applied to next-net-mlx,

There is no cover letter for this series,
so we are not able to understand how critical it is,
and what is the general intent.

Is it supposed to be integrated in the last week of 24.03 release cycle?
Raslan Darawsheh March 19, 2024, 7:33 a.m. UTC | #3 
Hi,

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, March 18, 2024 4:49 PM
> To: Itamar Gozlan <igozlan@nvidia.com>; Erez Shitrit <erezsh@nvidia.com>;
> Hamdan Agbariya <hamdani@nvidia.com>; Yevgeny Kliteynik
> <kliteyn@nvidia.com>; Alex Vesker <valex@nvidia.com>; Raslan Darawsheh
> <rasland@nvidia.com>
> Cc: Slava Ovsiienko <viacheslavo@nvidia.com>; Dariusz Sosnowski
> <dsosnowski@nvidia.com>; Ori Kam <orika@nvidia.com>; Suanming Mou
> <suanmingm@nvidia.com>; Matan Azrad <matan@nvidia.com>; Mark Bloch
> <mbloch@nvidia.com>; dev@dpdk.org; Maayan Kashani
> <mkashani@nvidia.com>
> Subject: Re: [PATCH 01/13] net/mlx5/hws: move warn into debug level when
> needed
> 
> 18/03/2024 13:56, Raslan Darawsheh:
> > From: Itamar Gozlan <igozlan@nvidia.com>
> > > From: Erez Shitrit <erezsh@nvidia.com>
> > >
> > > When the user tries to create a matcher and if failed  with specific
> > > errno
> > > (E2BIG) the message will be in debug level and not in warning.
> > > It is a part of a feature when the user re-try to insert a new
> > > matching depends on that errno, no need the annoying message.
> > >
> > > Fixes: c55c2bf3533 ("net/mlx5/hws: net/mlx5/hws: add definer layer")
> > >
> > > Signed-off-by: Erez Shitrit <erezsh@nvidia.com>
> > > Acked-by: Matan Azrad <matan@nvidia.com>
> > Fixed Cc stable on several patches on this series, and reworded the
> > commits Series applied to next-net-mlx,
> 
> There is no cover letter for this series, so we are not able to understand how
> critical it is, and what is the general intent.
> 
> Is it supposed to be integrated in the last week of 24.03 release cycle?
> 
No, it's not critical for RC4 It's my fault, I'll drop it for now and we'll merge it in the next release cycle only.

Kindest regards
Raslan Darawsheh
Yevgeny Kliteynik March 20, 2024, 4:35 p.m. UTC | #4 
On 19-Mar-24 09:33, Raslan Darawsheh wrote:
> Hi,
> 
>> -----Original Message-----
>> From: Thomas Monjalon <thomas@monjalon.net>
>>
>> 18/03/2024 13:56, Raslan Darawsheh:
>>> From: Itamar Gozlan <igozlan@nvidia.com>
>>
>> There is no cover letter for this series, so we are not able to understand how
>> critical it is, and what is the general intent.
>>
>> Is it supposed to be integrated in the last week of 24.03 release cycle?
>>
> No, it's not critical for RC4 It's my fault, I'll drop it for now and we'll merge it in the next release cycle only.

Actually, this series contain a bugfix for a show stopper bug:
   [DPDK Upstream - Bug SW #3808915] Seg fault on dequeue flow

The fix is in patch 10/13:
   [PATCH 10/13] net/mlx5/hws: fix rule is in resize check

-- YK

> Kindest regards
> Raslan Darawsheh
diff mbox series

Patch

diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c b/drivers/net/mlx5/hws/mlx5dr_definer.c
index 35a2ed2048..81d0e0e6df 100644
--- a/drivers/net/mlx5/hws/mlx5dr_definer.c
+++ b/drivers/net/mlx5/hws/mlx5dr_definer.c
@@ -3534,7 +3534,7 @@  mlx5dr_definer_find_best_match_fit(struct mlx5dr_context *ctx,
 		return 0;
 	}
 
-	DR_LOG(ERR, "Unable to find supporting match/jumbo definer combination");
+	DR_LOG(DEBUG, "Unable to find supporting match/jumbo definer combination");
 	rte_errno = E2BIG;
 	return rte_errno;
 }
@@ -3689,7 +3689,7 @@  mlx5dr_definer_calc_layout(struct mlx5dr_matcher *matcher,
 	/* Find the match definer layout for header layout match union */
 	ret = mlx5dr_definer_find_best_match_fit(ctx, match_definer, match_hl);
 	if (ret) {
-		DR_LOG(ERR, "Failed to create match definer from header layout");
+		DR_LOG(DEBUG, "Failed to create match definer from header layout");
 		goto free_fc;
 	}
 
@@ -4041,7 +4041,7 @@  int mlx5dr_definer_matcher_init(struct mlx5dr_context *ctx,
 
 	ret = mlx5dr_definer_calc_layout(matcher, &match_layout, &range_layout);
 	if (ret) {
-		DR_LOG(ERR, "Failed to calculate matcher definer layout");
+		DR_LOG(DEBUG, "Failed to calculate matcher definer layout");
 		return ret;
 	}
 
diff --git a/drivers/net/mlx5/hws/mlx5dr_matcher.c b/drivers/net/mlx5/hws/mlx5dr_matcher.c
index 1c64abfa57..1213e7f0ad 100644
--- a/drivers/net/mlx5/hws/mlx5dr_matcher.c
+++ b/drivers/net/mlx5/hws/mlx5dr_matcher.c
@@ -877,7 +877,7 @@  static int mlx5dr_matcher_bind_mt(struct mlx5dr_matcher *matcher)
 	/* Calculate match, range and hash definers */
 	ret = mlx5dr_definer_matcher_init(ctx, matcher);
 	if (ret) {
-		DR_LOG(ERR, "Failed to set matcher templates with match definers");
+		DR_LOG(DEBUG, "Failed to set matcher templates with match definers");
 		return ret;
 	}