From patchwork Fri Dec 1 06:51:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael McConville X-Patchwork-Id: 31855 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DB4A82B9E; Fri, 1 Dec 2017 07:51:18 +0100 (CET) Received: from mx.kolabnow.com (mx.kolabnow.com [95.128.36.40]) by dpdk.org (Postfix) with ESMTP id F0B982A62 for ; Fri, 1 Dec 2017 07:51:17 +0100 (CET) Received: from localhost (unknown [127.0.0.1]) by ext-mx-out003.mykolab.com (Postfix) with ESMTP id BFCF6404E1 for ; Fri, 1 Dec 2017 07:51:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mykolab.com; h= date:date:message-id:subject:subject:mime-version :content-transfer-encoding:content-type:content-type:from:from :received:received:received; s=dkim20160331; t=1512111077; x= 1512111099; bh=Tbc8IwrLFdWCHPheAqpiINOaSY97y+i+Lac12+5NsLg=; b=Z endCf+g16/lyfXwXz9U/35pOpHSguDeCYq45Gnbq1sQRMp7omrLhV9faamT8GbOJ zcWE2eUjCHwLfVOAVGq20Sy+7xuJb1+iqF1OQjPOyQo0llZ63qZqMQcuDJfYsr6Z pN3edkEIzL3KLrHy1tZrxu0tzmOOFiL2drF2Z0/P/8u56ALTLkujmehtoqGqmRJd xjMvyIH5ysT9JgMNAn22eq59+2IQSy/QDUygZJX14tdSJ2ZJExumBaPKs6I7rbMp xp+l1LqMPp8UHJJh2bZWGGZDpXPIUAlz3YOHVI2tQuEhNblB1BE/GoIjXDMXiLac tFL/Kiu6CFP29OiOQMYh7K3OI8n2sEW9f4sfd1o3xBVtFKrgw9m0Jd3LTM8J036s 08a5IPxolx7n6DTrDWqPCFPYe8UU+mBC7DEkfdqxEdan+w84i40wqySi9mambZ+h 6ZcDRgGIXWGnuYu4o6M9PWMCH6f3hHltfrzvX/8HjTRyHDgFzWcPDE6cLp0//nDz nVYKYoC3oGlotCTVBfYD3j4yMAZZ8Zla9qD+jY2nOOlftaTURh97mt1OeYbZulAO s6dqqidiazlP2v9F7Jp4808hjWDVdbGGNexanp4Q8sB93wHJkmo6F5CM3qWCRwEz 1tQMXNfBXRy6wcw6dso5hXS7O41gC3s3tGwMdlkQQw= X-Virus-Scanned: amavisd-new at mykolab.com X-Spam-Flag: NO X-Spam-Score: -0.92 X-Spam-Level: X-Spam-Status: No, score=-0.92 tagged_above=-10 required=4.5 tests=[ALL_TRUSTED=-1, AWL=0.079, FREEMAIL_FROM=0.001] autolearn=ham autolearn_force=no Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out003.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 63bBqwX1bpVJ for ; Fri, 1 Dec 2017 07:51:17 +0100 (CET) Received: from int-mx003.mykolab.com (unknown [10.9.13.3]) by ext-mx-out003.mykolab.com (Postfix) with ESMTPS id 3A609404DB for ; Fri, 1 Dec 2017 07:51:17 +0100 (CET) Received: from ext-subm002.mykolab.com (unknown [10.9.6.2]) by int-mx003.mykolab.com (Postfix) with ESMTPS id 1CD33A2D for ; Fri, 1 Dec 2017 07:51:17 +0100 (CET) From: Michael McConville Mime-Version: 1.0 (Mac OS X Mail 11.1 \(3445.4.7\)) Message-Id: <24F37CB2-A34A-472D-88DF-3E27E0E98F78@mykolab.com> Date: Thu, 30 Nov 2017 23:51:13 -0700 To: dev@dpdk.org Subject: [dpdk-dev] [PATCH] mmap(2) returns MAP_FAILED, not NULL, on failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Michael McConville Reviewed-by: Ferruh Yigit --- lib/librte_eal/bsdapp/eal/eal_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/bsdapp/eal/eal_memory.c b/lib/librte_eal/bsdapp/eal/eal_memory.c index 6ba058578..2c8a4b592 100644 --- a/lib/librte_eal/bsdapp/eal/eal_memory.c +++ b/lib/librte_eal/bsdapp/eal/eal_memory.c @@ -155,7 +155,7 @@ rte_eal_hugepage_attach(void) /* Map the shared hugepage_info into the process address spaces */ hpi = mmap(NULL, sizeof(struct hugepage_info), PROT_READ, MAP_PRIVATE, fd_hugepage_info, 0); - if (hpi == NULL) { + if (hpi == MAP_FAILED) { RTE_LOG(ERR, EAL, "Could not mmap %s\n", eal_hugepage_info_path()); goto error; }