From patchwork Sat Oct 14 15:27:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Santosh Shukla X-Patchwork-Id: 30404 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 707351B61E; Sat, 14 Oct 2017 17:27:57 +0200 (CEST) Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0087.outbound.protection.outlook.com [104.47.33.87]) by dpdk.org (Postfix) with ESMTP id 23FE91B608 for ; Sat, 14 Oct 2017 17:27:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Za/p5Y1Wts2TC2aN1TXtjk5v046GL5ZP8LKAai08tC8=; b=bwr9wkhv0asL1bYwrbmArkQ+Etumne6eUYsODyJyFi9xngzrddzDsZlG0bA63oTVOHpuglorPa+KgrTfhXQRyv3kiqifpLoCAMjARlZ4MMQ5FP2CPR2ZqjBD13kgDxtj4yYKp4Kc+YO1Dd0fkxRP7S005xz/il4Ha5lcwqJSfUg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Santosh.Shukla@cavium.com; Received: from [10.160.0.36] (111.93.218.67) by BN6PR07MB3092.namprd07.prod.outlook.com (10.172.105.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Sat, 14 Oct 2017 15:27:49 +0000 To: Hemant Agrawal , "olivier.matz@6wind.com" , "dev@dpdk.org" References: Cc: "thomas@monjalon.net" , "jerin.jacob@caviumnetworks.com" From: santosh Message-ID: <3e228854-d5d4-7dc1-6c25-29de7f6c37c7@caviumnetworks.com> Date: Sat, 14 Oct 2017 20:57:43 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: DM3PR12CA0043.namprd12.prod.outlook.com (10.161.151.11) To BN6PR07MB3092.namprd07.prod.outlook.com (10.172.105.10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 64f87134-6336-49fd-35a8-08d51318227d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:BN6PR07MB3092; X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3092; 3:uZ2VLypoCUCKoxX3agNytbONF51KegKaN5GLmIRXQ4fdW7r4jYomk+Xiog21VyGMKc9nUK42oDS95lxcNK0Robk/7onkz9bJf7OOVWTlp+YlGtNOBQhc3ZZTUhiWPwTIYH+dkJChywNwkbVd9CHykT6loO4r/r6R3fZMhi317rh6ZGobwjcMUxFsablss7FfPgyN9ghmHaSu5DQ8GhO4BBC5qhDJfsO23CEYIDvIvsRQACEPjW4AB1Is+6waAYnX; 25:AGoeVbOOqJsno5YMNKivYAl2cvnECGjDzzx/z8oCIHgEQ1JThTgYpr1ma8UkCuc11JhknCxofzdY9Sa3qdM5S6Vx7QJJrjk45al1VfY36p41FRVEtUEfpH7bed8Jf57k7UpXwmdlXrYbBPFEzV1OtiiRU8ojiQdUBfMAkUBwdRm0GlwSoWF3gnV+3w9pfX0qDjssq+eOKa+bk6n7Izzuc4/++HB8o+E74WCwSzJi0FGR91zPMTSZT5F3X0SWdjvYTtriNKUckCcZDzNAfpyzbTm/pmyX+XCp7tbxnWF+rWDaPzw7H0GNlplW16PNL0jjSCzMZ75o7oGvzmfWmeVsXQ==; 31:n2JTGQMUUSF7FBduBfkYG+MHJuoYy0kYVmroTD8DHrTNBvHxlF1BKM65mdDWOhVjLbd8gmxlBp3IfAyOhWUY2fFzXmIE9nHEEWkIOgGiTGJrax6BZO/CPESRERPmHWaDyqk52IVT59JlQMh9b7ngRL3509kSjD4o39M9wKxYkKOQBV0NnWpzYe8iJ9/avPb6PcguX/b9R8di+YMCG6Yqghq7AdcIhkjXfOZUSOp41t4= X-MS-TrafficTypeDiagnostic: BN6PR07MB3092: X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3092; 20:r9X8Rr4jJvWFTrk/N3EQHmQ85PIkOe5wADFmaaDjSGtdm/ZQe3phffDCfUmEsApQBUrNwjZOGPGh5+CIUjkaNgP8nRfp1Zb4Ll/uRWnsDsJtDEGfe2JeOnHpyITa72HSmIvdBpXpsJkWlx5BrZrxAbIFsbdzzW0b3+xTukelHBGbalsw8qsKtugk5l8gzfY3prahLGpCy0Ay3DlruB2jCara/dph1ukouMmgWsH5QJsecUrTQeIgBCdt53ukcD+SOLX2dID0VyRBSQhHwN02lPHX9dt0BGVs4fgnhnas5mn6Y18xyE5EX5qBW6KgLT24MkW/lkGJrUMRf0BTiigneZ6FmXXIOCpsPZ+zdBK9uwxPBJ5jy6QMlFGK41+gEdJBPJhqvoLqZjHYo+EGmkV5FU1aqPZEdlArEFiGXUHXU8EHwiuuDG1aSynqs55VLRHlLVsVr6copKh6Te9Ffc1cLdaQWxQR1I3fJMbTjapPTG8YFpmezWyHlT7ociB8r1nVOvZaLmJKjQQIYGMbsmJm7QIXBAiB+0jLEHT9+0KdAo+IacKpwM0VcqML4XynW+YUCQQt8q7WLEAPUagG+YJ/O2l2BZKdag24FWyyY4oHoUk=; 4:Kb+x1nZc+NtcbMdtajuqINN/jWbAQWKHozKpEZnuyCkEAvOekwXFSyLx4NDOyvgDMORUg7iVGKlRt4I1UAfIfsWIwHHbX4rQ6N9zCchE5O6ffFl7SacSW8qfa8/D1vIXYI5Ig/9/t61TzH4z2iIQXZXjo/eKg6FSOx36Yvp5g94X3f8xmesfqztxLE8XRjllFdsCh7q2bh9pEbNr65JwNrEDAmzNNl2Ni+maNeW5b94sEb5PxzqnLeRgfbTS3aNW X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(93006095)(10201501046)(100000703101)(100105400095)(6041248)(20161123560025)(20161123562025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN6PR07MB3092; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN6PR07MB3092; X-Forefront-PRVS: 046060344D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(6049001)(376002)(346002)(199003)(24454002)(377454003)(189002)(72206003)(50466002)(105586002)(33646002)(2906002)(23746002)(229853002)(3846002)(5660300001)(54906003)(6116002)(31696002)(101416001)(966005)(6666003)(106356001)(47776003)(230700001)(66066001)(65956001)(77096006)(65806001)(6486002)(8656003)(90366009)(5009440100003)(31686004)(97736004)(7736002)(305945005)(316002)(6306002)(53936002)(86152003)(81156014)(81166006)(8676002)(2950100002)(42882006)(83506001)(8936002)(25786009)(189998001)(68736007)(2501003)(16576012)(36756003)(110136005)(64126003)(58126008)(16526018)(76176999)(478600001)(6246003)(54356999)(2201001)(4326008)(50986999)(65826007)(53376002)(107886003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR07MB3092; H:[10.160.0.36]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BN6PR07MB3092; 23:AgO02yUjp9aYesCfWDsWV6CoyIdYyr5TD1Q6c?= =?windows-1252?q?QaVtUDfphQQ3u+hi22mnshv?= =?windows-1252?q?XgxxfHRqW/OdLKr5yocgCbBrZ9Va5dwa2ivX3er+c4aWZWqp+?= =?windows-1252?q?3W/sYojMFkiG2r0jZq+wn8caXK9oaP4Ce3s/VFUg9raQKSsEI?= =?windows-1252?q?pg9ZMvLui04ETeKtRLHKe/5OpYC6AMoQfUsOfrd37e4/0suli?= =?windows-1252?q?K871r4VJ79wu2/SAdNSx8gXJpxISo+NkL5fy6Pb7ICNka+zOC?= =?windows-1252?q?JlJEnuOQqd5J9RVZVKyhBDJdXsDlaweBLuCQq+LtZit3hyXJI?= =?windows-1252?q?X6GCM4466+ckMDgCFz3kUfgbtUP4r58Ym9C4YWSf2LzaicoMQ?= =?windows-1252?q?Hdv8oVNL4y9+PL9MvK7ldtjG/rG8rFtql0yeTfV2HBead5pwF?= =?windows-1252?q?zdCabywaq8iAipmLBZYu72++2ghygNQ/o+rIq7yhI9gAO8kn+?= =?windows-1252?q?QmxPxCT7fDl0N/80TNJFqFJdFM0ehzY16zrYFyUYSF9rY+b9O?= =?windows-1252?q?XF8x3OqzGih/XMqBWkNPiuD6zaptGkZec4ZGKN3XNTz4wLF+t?= =?windows-1252?q?23aV3wXB+6m602fve28O/FS/R5/cEP7yhH3VL2u50Awz0xJL1?= =?windows-1252?q?7HE8PEIELKzrxIFnKchjLx0b0tlrBJqtaXbCK5oko6c18N+Iq?= =?windows-1252?q?27RkufO3ZZO294BwbjNFpRGFHir4oYkjhi/f3jPrD3fFZCIUw?= =?windows-1252?q?r519Cz8oRUwgJn3Q049P74RgXphSyRb6jRfqI+8kauJ//D5BZ?= =?windows-1252?q?TnNxtaT1Lekp829+0mmdNTc+1CRAL8E4/sYIvsKmn6WpwUxJK?= =?windows-1252?q?kEeNW/vT2VhJPt1Nzl+KpZrMvGArv952HvPwEekPiM5CY3Cny?= =?windows-1252?q?m1+i8AMudpAxCjnEl+cgKdNbn/VvsLaSuHGtCxwI3XIBWY7hX?= =?windows-1252?q?G7fhsfe8Cm/8dXLbBe4YN9suF/zVkF2jBfrQhp7BI1UK//xMW?= =?windows-1252?q?+9qCRZ4MHaUHIkc/Jrw/VkuI5iZdqM4XZXoWjkHt73rBKroJS?= =?windows-1252?q?+qFYfkqeX8M5QDOFAwcdHLHPyxUw/DpmyHT321xV+q+lyFo9P?= =?windows-1252?q?6yRWPMAIBR0Qw5iyMvYS7mxVRNUlAWbJM3o0Qrcd7LrdNOiOZ?= =?windows-1252?q?PaL6gClTWCPjEP8mOFqBTqa8PUiYFAScZdO3Ih2f4MdVU1Ftx?= =?windows-1252?q?BjT+1CMBjg414FWohonLulY8C3/wx5qGX/h5Tu3XaR0selDx3?= =?windows-1252?q?M+ezMk5uHXAnN/BVbh6vLYaNQk8q8ejulHLX/2xDddsfX0qdR?= =?windows-1252?q?/HScRVwfND2eab14xI01YcMpmezDPOzvESCFHo7RZJ3WH7gk9?= =?windows-1252?q?WQHHFZ5g3LPSoX4BMex9tbZe9/ThlhSpZocIENk+6IBNGGNGx?= =?windows-1252?q?adJRllAtzERiATGqIgFk0Oqiz6YL7jd/+TxKi+ke8AQ3acylp?= =?windows-1252?q?RxiBpDUWBleUh3wYygIJG+SN/RDD1ADVEjGdfXmbP4zIfDjEp?= =?windows-1252?q?apHR90ceghFqvWS005i/vh+apMjeSoKnbFa2tL/ud88ijpAiT?= =?windows-1252?q?1se852CO3ygthxlf7DdgdqZEvleR8GAWCt2uR10po3vO+m8n/?= =?windows-1252?q?L4fWoa3CdZ5btALDpy4R2RfZyFFoYngR0or3Ri6OxMZVh06fI?= =?windows-1252?q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3092; 6:tUOJk58ikWm9XuG8jEbiB8kmeo9HA0gyYm2s7Ni1XuWR2u0AWPwY6lokkEEQD0GLnzOHbjV6FdML/03atYLtdSwl1tVW0yFkj+f59wZqGzCiOl3nCdAG5EYMOMuO0834rWR1b3VSlXp5JbQv79GnBTL9RACK3Fdd1wK5Evrt7LtY/8sYoSy/Pig5PXvtr7xV5Nu4IbJ0FilNYMYueLGwBG+Io2HCJcRyoQl6Ij1fmA1WOjNzx/AymdA2Kd1apmZnGaic7jHs4vZx2nx8/3LoGExXl/4BlhJ24s+/EIiK84FpWCGSDXqTzpBSixIvDTnomN4ldbw+6p1b8DtjKJ/ZeA==; 5:qEYfnMUyP6r/nAabRLrN51i2bbJOTdlNReqonULaabrpEy9Ww3DGhOa58sxptf7aXnNp0JjOHO6xh5POr+4zXg1thGzJy677EgHtnJsxQfUtRpWK47ERvUZCBK1R1tfAzy8kvSFf8KdNF/m4mQo66Q==; 24:yuoS2BKESZAJIzYMtxbqIWlK1JQsoiMDUZ03WPpE/39Spb+HZtt7CRHVxSkNQd0+mbuj6Q+hQcrNjZTpQXJ/TTvuZfYpSeEJRO8C1Ol02LY=; 7:EmXEXnbC4kqvFEEE+s2S7sg6Q84RQVT8lMOLATzPBSkc45TG+02+S0RQufE7iK2T5ud4dcpOkxhp1EmwI/Qa9VDuyoVrTBbLl9TYVS8crTfLojbvWIS1KQIbdI2uwQoMc2i20gLH0mEDZZmzzLMVFLg3GKORzXG61LJpzxTalBpzdXonHI7oohu0MhSR8bf87XyHQgpZisyTJD7Gg7HXLXNX1TIVu1LijAMdejwhyQE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2017 15:27:49.8129 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB3092 Subject: Re: [dpdk-dev] Shared compilation issue - mempool/octeontx: add build and log infrastructure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Saturday 14 October 2017 11:37 AM, Hemant Agrawal wrote: > Santosh/jerin, > Your patch "mempool/octeontx: add build and log infrastructure" is causing shared build failure for NXP's patch "event/dpaa2: support event eth adapter", which is still under review. > http://dpdk.org/dev/patchwork/patch/30248/ > > In your patch, you have added mempool to be dependent on event, which is not correct. > > "+DEPDIRS-mempool := bus event" Yes, Octeontx needed mbox definitions and it was defined at event area. But You are right that adding event dependency in mempool may create issues for future feature like you mentioned. > Ideally, if you have common code, you should put that in bus or mempool . This way you can make event, net or sec etc dependent on bus or mempool and not the otherway around. Right. Proposed change for makefile will be: Can you give it a try and let me know your feedback. Thanks. diff --git a/drivers/Makefile b/drivers/Makefile index 3a5b22342..0467250aa 100644 --- a/drivers/Makefile +++ b/drivers/Makefile @@ -32,13 +32,13 @@ include $(RTE_SDK)/mk/rte.vars.mk DIRS-y += bus -DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += event -DEPDIRS-event := bus DIRS-y += mempool -DEPDIRS-mempool := bus event +DEPDIRS-mempool := bus DIRS-y += net DEPDIRS-net := bus mempool DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto DEPDIRS-crypto := bus mempool +DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += event +DEPDIRS-event := bus mempool include $(RTE_SDK)/mk/rte.subdir.mk