| Message ID | 59c1e579917d1ddeeb80c553021a1d551ddb9b52.1641629424.git.wangyunjian@huawei.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Maxime Coquelin |
| Headers | show |
| Series | net/virtio: fix uninitialized old_rss_key variable | expand |
| Context | Check | Description |
|---|---|---|
| ci/intel-Testing | success | Testing PASS |
| ci/Intel-compilation | success | Compilation OK |
| ci/iol-abi-testing | success | Testing PASS |
| ci/iol-x86_64-unit-testing | success | Testing PASS |
| ci/iol-x86_64-compile-testing | success | Testing PASS |
| ci/iol-aarch64-compile-testing | success | Testing PASS |
| ci/iol-aarch64-unit-testing | success | Testing PASS |
| ci/iol-intel-Functional | success | Functional Testing PASS |
| ci/github-robot: build | success | github build: passed |
| ci/iol-intel-Performance | success | Performance Testing PASS |
| ci/iol-broadcom-Functional | success | Functional Testing PASS |
| ci/iol-broadcom-Performance | success | Performance Testing PASS |
| ci/iol-mellanox-Performance | success | Performance Testing PASS |
| ci/checkpatch | success | coding style OK |
Hi Yunjuan, > -----Original Message----- > From: Yunjian Wang <wangyunjian@huawei.com> > Sent: Saturday, January 8, 2022 4:14 PM > To: dev@dpdk.org > Cc: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>; > dingxiaoxiong@huawei.com; xudingke@huawei.com; Yunjian Wang > <wangyunjian@huawei.com>; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/virtio: fix uninitialized old_rss_key variable > > This patch fixes an issue that uninitialized old_rss_key > is used for restoring the rss_key. > > Coverity issue: 373866 > Fixes: 0c9d66207054 ("net/virtio: support RSS") > Cc: stable@dpdk.org > > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com> > --- > drivers/net/virtio/virtio_ethdev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/virtio/virtio_ethdev.c > b/drivers/net/virtio/virtio_ethdev.c > index c2588369b2..7c445bfc48 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -2028,7 +2028,8 @@ virtio_dev_rss_hash_update(struct rte_eth_dev *dev, > > return 0; > restore_key: > - memcpy(hw->rss_key, old_rss_key, VIRTIO_NET_RSS_KEY_SIZE); > + if (rss_conf->rss_key && rss_conf->rss_key_len) > + memcpy(hw->rss_key, old_rss_key, VIRTIO_NET_RSS_KEY_SIZE); > restore_types: > hw->rss_hash_types = old_hash_types; > > -- > 2.27.0 Appreciate your effort with Coverity issue, thanks! Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
> -----Original Message----- > From: Yunjian Wang <wangyunjian@huawei.com> > Sent: Saturday, January 8, 2022 4:14 PM > To: dev@dpdk.org > Cc: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>; > dingxiaoxiong@huawei.com; xudingke@huawei.com; Yunjian Wang > <wangyunjian@huawei.com>; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/virtio: fix uninitialized old_rss_key variable > > This patch fixes an issue that uninitialized old_rss_key > is used for restoring the rss_key. > > Coverity issue: 373866 > Fixes: 0c9d66207054 ("net/virtio: support RSS") > Cc: stable@dpdk.org > > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com> > --- > drivers/net/virtio/virtio_ethdev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/virtio/virtio_ethdev.c > b/drivers/net/virtio/virtio_ethdev.c > index c2588369b2..7c445bfc48 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -2028,7 +2028,8 @@ virtio_dev_rss_hash_update(struct rte_eth_dev *dev, > > return 0; > restore_key: > - memcpy(hw->rss_key, old_rss_key, VIRTIO_NET_RSS_KEY_SIZE); > + if (rss_conf->rss_key && rss_conf->rss_key_len) > + memcpy(hw->rss_key, old_rss_key, VIRTIO_NET_RSS_KEY_SIZE); > restore_types: > hw->rss_hash_types = old_hash_types; > > -- > 2.27.0 Applied to next-virtio/main with headline fixed, thanks.
diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index c2588369b2..7c445bfc48 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -2028,7 +2028,8 @@ virtio_dev_rss_hash_update(struct rte_eth_dev *dev, return 0; restore_key: - memcpy(hw->rss_key, old_rss_key, VIRTIO_NET_RSS_KEY_SIZE); + if (rss_conf->rss_key && rss_conf->rss_key_len) + memcpy(hw->rss_key, old_rss_key, VIRTIO_NET_RSS_KEY_SIZE); restore_types: hw->rss_hash_types = old_hash_types;
This patch fixes an issue that uninitialized old_rss_key is used for restoring the rss_key. Coverity issue: 373866 Fixes: 0c9d66207054 ("net/virtio: support RSS") Cc: stable@dpdk.org Signed-off-by: Yunjian Wang <wangyunjian@huawei.com> --- drivers/net/virtio/virtio_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)