From patchwork Thu Oct 12 12:19:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adrien Mazarguil X-Patchwork-Id: 30277 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 245CD1B33C; Thu, 12 Oct 2017 14:20:55 +0200 (CEST) Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id B31691B309 for ; Thu, 12 Oct 2017 14:20:40 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id f4so12857135wme.0 for ; Thu, 12 Oct 2017 05:20:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=asFGQVliKJEwPcP9wqJ7Eofj4vh5WSFipik/QMyXf6g=; b=YbTyzGLbEEjV36J73Xxl/4SzB1WMnqtu27zE/2O34+XhPofEW00aHOHj2um97VCiDa 4lpmmeRfjNYzgVZC89YDYTr5gzGP95gQQtPksEfFByMWAwRqrfMCXe8tYO42dBQljeHs MG8PAy/++5AeJwWkhPVRQAx+ClHE86MgMLsBNquNDlKTMvWprNKxaUci8fUMt3aDygQv T/E4K51hr3EBodJwrhe4+PnNz1+W6C87HAEAT45tm/3twJLYXKF87fDELarZqUd6n7zM AUVWnocl/SZ4lRgycg9fRRMP7rnhxCogCRodPBryssGAl+vQ/hnWSdS83fFIHM7cd1ag TzHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=asFGQVliKJEwPcP9wqJ7Eofj4vh5WSFipik/QMyXf6g=; b=WkjWQoIarj2Pw1S7LX5SQi/klMb4RrDOCRx9VDr2qCPQGIOheuk3eMoZzNRDKoJLed uLoc8oVMrkyJz4RBBB3LVOsAj0Cg8sx1Am1rj3E2g43AYhw4o1juqnco4F97CAMmGFei Hr1SNU3sHnam0es7bFILpep8h11IZTCCiDWbEPZw4IIAxGlbVMiSiwRkmFOung4uWcFq r0i4/guRZS3xWFnSK484B6EYTdfF+RvFLaGN9iSUSIznkRaEa2cZcds2iQ1WoSgzMzKS aijrjQrxvdMISR8Xfc52Tohj4aFCagkr2tLcjP+LeOiBzPXwjOLPKUTyYs5nCOyZJ48Y TbMQ== X-Gm-Message-State: AMCzsaUAQW6lhaBOUAQx6jJzF2GIbCBdm7WjoUpr7eM9jGAe45WQDYIf IZOa9wfw4mCSU3h3VlONDTm7CQPD X-Google-Smtp-Source: AOwi7QB+N1c2NH88TErVmsckWX15mrJPffwJtoesrAroc693gtX8DI2WbPI0Gt9183z6WLOAOuYrIg== X-Received: by 10.28.126.208 with SMTP id z199mr1607307wmc.91.1507810840529; Thu, 12 Oct 2017 05:20:40 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id h185sm171865wma.19.2017.10.12.05.20.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Oct 2017 05:20:39 -0700 (PDT) From: Adrien Mazarguil To: Ferruh Yigit Cc: Nelio Laranjeiro , dev@dpdk.org Date: Thu, 12 Oct 2017 14:19:40 +0200 Message-Id: <6cd3e758dda376269d90a47babd641a7314eede5.1507809961.git.adrien.mazarguil@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: References: Subject: [dpdk-dev] [PATCH v2 26/29] net/mlx4: remove unnecessary check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Device operation callbacks are not supposed to handle a missing private data structure. Signed-off-by: Adrien Mazarguil Acked-by: Nelio Laranjeiro --- drivers/net/mlx4/mlx4_ethdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/mlx4/mlx4_ethdev.c b/drivers/net/mlx4/mlx4_ethdev.c index ebf2339..661e252 100644 --- a/drivers/net/mlx4/mlx4_ethdev.c +++ b/drivers/net/mlx4/mlx4_ethdev.c @@ -750,8 +750,6 @@ mlx4_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info) char ifname[IF_NAMESIZE]; info->pci_dev = RTE_ETH_DEV_TO_PCI(dev); - if (priv == NULL) - return; /* FIXME: we should ask the device for these values. */ info->min_rx_bufsize = 32; info->max_rx_pktlen = 65536;