app/test: fix event timer adapter create unit test

Message ID 90e70813b8e88170c5e31e57f9460e98b467ad95.1630354334.git.sthotton@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series app/test: fix event timer adapter create unit test |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/Intel-compilation success Compilation OK
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS

Commit Message

Shijith Thotton Aug. 30, 2021, 8:12 p.m. UTC
  Removed freeing of unallocated mempool in event timer adapter create
unit test.

Fixes: d1f3385d0076 ("test: add event timer adapter auto-test")

Signed-off-by: Shijith Thotton <sthotton@marvell.com>
---
 app/test/test_event_timer_adapter.c | 2 --
 1 file changed, 2 deletions(-)
  

Comments

Carrillo, Erik G Sept. 9, 2021, 8:11 p.m. UTC | #1
> -----Original Message-----
> From: Shijith Thotton <sthotton@marvell.com>
> Sent: Monday, August 30, 2021 3:13 PM
> To: dev@dpdk.org
> Cc: Shijith Thotton <sthotton@marvell.com>; jerinj@marvell.com;
> pbhagavatula@marvell.com; Carrillo, Erik G <erik.g.carrillo@intel.com>
> Subject: [PATCH] app/test: fix event timer adapter create unit test
> 
> Removed freeing of unallocated mempool in event timer adapter create unit
> test.
> 
> Fixes: d1f3385d0076 ("test: add event timer adapter auto-test")
> 
> Signed-off-by: Shijith Thotton <sthotton@marvell.com>
Acked-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
  
Shijith Thotton Oct. 22, 2021, 4:34 a.m. UTC | #2
>>
>> Removed freeing of unallocated mempool in event timer adapter create unit
>> test.
>>
>> Fixes: d1f3385d0076 ("test: add event timer adapter auto-test")
>>
>> Signed-off-by: Shijith Thotton <sthotton@marvell.com>
>Acked-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
 
Thomas, Please merge this patch.
  
Thomas Monjalon Oct. 25, 2021, 9:54 a.m. UTC | #3
22/10/2021 06:34, Shijith Thotton:
> >>
> >> Removed freeing of unallocated mempool in event timer adapter create unit
> >> test.
> >>
> >> Fixes: d1f3385d0076 ("test: add event timer adapter auto-test")
> >>
> >> Signed-off-by: Shijith Thotton <sthotton@marvell.com>
> >Acked-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
>  
> Thomas, Please merge this patch.

It is eventdev related, it should have been delegated to Jerin.
  
Thomas Monjalon Oct. 25, 2021, 9:56 a.m. UTC | #4
09/09/2021 22:11, Carrillo, Erik G:
> > From: Shijith Thotton <sthotton@marvell.com>
> > 
> > Removed freeing of unallocated mempool in event timer adapter create unit
> > test.
> > 
> > Fixes: d1f3385d0076 ("test: add event timer adapter auto-test")
> > 
> > Signed-off-by: Shijith Thotton <sthotton@marvell.com>
> Acked-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>

Applied, thanks.
  

Patch

diff --git a/app/test/test_event_timer_adapter.c b/app/test/test_event_timer_adapter.c
index 121c2d93e8..12c00e678e 100644
--- a/app/test/test_event_timer_adapter.c
+++ b/app/test/test_event_timer_adapter.c
@@ -1070,8 +1070,6 @@  adapter_create(void)
 	TEST_ASSERT_SUCCESS(rte_event_timer_adapter_free(adapter),
 			"Failed to free adapter");
 
-	rte_mempool_free(eventdev_test_mempool);
-
 	return TEST_SUCCESS;
 }