From patchwork Tue Mar 13 12:50:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?N=C3=A9lio_Laranjeiro?= X-Patchwork-Id: 36057 X-Patchwork-Delegate: shahafs@mellanox.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 30026AA9E; Tue, 13 Mar 2018 13:52:06 +0100 (CET) Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id 92FA18E1C for ; Tue, 13 Mar 2018 13:52:01 +0100 (CET) Received: by mail-wr0-f195.google.com with SMTP id r8so7185462wrg.0 for ; Tue, 13 Mar 2018 05:52:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=+2Mbl4DgvaTH/mG6zOBMdd1Ca/ONkaEEOOiKrsX+ljM=; b=kbX0lIZAiUd8i3hug5KotjNH0r0lHyHe3vg/FYu/uNFRnnF/WL9QnxDZPFtJ0JSgBi 6ZhMVOmzcB17rrV+3ZwTyxG952K47HvfeLrfJikjFMhkSDVIV4/f1UOQG8njJ+cN7LLs 396/GcPX9vhasdQ6Rett7GOAyb9YJvnXCOYT4n4jG8FzbLLuO9qcdkzs3uyYpPSSyFVN BVZxQRo4Vg99AwxyJlAlF8P4unaey/woW4KFr5mCG8MMOuXrd818hV+qqLLnbRrNgTxp C4wY6EhpQfRhHqje/ZrTTLP0leCJMpEgc+67vaZk5lFm67Ytxpw51Yvc8HlKn6/T+Pcw uSXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=+2Mbl4DgvaTH/mG6zOBMdd1Ca/ONkaEEOOiKrsX+ljM=; b=s1q5Kwx6iRotu/GNhTrlLKHZjpukJRYkmVAyNSblcATgUO+tZ6IyH2+H+3as5ijYsS rMRYFFzqJQp5nsT5BlBLMrA+7o38f5ZGaGS32ewggGqXmdtHfQmnzNI0iEm5ZXg4C555 9O8MP6fG5Vot8Vp0aURs1QVVIwDvbeYiNCkjHbgVzXhNYKZaVRiudEr5+v0XHvURGtZQ TxrG9NLNRrAC1taeW0xWMbsqjB9zkAEWaLkBZbuFzUjUr6mjR/FiYr/t832moZdY1tgG OKug66qN2s4W2QGZTRXz5p9mQhoDkB3lXPQiT8B7n/IbI0d4TdgldX03aWPmt1W2a8tT j30w== X-Gm-Message-State: AElRT7Gxe1xLPyU0S7porYITfEFL9fy2me2J4zmwwIiKi6uzG/EeUca8 2osvg0MKzffj4y+1cLQX8PF0 X-Google-Smtp-Source: AG47ELtMrT4Wn9QF1G06ycRzBRXCgp2y1irSz/oCuDgMHwnsjz5vwnDe4WIlARmQUrySRC0I6FNzIw== X-Received: by 10.28.150.14 with SMTP id y14mr719697wmd.5.1520945521249; Tue, 13 Mar 2018 05:52:01 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id f8sm202350wmc.1.2018.03.13.05.52.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Mar 2018 05:52:00 -0700 (PDT) From: Nelio Laranjeiro To: Adrien Mazarguil , Yongseok Koh Cc: dev@dpdk.org Date: Tue, 13 Mar 2018 13:50:38 +0100 Message-Id: <9236b53dbd8149ae9969b8daa359e9ea1facf2d3.1520944256.git.nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-dev] [PATCH 4/5] net/mlx5: use Netlink to enable promisc/allmulti X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" VF devices are not able to receive promisc or allmulti traffic unless it fully requests it though Netlink. This will cause the request to be processed by the PF which will handle the request and enable it. This requires the VF to be trusted by the PF. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.h | 2 + drivers/net/mlx5/mlx5_trigger.c | 27 ++++++++++- drivers/net/mlx5/mlx5_vf.c | 102 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 130 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index a4333e6a5..245235641 100644 --- a/drivers/net/mlx5/mlx5.h +++ b/drivers/net/mlx5/mlx5.h @@ -303,5 +303,7 @@ int mlx5_mr_verify(struct rte_eth_dev *dev); int mlx5_vf_mac_addr_add(struct rte_eth_dev *dev, struct ether_addr *mac); int mlx5_vf_mac_addr_remove(struct rte_eth_dev *dev, struct ether_addr *mac); int mlx5_vf_mac_addr_flush(struct rte_eth_dev *dev); +int mlx5_vf_promisc(struct rte_eth_dev *dev, int enable); +int mlx5_vf_allmulti(struct rte_eth_dev *dev, int enable); #endif /* RTE_PMD_MLX5_H_ */ diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c index 6bb4ffb14..3f21797ff 100644 --- a/drivers/net/mlx5/mlx5_trigger.c +++ b/drivers/net/mlx5/mlx5_trigger.c @@ -278,8 +278,23 @@ mlx5_traffic_enable(struct rte_eth_dev *dev) unsigned int j; int ret; - if (priv->isolated) + if (priv->isolated) { + if (priv->config.vf) { + if (dev->data->promiscuous) { + ret = mlx5_vf_promisc(dev, 1); + rte_errno = ret; + if (ret) + goto error; + } + if (dev->data->all_multicast) { + ret = mlx5_vf_allmulti(dev, 1); + rte_errno = ret; + if (ret) + goto error; + } + } return 0; + } if (dev->data->promiscuous) { struct rte_flow_item_eth promisc = { .dst.addr_bytes = "\x00\x00\x00\x00\x00\x00", @@ -287,6 +302,11 @@ mlx5_traffic_enable(struct rte_eth_dev *dev) .type = 0, }; + if (priv->config.vf) { + ret = mlx5_vf_promisc(dev, 1); + if (ret) + goto error; + } ret = mlx5_ctrl_flow(dev, &promisc, &promisc); if (ret) goto error; @@ -298,6 +318,11 @@ mlx5_traffic_enable(struct rte_eth_dev *dev) .type = 0, }; + if (priv->config.vf) { + ret = mlx5_vf_allmulti(dev, 1); + if (ret) + goto error; + } ret = mlx5_ctrl_flow(dev, &multicast, &multicast); if (ret) goto error; diff --git a/drivers/net/mlx5/mlx5_vf.c b/drivers/net/mlx5/mlx5_vf.c index 3db8ee0eb..cf71e79d9 100644 --- a/drivers/net/mlx5/mlx5_vf.c +++ b/drivers/net/mlx5/mlx5_vf.c @@ -447,3 +447,105 @@ mlx5_vf_mac_addr_flush(struct rte_eth_dev *dev) } return 0; } + +/** + * Enable promisc/allmulti though Netlink + * + * @param dev + * Pointer to Ethernet device structure. + * @param flags + * IFF_PROMISC for promiscuous, IFF_ALLMULTI for allmulti. + * @param en + * 1 to enable, 0 to disable. + * + * @return + * 0 on success, a negative errno value otherwise and rte_errno is set. + */ +static int +mlx5_vf_device_flags(struct rte_eth_dev *dev, uint32_t flags, int enable) +{ + int iface_idx = mlx5_vf_iface_idx(dev); + struct { + struct nlmsghdr hdr; + struct ifinfomsg ifi; + } req = { + .hdr = { + .nlmsg_len = NLMSG_LENGTH(sizeof(struct ifinfomsg)), + .nlmsg_type = RTM_NEWLINK, + .nlmsg_flags = NLM_F_REQUEST, + }, + .ifi = { + .ifi_flags = enable ? flags : 0, + .ifi_change = flags, + .ifi_index = iface_idx, + }, + }; + int fd; + int ret; + + assert(!(flags & ~(IFF_PROMISC | IFF_ALLMULTI))); + fd = rte_nl_init(NETLINK_ROUTE); + if (fd < 0) { + rte_errno = errno; + goto error; + } + ret = rte_nl_send(fd, &req.hdr); + if (ret == -1) { + rte_errno = errno; + goto error; + } + rte_nl_final(fd); + return 0; +error: + if (fd >= 0) + rte_nl_final(fd); + return -rte_errno; +} + +/** + * Enable promisc though Netlink + * + * @param dev + * Pointer to Ethernet device structure. + * @param en + * 1 to enable promisc, 0 to disable it. + * + * @return + * 0 on success, a negative errno value otherwise and rte_errno is set. + */ +int +mlx5_vf_promisc(struct rte_eth_dev *dev, int enable) +{ + int ret = mlx5_vf_device_flags(dev, IFF_PROMISC, enable); + + if (ret) + DRV_LOG(DEBUG, + "port %u cannot %s promisc mode: Netlink error %s", + dev->data->port_id, enable ? "enable" : "disable", + strerror(rte_errno)); + return ret; +} + +/** + * Enable allmulti though Netlink + * + * @param dev + * Pointer to Ethernet device structure. + * @param en + * 1 to enable promisc, 0 to disable it. + * + * @return + * 0 on success, a negative errno value otherwise and rte_errno is set. + */ +int +mlx5_vf_allmulti(struct rte_eth_dev *dev, int enable) +{ + int ret = mlx5_vf_device_flags(dev, IFF_ALLMULTI, enable); + + if (ret) + DRV_LOG(DEBUG, + "port %u cannot %s allmulti mode: Netlink error %s", + dev->data->port_id, enable ? "enable" : "disable", + strerror(rte_errno)); + return ret; +}