From patchwork Fri Feb 6 02:00:44 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: xuelin.shi@freescale.com X-Patchwork-Id: 3006 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 70F70B470; Fri, 6 Feb 2015 03:00:47 +0100 (CET) Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1on0145.outbound.protection.outlook.com [157.56.110.145]) by dpdk.org (Postfix) with ESMTP id 368B4B46F for ; Fri, 6 Feb 2015 03:00:46 +0100 (CET) Received: from CY1PR0301MB0684.namprd03.prod.outlook.com (25.160.158.155) by CY1PR0301MB0683.namprd03.prod.outlook.com (25.160.158.153) with Microsoft SMTP Server (TLS) id 15.1.75.20; Fri, 6 Feb 2015 02:00:44 +0000 Received: from CY1PR0301MB0684.namprd03.prod.outlook.com ([25.160.158.155]) by CY1PR0301MB0684.namprd03.prod.outlook.com ([25.160.158.155]) with mapi id 15.01.0075.002; Fri, 6 Feb 2015 02:00:44 +0000 From: Xuelin Shi To: "olivier.matz@6wind.com" Thread-Topic: [PATCH] fix testpmd show port info error Thread-Index: AQHQPr2TY/Z2hG6+xk2PO/Fhu1pFsJzhzS1AgAEWUmA= Date: Fri, 6 Feb 2015 02:00:44 +0000 Message-ID: References: <1422859901-3896-1-git-send-email-xuelin.shi@freescale.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [123.151.195.51] authentication-results: 6wind.com; dkim=none (message not signed) header.d=none; x-microsoft-antispam: BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB0683; x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:; SRVR:CY1PR0301MB0683; x-forefront-prvs: 047999FF16 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(13464003)(164054003)(122556002)(99286002)(33656002)(62966003)(77156002)(2900100001)(19580395003)(19580405001)(76576001)(106116001)(102836002)(2501002)(110136001)(2351001)(40100003)(66066001)(2656002)(87936001)(2950100001)(50986999)(76176999)(54356999)(74316001)(46102003)(86362001)(92566002); DIR:OUT; SFP:1102; SCL:1; SRVR:CY1PR0301MB0683; H:CY1PR0301MB0684.namprd03.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Feb 2015 02:00:44.2299 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB0683 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] fix testpmd show port info error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Olivier, Would you please help to review the bottom patch? Thanks, Shi Xuelin -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xuelin Shi Sent: Thursday, February 05, 2015 17:27 To: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] fix testpmd show port info error Hi, Anybody interested in this patch could have a review or comment on it? I'm new here. Should I send this patch to some specific maintainer to make this more efficient? Thanks, Shi Xuelin -----Original Message----- From: xuelin.shi@freescale.com [mailto:xuelin.shi@freescale.com] Sent: Monday, February 02, 2015 14:52 To: dev@dpdk.org Cc: Shi Xuelin-B29237 Subject: [PATCH] fix testpmd show port info error From: Xuelin Shi the port number type should be consistent with librte_cmdline, else there is potential endian issue. Signed-off-by: Xuelin Shi --- app/test-pmd/cmdline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.9.1 diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 4beb404..488ac63 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -5568,7 +5568,7 @@ cmdline_parse_token_string_t cmd_showport_what = TOKEN_STRING_INITIALIZER(struct cmd_showport_result, what, "info#stats#xstats#fdir#stat_qmap"); cmdline_parse_token_num_t cmd_showport_portnum = - TOKEN_NUM_INITIALIZER(struct cmd_showport_result, portnum, INT32); + TOKEN_NUM_INITIALIZER(struct cmd_showport_result, portnum, INT8); cmdline_parse_inst_t cmd_showport = { .f = cmd_showport_parsed,