From patchwork Thu Aug 26 19:06:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: YE Chengfeng X-Patchwork-Id: 97408 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5480FA0C54; Fri, 27 Aug 2021 03:23:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB4984125F; Fri, 27 Aug 2021 03:22:54 +0200 (CEST) Received: from JPN01-TY1-obe.outbound.protection.outlook.com (mail-eopbgr1400107.outbound.protection.outlook.com [40.107.140.107]) by mails.dpdk.org (Postfix) with ESMTP id CCB1040140 for ; Thu, 26 Aug 2021 21:06:15 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RfGzG4IRCbibgpGp5A9LFdKmjsa20jEQFCx1AGjseoQI1KTWfxOJojnBdpi8MkRZbbAMG78cDyxmZWBedBRN+a0H6AqbzcN/EU1Jwuz2o5WZqhvYKUYlBH/dq7zQ8lkaAMHI5T+mfyaX0BXJruqYoG5u11LOyobU6I5yB/8hRyl55Y5c08U859LWKH6s6r7DkGw9zUwhHiM9DxHFOkyexcdj5ej4K293Enl2FkYkS+4/PcYbQSVcoJPf4Y16pWbIdkwehe4B1pwzsUFLFRRyQcXgYDBR1OfZqDG9CV9xcShfoDafIw1h0UFNQmWvrXQyYWKZjOcTZuI/i1WXG1+WxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AazlBy9CUdSByn7u2W/sF0uprEAQfULq9+sCntUm/x4=; b=jqhUMu8vOzTH9+CkUzEjGpqQMdu6r70XYLIke3WNhknH4bBoENAzSX5DRCOwCOUl5JnfCBPj94xKxY4INd4sCGup1QZ8BdVuvsW6dmgG4S3ydphY5YzYJCJB3/c0orttOCNBFhFMsb68E+uCTGF0BPA1Peso9gxgPVS7qFY6hwfw8woPIb9RKOnWj23ggaYCw+auLcVQTMnkyo0p4vckKL2lFfH6UCj+ZUvRh8JADK6XUQATBSb3+5SaB9wyURI7eRB7nVE3YTTdnW0aSs07e96S8TJU1+sJ+xxGj728bNODHOoXCVKt5z9KAlRJBQu1QTwUKImleXuV1CzVp7Afig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=connect.ust.hk; dmarc=pass action=none header.from=connect.ust.hk; dkim=pass header.d=connect.ust.hk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=connect.ust.hk; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AazlBy9CUdSByn7u2W/sF0uprEAQfULq9+sCntUm/x4=; b=s+hgT+8U1XZpTG8zc8bULDA4tOUiuAYr0phjJxEsfmMCe8nQJQQufNK4uXRj2r9oEiKKGJQuteq+4+Qj5cfI5TCQJh0ZN3nfx9NTUdQ0l8j+/0B9KR8m8FD6v9RnMhwvpFBDtlV/Wh3jEpRjZJlz0Zs54jvHg1h2sjo2c+fOJt8= Received: from TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:b7::8) by TYCP286MB1425.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:c0::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.20; Thu, 26 Aug 2021 19:06:14 +0000 Received: from TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM ([fe80::b9cf:11ff:5f5a:32c1]) by TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM ([fe80::b9cf:11ff:5f5a:32c1%6]) with mapi id 15.20.4436.027; Thu, 26 Aug 2021 19:06:14 +0000 From: YE Chengfeng To: "asomalap@amd.com" CC: "dev@dpdk.org" Thread-Topic: [PATCH v2] net/mlx5: fix potential unreleased lock problem Thread-Index: AQHXmqwt1oTB9T+vj0aU7EB8DzJMxauGJN+2 Date: Thu, 26 Aug 2021 19:06:14 +0000 Message-ID: References: <20210826185633.107314-1-cyeaa@connect.ust.hk> In-Reply-To: <20210826185633.107314-1-cyeaa@connect.ust.hk> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=connect.ust.hk; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a34477f6-0e65-44e2-bc49-08d968c49328 x-ms-traffictypediagnostic: TYCP286MB1425: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kW0XLWdxi6WInyDctvZIEeWrAoNjDe+teYXyDD47N1gwGOOg+1n5OLQfGGJDTcA890eskJ/M+w5/RCxGADLMLWS6M2jCcw4L6s7VXvSKPpgHQle+PoNir5L4JXW94RekIQx+Xy4aw1hK5yc6iL2mW1hH2yXXSsEc9kOQ+zAR1PL6UZcU14dL8C06RhLBapUIVDZOfjLlfFHCNijCPwyCj+3JM2WiIaiqysa/ZepyWz4KXOxtiKAktzy6n1Q+EVHmeSe5OChGza75NsTzy8jjcBKx3FznkN0EY3bXthg5LlJp+/dD7ZrCzuB5Y7FXlWGVIlYcj8gOBLhE5EVetpCcAO55+dEtjBU+iDlLRG3Ow19EJtzS+9XuwPkigR9nRH3RpnU2f7DR9GkSxXeDdKS1bzyxejRDTG8RqpZXqOWTT5XfaCBnRmBwQo9y9sYiIsiyarRNOl3G2kgtjDlDQrk/ChsG8Zgr4TzdhCVUFJAdy3M68yN4sH8jz+dYtxouHwnpB/W7JwL+vuflf7CLqtRaJATkHuB4PYHz+0BajQP2VL/ulJdgVmKupu2wdghDLurjXoI63rm4EJ8f2ScJYF17GSsu78ocVkMdJqFI6QxymVAXMT1BpHt7NVtU49zgoShf9faZYBDvHz0PmLN1nBqxbZV+EfH09B57ihLxvoKRY9evp1HfNVRo6BCKv/wDV5wm x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(4636009)(396003)(39850400004)(366004)(136003)(346002)(376002)(122000001)(38100700002)(4326008)(786003)(7696005)(71200400001)(316002)(83380400001)(224303003)(9686003)(38070700005)(26005)(52536014)(91956017)(66946007)(66476007)(66556008)(64756008)(66446008)(8936002)(55016002)(2906002)(6916009)(186003)(19627405001)(6506007)(76116006)(86362001)(33656002)(5660300002)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?eucgb2312_cn?b?Rk9GN3dlaXJ6eFlybDhuMk1Q?= =?eucgb2312_cn?b?amZETW1Da3Y3RHBSOVE0cGNhWG5mY1Y3VUtPK3kxeXlkTDFuRktiVnAyUkltTUdo?= =?eucgb2312_cn?b?WXVuRmFyUjBDQ3c0RTBVcDlYVXhNV0QvTmJqd205YzhzWXB0R3AyTGpzR2NLZTk4?= =?eucgb2312_cn?b?cVR1eXQxY0R1YUJrSmxOZFAwcWVrcUE1QkEyZjM1V0cvYVJvV3poTHpxRS9iTTZ1?= =?eucgb2312_cn?b?UEsxYVBYUFU1blB2a0o5SmlHYlBXbU53dlN2a1FmTEcwU2k4R01idkNIUytIWnlq?= =?eucgb2312_cn?b?VVFRaVdoYlBhenN2SzlYRjI5MU93aWdka3dwZlFOM2VGMWorTEpuY1RjaFRqcTJa?= =?eucgb2312_cn?b?WUJzN2lUM1p5WFhmUitQajZOd3R4S3RaSXFFQXA2R3VXVStPQUNTVFJJT0NJRkpn?= =?eucgb2312_cn?b?clBxU1k3RDlETzVvTkNDOWFqdUNsQWFFcWRxd24xSmFPTFJoRFZOZ3NQbFg1NmhX?= =?eucgb2312_cn?b?V2l5cFNkbzFKT0JMRnZYZ0c5OEZHL1YvU3VKUXd0UE0wNFhhcDBSWloxQko5YzVK?= =?eucgb2312_cn?b?SWpxK3REaXJZMG92djFBd0ptZzdNWW5SdU50QWJWMFFZaVJrNmZsOWtaTzlOVHlP?= =?eucgb2312_cn?b?RER0WE5DTEhuUE5HbHFTV1NudlByWExkU1pMU0NOY25xVmkzeElDckU0NmZzZXhG?= =?eucgb2312_cn?b?YThUTEJXKzA1WmdBT3krWGxGd1JyNzdqOHZnMGFIbVdhNGt4VjRwZlJ3STdROC9q?= =?eucgb2312_cn?b?MUpXaDBOWjdBR0lqWklQTllMZC8xMno1RnhKZW5qREFKVU5OZjc5dFhJVGVrd2sy?= =?eucgb2312_cn?b?aVQ2NmNTNTFGZHRKY21lSFpkRUkvZnFFekZwb3JRSlliSUJ2S05waGVQdVArM20r?= =?eucgb2312_cn?b?UHUyT0FoRElGb2tXeFcyWHVYK0xyUzU3VVZPa2t0YzlqcjNMak03b0d6MDlqdkYx?= =?eucgb2312_cn?b?Tmx1eG1rL01Tc2haNDdqMDNScFFDNmVIeTBCQjV1bVlKazZyNTRSSmMwajZMQjZD?= =?eucgb2312_cn?b?YlBrNWVMZVprZ0lFYm9XeFpNRVQ0UmVTZW5TdngvM1JZaklweWZndlQwUE9ITE5u?= =?eucgb2312_cn?b?eTlFcms5dzJVVkVsZ1ZzTGVxWlh3VzBCRzBMVWF0aEtPQkZ1My9GVFBlbjFRS29W?= =?eucgb2312_cn?b?dm9NelpwL2lWc1FlZnBjRE1zcmJJb21MTE0xZHh1akFiWGRXRlVMdFFYWVA3U05L?= =?eucgb2312_cn?b?YnQxQTNjSXlOUDY2bk5zUE9ocVJSQ0NMZGQwMXpSYkVnUVoxY216K1krS0dHaVpr?= =?eucgb2312_cn?b?QmhHdURDbW12M2dpMm9lVkcxZFh4b2NVRnhadGU0ZHhZYXNBQmZmckhMWGV2VU95?= =?eucgb2312_cn?b?YUVtdWhDNS9rczk5Sy9HUDFXQkNrdmxjdkRRdklOd1pWTmdHUk5aVUk5ZjN5dmxw?= =?eucgb2312_cn?b?enk5VVlQWnorZjJVdDN6clBRTnFOcGM2SVRNcU8rOWpZSWZPWUJBRitPZEtEaHJD?= =?eucgb2312_cn?b?SVRDRG5PNmVZeGFpZk5GWVhtVUJuSENkN3Q4aGVBRFYwV1RyT1BNcTFsS0JRY285?= =?eucgb2312_cn?b?Qmd3UzhGOGdraGRYM0J3b0V6OU9nUUlJbk9kR2V0OXdzb3ZkZjlsZXZZSnhFT0d6?= =?eucgb2312_cn?b?Mm11cW5sekR6YVdxemhNbWZPU052RGNYSTkzOGg5L29RemxmS0NudUkrdHFBcEUx?= =?eucgb2312_cn?b?N1hONnd3MjBLTCtQbkg0aTFTRjNqbjNTQzV0QTZHaEVlSDJIQlZSdFhTZmI5WGRl?= =?eucgb2312_cn?b?NndVTEFZdUtiK1lwclhTSkZDRGFQWjVlVTQvRVlMQ2dIS09QQkx2YmZHS0pOcmo1?= =?eucgb2312_cn?b?Z0d6K3hYMEUvTnEycCtRNE9KWk5JZnRhMjd1SWlD?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: connect.ust.hk X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: a34477f6-0e65-44e2-bc49-08d968c49328 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Aug 2021 19:06:14.0389 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 6c1d4152-39d0-44ca-88d9-b8d6ddca0708 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8pqgBPciCdhHZxo7TlQz4yyWvyFImlWhDDb2TWOXQ0Yf3L9MQaK9bhy+/O+acqk8I7gdAfcg+S3MAFD6vjMkHA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCP286MB1425 X-Mailman-Approved-At: Fri, 27 Aug 2021 03:22:49 +0200 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [dpdk-dev] =?eucgb2312_cn?b?u9i4tDogW1BBVENIIHYyXSBuZXQvbWx4NTogZml4IHBv?= =?eucgb2312_cn?b?dGVudGlhbCB1bnJlbGVhc2VkIGxvY2sgcHJvYmxlbQ==?= X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" It seems that I send this patch to a wrong place, please just ignore it. Thanks, Chengfeng diff --git a/drivers/net/mlx5/mlx5_txpp.c b/drivers/net/mlx5/mlx5_txpp.c index 4f6da9f2d1..0ece788a84 100644 --- a/drivers/net/mlx5/mlx5_txpp.c +++ b/drivers/net/mlx5/mlx5_txpp.c @@ -961,8 +961,12 @@ mlx5_txpp_stop(struct rte_eth_dev *dev) MLX5_ASSERT(!ret); RTE_SET_USED(ret); MLX5_ASSERT(sh->txpp.refcnt); - if (!sh->txpp.refcnt || --sh->txpp.refcnt) + if (!sh->txpp.refcnt || --sh->txpp.refcnt) { + ret = pthread_mutex_unlock(&sh->txpp.mutex); + MLX5_ASSERT(!ret); + RTE_SET_USED(ret); return; + } /* No references any more, do actual destroy. */ mlx5_txpp_destroy(sh); ret = pthread_mutex_unlock(&sh->txpp.mutex);