From patchwork Mon Oct 23 14:49:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?N=C3=A9lio_Laranjeiro?= X-Patchwork-Id: 30721 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A0DBA1B65E; Mon, 23 Oct 2017 16:50:29 +0200 (CEST) Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id C5CEF1B642 for ; Mon, 23 Oct 2017 16:50:17 +0200 (CEST) Received: by mail-wr0-f193.google.com with SMTP id j15so5528217wre.8 for ; Mon, 23 Oct 2017 07:50:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=M6F98JH/x+wn7tgMBky9ElJ+KNPNycD4axu7lEhtI8o=; b=upf8uVWXN/NI9RTrOKpBSKQ6zMKEPFG5A0xnLMzY2rF4vCilngEbTGljPNMTU9RaBc DS6++SYc0uteqOPe7eBT5pWlTMSfNlyYH5/cgsZozwYJxDWtyjk7rAV+GawS7cjXGQVP FXaDYPKacmomEeOEF1wLjFfSNB3wsy16N1tQIDMseV6S67639Q9Im5sDBh4nGdbsQtyG Sd3x8wysBdUPBnM+gCRUmRieSwowFsaVthJuyJ8F9RkE0h7r6PcWWjtEvrWbiKwaV6FE 51crHW3CqjKIPD2WcYVQD3alei70fMeKR1EpUG3Gq7hjMmTG3TPI/qPwQ/yFZHkMykhG p7Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=M6F98JH/x+wn7tgMBky9ElJ+KNPNycD4axu7lEhtI8o=; b=nTCAGm/NNtpNCMvtyYDrEI3Oakch6HEoGfWPWW4C4tJ2ThsWrpY6igc6IiOin+3T63 SeStvwgFnLiN0cBC6MmZ0IU3RQWp2ImZYeSDXwxPHlJvqPPM9DGrcn+HG9PktSokY6cN bfpJq65C7/wx67wUSEt34weYM9kcMVe+4msOKj5CVdkPa4dN5mV7uBCWxgjDWckGcUpf altLyFpbcuImHmpj9ChFAd/f6GcsG1KCRYmcivGZA3kI2cJlFfnKhmOVez1k3qzuzDxE 6CHQZwaer6QjeFmLksCNUTfROPmwl5L7VlhZd1d1zlzpQ0bOAEc87kBFeFRT1IgVKt5d XUeQ== X-Gm-Message-State: AMCzsaWr/NrozTH8ZaObwSdWNIKBLkKHRa/Xrn+qRKki5iJKzDNCtiDG 1hv8YixjvmDtkSzcYrkTF6h6cr2goQ== X-Google-Smtp-Source: ABhQp+Q+QMYbqWGlCuajdZeTS3uv++sk/M6ELazdV1MWI6a0dvh5Wi07meb70nDdCP6MsFM3H5v/iA== X-Received: by 10.223.153.202 with SMTP id y68mr7528041wrb.216.1508770217351; Mon, 23 Oct 2017 07:50:17 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id s196sm4908234wmb.26.2017.10.23.07.50.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Oct 2017 07:50:16 -0700 (PDT) From: Nelio Laranjeiro To: dev@dpdk.org Cc: Yongseok Koh , Adrien Mazarguil Date: Mon, 23 Oct 2017 16:49:55 +0200 Message-Id: X-Mailer: git-send-email 2.11.0 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-dev] [PATCH v2 5/7] net/mlx5: fix mark action with drop action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Marking a packet which will not be received by the NIC is useless, even if this action remains possible, it blocks the creation of the flow counter which embed a mark action to a drop queue to be created. Fixes: 31ba9997f11a ("net/mlx5: fully convert a flow to verbs in validate") Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 96a753e8d..13b78ce9b 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -786,6 +786,8 @@ priv_flow_convert_actions(struct priv *priv, goto exit_action_not_supported; } } + if (parser->drop && parser->mark) + parser->mark = 0; if (!parser->queues_n && !parser->drop) { rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_HANDLE, NULL, "no valid action");