[dpdk-dev,v5,18/21] ethdev: add private generic device iterator
Checks
Commit Message
This iterator can be customized with a comparison function that will
trigger a stopping condition.
It can be leveraged to write several different iterators that have
similar but non-identical purposes.
It is private to librte_ether.
Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
---
lib/librte_ether/Makefile | 1 +
lib/librte_ether/eth_private.c | 32 ++++++++++++++++++++++++++++++++
lib/librte_ether/eth_private.h | 26 ++++++++++++++++++++++++++
3 files changed, 59 insertions(+)
create mode 100644 lib/librte_ether/eth_private.c
create mode 100644 lib/librte_ether/eth_private.h
Comments
On Wed, Apr 11, 2018 at 02:04:19AM +0200, Gaetan Rivet wrote:
> This iterator can be customized with a comparison function that will
> trigger a stopping condition.
>
> It can be leveraged to write several different iterators that have
> similar but non-identical purposes.
>
> It is private to librte_ether.
>
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
> lib/librte_ether/Makefile | 1 +
> lib/librte_ether/eth_private.c | 32 ++++++++++++++++++++++++++++++++
> lib/librte_ether/eth_private.h | 26 ++++++++++++++++++++++++++
> 3 files changed, 59 insertions(+)
> create mode 100644 lib/librte_ether/eth_private.c
> create mode 100644 lib/librte_ether/eth_private.h
>
> diff --git a/lib/librte_ether/Makefile b/lib/librte_ether/Makefile
> index c2f2f7d82..2fa133fbc 100644
> --- a/lib/librte_ether/Makefile
> +++ b/lib/librte_ether/Makefile
> @@ -18,6 +18,7 @@ EXPORT_MAP := rte_ethdev_version.map
>
> LIBABIVER := 9
>
> +SRCS-y += eth_private.c
> SRCS-y += rte_ethdev.c
> SRCS-y += rte_flow.c
> SRCS-y += rte_tm.c
> diff --git a/lib/librte_ether/eth_private.c b/lib/librte_ether/eth_private.c
> new file mode 100644
> index 000000000..311c5d6b2
> --- /dev/null
> +++ b/lib/librte_ether/eth_private.c
> @@ -0,0 +1,32 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2018 Gaëtan
Forgot something here.
> + */
> +
> +#include "rte_ethdev.h"
> +#include "eth_private.h"
> +
> +struct rte_eth_dev *
> +eth_find_device(const void *_start, rte_eth_cmp_t cmp,
_start should be of type (const struct rte_eth_dev *), will update this
patch.
Same changes to eth_private.h
@@ -18,6 +18,7 @@ EXPORT_MAP := rte_ethdev_version.map
LIBABIVER := 9
+SRCS-y += eth_private.c
SRCS-y += rte_ethdev.c
SRCS-y += rte_flow.c
SRCS-y += rte_tm.c
new file mode 100644
@@ -0,0 +1,32 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2018 Gaëtan
+ */
+
+#include "rte_ethdev.h"
+#include "eth_private.h"
+
+struct rte_eth_dev *
+eth_find_device(const void *_start, rte_eth_cmp_t cmp,
+ const void *data)
+{
+ const struct rte_eth_dev *start = _start;
+ struct rte_eth_dev *edev;
+ ptrdiff_t idx;
+
+ /* Avoid Undefined Behaviour */
+ if (start != NULL &&
+ (start < &rte_eth_devices[0] ||
+ start > &rte_eth_devices[RTE_MAX_ETHPORTS]))
+ return NULL;
+ if (start != NULL)
+ idx = start - &rte_eth_devices[0] + 1;
+ else
+ idx = 0;
+ for (; idx < RTE_MAX_ETHPORTS; idx++) {
+ edev = &rte_eth_devices[idx];
+ if (cmp(edev, data) == 0)
+ return edev;
+ }
+ return NULL;
+}
+
new file mode 100644
@@ -0,0 +1,26 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2018 Gaëtan
+ */
+
+#ifndef _ETH_PRIVATE_H_
+#define _ETH_PRIVATE_H_
+
+#include "rte_ethdev.h"
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+/* Generic rte_eth_dev comparison function. */
+typedef int (*rte_eth_cmp_t)(const struct rte_eth_dev *, const void *);
+
+/* Generic rte_eth_dev iterator. */
+struct rte_eth_dev *
+eth_find_device(const void *_start, rte_eth_cmp_t cmp,
+ const void *data);
+
+#ifdef __cplusplus
+}
+#endif
+
+#endif /* _ETH_PRIVATE_H_ */