[v2] common/cnxk: fix incorrect error checking

Message ID tencent_D9E5DF2B236C22CD317F3CAEA71811F93A08@qq.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series [v2] common/cnxk: fix incorrect error checking |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-abi-testing success Testing PASS

Commit Message

Weiguo Li Jan. 22, 2022, 6:49 a.m. UTC
  Fixes: 804c108b039a ("common/cnxk: set BPHY IRQ handler")

Signed-off-by: Weiguo Li <liwg06@foxmail.com>
---
 drivers/common/cnxk/roc_bphy_irq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Jerin Jacob Jan. 23, 2022, 12:42 p.m. UTC | #1
On Sat, Jan 22, 2022 at 12:20 PM Weiguo Li <liwg06@foxmail.com> wrote:
>
> Fixes: 804c108b039a ("common/cnxk: set BPHY IRQ handler")


Cc: stable@dpdk.org

> Signed-off-by: Weiguo Li <liwg06@foxmail.com>
> ---

Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied to dpdk-next-net-mrvl/for-next-net. Thanks


>  drivers/common/cnxk/roc_bphy_irq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/common/cnxk/roc_bphy_irq.c b/drivers/common/cnxk/roc_bphy_irq.c
> index f4e9b341af..f4954d2a28 100644
> --- a/drivers/common/cnxk/roc_bphy_irq.c
> +++ b/drivers/common/cnxk/roc_bphy_irq.c
> @@ -259,7 +259,7 @@ roc_bphy_irq_handler_set(struct roc_bphy_irq_chip *chip, int irq_num,
>
>         CPU_ZERO(&intr_cpuset);
>         CPU_SET(curr_cpu, &intr_cpuset);
> -       retval = pthread_setaffinity_np(pthread_self(), sizeof(intr_cpuset),
> +       rc = pthread_setaffinity_np(pthread_self(), sizeof(intr_cpuset),
>                                         &intr_cpuset);
>         if (rc < 0) {
>                 plt_err("Failed to set affinity mask");
> --
> 2.25.1
>
  

Patch

diff --git a/drivers/common/cnxk/roc_bphy_irq.c b/drivers/common/cnxk/roc_bphy_irq.c
index f4e9b341af..f4954d2a28 100644
--- a/drivers/common/cnxk/roc_bphy_irq.c
+++ b/drivers/common/cnxk/roc_bphy_irq.c
@@ -259,7 +259,7 @@  roc_bphy_irq_handler_set(struct roc_bphy_irq_chip *chip, int irq_num,
 
 	CPU_ZERO(&intr_cpuset);
 	CPU_SET(curr_cpu, &intr_cpuset);
-	retval = pthread_setaffinity_np(pthread_self(), sizeof(intr_cpuset),
+	rc = pthread_setaffinity_np(pthread_self(), sizeof(intr_cpuset),
 					&intr_cpuset);
 	if (rc < 0) {
 		plt_err("Failed to set affinity mask");