mbox series

[V5,0/2] tests/rss_gtpogre: add a new case to PF and VF gtpogre

Message ID 1623047479-221222-1-git-send-email-xiangx.an@intel.com (mailing list archive)
Headers
Series tests/rss_gtpogre: add a new case to PF and VF gtpogre |

Message

Xiang An June 7, 2021, 6:31 a.m. UTC 
  v5:
- at v4, forget recovery a dpdk file, v5 have fix it

v4:
- optimize the dts script with add a print for dpdk

v3:
- Revised title

v2:
- fix the Trailing blanks in suite: cvl_advanced_rss_gtpogre

v1:
- add a case 'parse_pfcp_over_gre_packet'

Xiang An (2):
  tests/cvl_advanced_rss_gtpogre: add case parse_pfcp_over_gre_packet
  tests/cvl_advanced_iavf_rss_gtpogre: add case
    parse_pfcp_over_gre_packet

 tests/TestSuite_cvl_advanced_iavf_rss_gtpogre.py | 55 ++++++++++++++++++++++++
 tests/TestSuite_cvl_advanced_rss_gtpogre.py      | 55 ++++++++++++++++++++++++
 2 files changed, 110 insertions(+)

Comments

Peng, Yuan June 7, 2021, 6:33 a.m. UTC | #1 
Acked-by Peng, Yuan <yuan.peng@intel.com>

-----Original Message-----
From: An, XiangX <xiangx.an@intel.com> 
Sent: Monday, June 7, 2021 2:31 PM
To: dts@dpdk.org
Cc: Peng, Yuan <yuan.peng@intel.com>; An, XiangX <xiangx.an@intel.com>
Subject: [dts][PATCH V5 0/2] tests/rss_gtpogre: add a new case to PF and VF gtpogre
David Marchand June 7, 2021, 9:01 a.m. UTC | #2 
On Mon, Jun 7, 2021 at 8:33 AM Peng, Yuan <yuan.peng@intel.com> wrote:
>
> Acked-by Peng, Yuan <yuan.peng@intel.com>

NAK on this series.
Please, stop changing DPDK sources in the test tool.
Honnappa Nagarahalli June 7, 2021, 7:41 p.m. UTC | #3 
+ Lijuan

<snip>

> 
> On Mon, Jun 7, 2021 at 8:33 AM Peng, Yuan <yuan.peng@intel.com> wrote:
> >
> > Acked-by Peng, Yuan <yuan.peng@intel.com>
> 
> NAK on this series.
> Please, stop changing DPDK sources in the test tool.
+1

Hi Yuan/An,
	I am not sure if you are aware of a DTS WG that the Techboard has setup. The goal of this WG is to find a path to make it mandatory to submit a DTS test case along with the patches to DPDK. One ask from this WG is that the test case should not modify the DPDK code to ensure we are testing a sane code base.

While writing the test case, please think if the DPDK code lacks something which would benefit overall. You could submit such as patch to the DPDK community rather than changing the code in DTS. You could also submit a bug report which the community can look into.

If you need more info, Lijuan from Intel is involved in this WG, she can provide more information.

Thank you,
Honnappa

> 
> 
> --
> David Marchand