diff mbox series

[V2] tests/checksum_offload & tests/rxtx_offload: adapt DPDK bad UDP checksum's change

Message ID 1615441846-10725-1-git-send-email-junx.w.zhou@intel.com (mailing list archive)
State Accepted
Headers
Series [V2] tests/checksum_offload & tests/rxtx_offload: adapt DPDK bad UDP checksum's change |

Commit Message

Zhou, JunX W March 11, 2021, 5:50 a.m. UTC 
  v1: modify dts for adapt DPDK bad UDP checksum change from PKT_RX_L4_CKSUM_BAD 
     to PKT_RX_L4_CKSUM_UNKNOWN 

v2: add DPDK change UDP checksum version: 21.02 rc3

Signed-off-by: Zhou Jun <junx.w.zhou@intel.com>
---
 tests/TestSuite_checksum_offload.py | 7 ++-----
 tests/TestSuite_rxtx_offload.py     | 5 +----
 2 files changed, 3 insertions(+), 9 deletions(-)

Comments

Zhou, JunX W March 11, 2021, 5:57 a.m. UTC | #1 
>-----Original Message-----
>From: Zhou, JunX W 
>Sent: Thursday, March 11, 2021 1:51 PM
>To: dts@dpdk.org
>Cc: Zhou, JunX W <junx.w.zhou@intel.com>
>Subject: [dts][PATCH V2] tests/checksum_offload & tests/rxtx_offload: adapt DPDK bad UDP checksum's change
>
>v1: modify dts for adapt DPDK bad UDP checksum change from PKT_RX_L4_CKSUM_BAD 
>     to PKT_RX_L4_CKSUM_UNKNOWN 
>
>v2: add DPDK change UDP checksum version: 21.02 rc3
>
>Signed-off-by: Zhou Jun <junx.w.zhou@intel.com>

Tested-by: Zhou, Jun <junx.w.zhou@intel.com>
Tu, Lijuan March 15, 2021, 6:32 a.m. UTC | #2 
> v1: modify dts for adapt DPDK bad UDP checksum change from
> PKT_RX_L4_CKSUM_BAD
>      to PKT_RX_L4_CKSUM_UNKNOWN
> 
> v2: add DPDK change UDP checksum version: 21.02 rc3
> 
> Signed-off-by: Zhou Jun <junx.w.zhou@intel.com>

Applied with commit message changed.
diff mbox series

Patch

diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py
index 37bb4ee..eee0910 100644
--- a/tests/TestSuite_checksum_offload.py
+++ b/tests/TestSuite_checksum_offload.py
@@ -193,10 +193,7 @@  class TestChecksumOffload(TestCase):
                             if (flag == 1):
                                 self.verify("PKT_RX_L4_CKSUM_GOOD" in line, "Packet Rx L4 checksum valid-flags error!")
                             elif (flag == 0):
-                                if self.nic == "cavium_a063":
-                                    self.verify("PKT_RX_L4_CKSUM_BAD" in line or "PKT_RX_L4_CKSUM_UNKNOWN" in line, "Packet Rx L4 checksum valid-flags error!")
-                                else:
-                                    self.verify("PKT_RX_L4_CKSUM_BAD" in line, "Packet Rx L4 checksum valid-flags error!")
+                                self.verify("PKT_RX_L4_CKSUM_BAD" in line or "PKT_RX_L4_CKSUM_UNKNOWN" in line, "Packet Rx L4 checksum valid-flags error!")
                     else:
                         if "PKT_RX_L4_CKSUM" not in line:
                             self.verify(0, "There is no L4 checksum flags appeared!")
@@ -207,7 +204,7 @@  class TestChecksumOffload(TestCase):
                                 self.verify("PKT_RX_L4_CKSUM_GOOD" in line, "Packet Rx L4 checksum valid-flags error!")
                                 self.verify("PKT_RX_IP_CKSUM_GOOD" in line, "Packet Rx IP checksum valid-flags error!")
                             elif (flag == 0):
-                                self.verify("PKT_RX_L4_CKSUM_BAD" in line, "Packet Rx L4 checksum valid-flags error!")
+                                self.verify("PKT_RX_L4_CKSUM_BAD" in line or "PKT_RX_L4_CKSUM_UNKNOWN" in line, "Packet Rx L4 checksum valid-flags error!")
                                 self.verify("PKT_RX_IP_CKSUM_BAD" in line, "Packet Rx IP checksum valid-flags error!")
 
         self.dut.send_expect("stop", "testpmd>")
diff --git a/tests/TestSuite_rxtx_offload.py b/tests/TestSuite_rxtx_offload.py
index d0331dc..0e70526 100644
--- a/tests/TestSuite_rxtx_offload.py
+++ b/tests/TestSuite_rxtx_offload.py
@@ -271,10 +271,7 @@  class TestRxTx_Offload(TestCase):
                     else:
                         self.verify("PKT_RX_IP_CKSUM_GOOD" in line, "ipv4 checksum flag is wrong!")
                     if ("udp" in flags) or ("tcp" in flags):
-                        if self.nic in ['cavium_a063', 'cavium_a064']:
-                            self.verify("PKT_RX_L4_CKSUM_BAD" or "PKT_RX_L4_CKSUM_UNKNOWN" in line, "L4 checksum flag is wrong!")
-                        else:
-                            self.verify("PKT_RX_L4_CKSUM_BAD" in line, "L4 checksum flag is wrong!")
+                        self.verify("PKT_RX_L4_CKSUM_BAD" or "PKT_RX_L4_CKSUM_UNKNOWN" in line, "L4 checksum flag is wrong!")
                     else:
                         self.verify(("PKT_RX_L4_CKSUM_GOOD" in line) or ("PKT_RX_L4_CKSUM_UNKNOWN" in line), "L4 checksum flag is wrong!")
         # collect the tx checksum result